- 10 Apr, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/86179ebcb99567b956e788bb1a100c262f533083 Work around unicode issues by re-encoding properties as utf-8 (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I6a850e86de670587555ba808a99b98eb3e939e55 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/472666 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 08 Apr, 2017 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/2ea2b19c4deb2f81b462754509e2c858e73078ec Refactor and clean up unit tests a bit. (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: I8bf8481c196523f1a4db72a001fef0085399caa5 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/472446 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 07 Apr, 2017 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/11a5a6648f538d56cd5a48169f7b349e2d71886c Enable bootstrap by default when invoking test command (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I6d403722187d2ac73f1a2d53a23b272fa6d0d983 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471766 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/0fdbf0025e0a814b0c2ea8c787d24aeab0ecb99b Add --disable-bootstrap option to recipe engine (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I06e634276389b6367fae59278a880c91fb2c05a4 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471647 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/162f5cba2739078a1ff263c9898fa31690864481 Revert of Enable recipe bootstrap by default (patchset #1 id:1 of https://codereview.chromium.org/2801073004/ ) (phajdan.jr@chromium.org) https://crrev.com/22e9f7a530a72ede0b5390687cfffb79e3e5bf60 Revert of Disable bootstrap for recipes.py invocations in autoroll (patchset #1 id:1 of https://codereview.chromium.org/2801273002/ ) (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I25be05fc56eda7495d814f3a02bc9617dcfe9924 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471368 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/bbe066964830adfaa2298d0fd77e02b86bcd48ea Disable bootstrap for recipes.py invocations in autoroll (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I31fa2e650e2e96c41c077721da240e332d10fe5b Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471367 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/0497d326e1805715e8df4095afa6d0e95b9af48f Revert of Assert validity of stream parameters. (patchset #4 id:60001 of https://codereview.chromium.org/2792333003/ ) (phajdan.jr@chromium.org) https://crrev.com/ab1007e993f5ae367c15389afb954591bf3376dd autoroll: don't send output from "fetch" command to NUL (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: Ia5536063fb3bbd243b66b31f418c3b2e9b08c4ef Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471566 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Paweł Hajdan, Jr authored
TBR=iannucci Bug: None Change-Id: Iab6ab1f8ad19d3b6b5496f907ef001eec3d2d9e7 Reviewed-on: https://chromium-review.googlesource.com/471426Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/d7f80cacbb5c61e5bdaaff122fb5ab0ea7b58345 Fix recipe bootstrap on Windows (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I052ad4f75b17d2631250db1a4c854d4c305b93de Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/471366 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 06 Apr, 2017 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/796247003f570b54140f9cc6e7934bcdf11880e7 Put result.proto into recipe_engine proto package (nodir@chromium.org) TBR=iannucci@chromium.org Change-Id: I04d63c3a30e7330cd0f275b015c1c8456b7cde1b Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/470766 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/ddfc94f01e4e1d3c7bf7dedfd58e6813bc5160df Assert validity of stream parameters. (dnj@chromium.org) TBR=iannucci@chromium.org Change-Id: I2da3668b70298a3219b32c62304bf2a903260e8c Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/470646 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Lei Zhang authored
- TODO regarding --trybot-json - TODO regarding SVN - Remove else before return BUG=583578 Change-Id: I486d4a48ecca729ec2ecfb78f41d4be28665f37d Reviewed-on: https://chromium-review.googlesource.com/467266Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/0160aa0a9b2b85379a8e80090d753fef20e6dce5 Add deprecation warning to simulation_test command (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: Iba2f7023a927bf682c57980b253c65c94a15dcf4 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/470347 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 05 Apr, 2017 5 commits
-
-
Dan Jacques authored
If the Infra Git wrapper is managing a Git execution, "git_retry" will impose a second set of retries. Recognize this situation and disable "git_retry" so that the Git wrapper is the sole managing process. BUG=chromium:703868 TEST=local - Ran with and without environment variable, seems to work. Change-Id: I4f749c9693a761abe2a062ed5f1dc09f51c69e30 Reviewed-on: https://chromium-review.googlesource.com/469229 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/e9b07327159884c40cc81744361d0018c5cf481c absolutize paths specified in args (nodir@chromium.org) TBR=iannucci@chromium.org Change-Id: I054d76ea6a23446442aeb9ddaf63dbbc850140e6 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/468747 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Jochen Eisinger authored
BUG=694222 R=dpranke@chromium.org Change-Id: Ie841332129dd6fa8555d2e940c919b812fc9408d Reviewed-on: https://chromium-review.googlesource.com/467250Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 0267fd2c. Reason for revert: seems to have changed some behavior as reported by SKIA. Original change's description: > git cl upload for Gerrit: use push options instead of refspec. > > This removes limitation of no special chars in patchset titles. > > BUG=chromium:663787,chromium:707963,gerrit:5184 > R=sergiyb@chromium.org,agable@chromium.org > TEST=uploaded this CL using depot_tools with this patch :) > > Change-Id: I5d684d0a0aa286a45ff99cca6d57aefa8436cd0f > Reviewed-on: https://chromium-review.googlesource.com/468926 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@google.com> > TBR=agable@chromium.org,sergiyb@google.com,tandrii@chromium.org,sergiyb@chromium.org,borenet@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:663787,chromium:707963,gerrit:5184 Change-Id: I3306091b14b97a200150389d0480b69120af8c61 Reviewed-on: https://chromium-review.googlesource.com/469006Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This removes limitation of no special chars in patchset titles. BUG=chromium:663787,chromium:707963,gerrit:5184 R=sergiyb@chromium.org,agable@chromium.org TEST=uploaded this CL using depot_tools with this patch :) Change-Id: I5d684d0a0aa286a45ff99cca6d57aefa8436cd0f Reviewed-on: https://chromium-review.googlesource.com/468926 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@google.com>
-
- 04 Apr, 2017 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/0586f16a4911be4855ce52621e143662e1d58062 Always identify test names that lead to failures (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: Ie62d48950b162155fca19793e3c8037caa2ba00c Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/468187 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/189f7dcc9e1151e6714987e26eb7de14c531d3ae Implement 'diff' sub-command in new 'test' command (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: Iec3f053e6856c3487802bb51e2634050b60da0c2 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/468166 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Jochen Eisinger authored
This allows for having some global comments such as timezones or long-term unavailability. The comments go into build/OWNERS.status (that way, they should be available in all repos that map in build/ for the gn config files). The local can be overwritten in codereview.settings. The format is email: status Comments (starting with #) are allowed in that file, but they're ignored. BUG=694222 R=dpranke@chromium.org Change-Id: I49f58be87497d1ccaaa74f0a2f3d373403be44e7 Reviewed-on: https://chromium-review.googlesource.com/459542 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
anatoly techtonik authored
Bug: 703064 Change-Id: I319e89a43533b86c0eedff56fec2665fa13e728c Reviewed-on: https://chromium-review.googlesource.com/466006 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 03 Apr, 2017 2 commits
-
-
Aaron Gable authored
Bug: 707313 Change-Id: Ic3860aa6b9aeaba3ec02ab8dac8dd63429f917cc Reviewed-on: https://chromium-review.googlesource.com/466688Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
anatoly techtonik authored
Bug: Change-Id: Ife7f4049062bc951e58d5c322b1fc7e39338fe79 Reviewed-on: https://chromium-review.googlesource.com/463246 Commit-Queue: anatoly techtonik <techtonik@gmail.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 02 Apr, 2017 1 commit
-
-
anatoly techtonik authored
xcopy flags replaced - /i dest is directory, /q quiet, /d newer, /y yes Bug: 707150 Change-Id: I3fe47dae78bd7153aa66dbf207f8d8c73eb4dc83 Reviewed-on: https://chromium-review.googlesource.com/464866Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: anatoly techtonik <techtonik@gmail.com>
-
- 31 Mar, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/e02889f17c4ac35b7fb99915c5e05a9dde1347c0 test: promote --train to its own subcommand (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: If2fa16ba4938ac654e01b193c900f6f90fa22d0b Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/465326 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/09292e372498915b899f480ce9f384057dc5710c Implement debug (pdb) support in new 'test' command (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: Ic8fb59da051b6551abc4c2d85e4df8b3d7f7eebf Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/465286 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/1af805aac5b8735be9effce6251286d062755257 Convert structured output of 'test' command to protos (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Change-Id: I1af529baa8f4bb5f57d9f3f2ddaf2e19cc88cfa4 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/464966 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
- 30 Mar, 2017 1 commit
-
-
Aaron Gable authored
This is a hack to support the most common git workflow: keeping a local branch named 'master' which is a replica of 'origin/master' with no local changes, and basing all feature branches off of that. Test: * created master branch, created feature branch, uploaded CL correctly * created master branch, landed change on master branch, created feature branch, uploaded CL, CL contains change on master too * created non-master branch, created feature branch, failed to upload CL Bug: 682104 Change-Id: I8481b787e6dcab162d2846c07f1ddad950f491e0 Reviewed-on: https://chromium-review.googlesource.com/464107Reviewed-by: Andrew Bonventre <andybons@google.com> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 29 Mar, 2017 7 commits
-
-
Robert Iannucci authored
Bug: Change-Id: I66060bbf29a5940041eecfac70df6dae0894887f Reviewed-on: https://chromium-review.googlesource.com/462595 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/e77477ba61ef082e2e34d58fd1251a1cb707f698 make doc/recipes.py supported version 1 and 2 (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: I0dce7abdcf831c81aa8144b9bef9ceb14a65b425 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/462655 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/855168108b3dab668c36b56a99ca5a73f6d98932 [recipes.cfg] upgrade to api_version 2 (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: I4e361cd1afeeac49c9fba7467834ea840b71e1ce Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/462615 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/9f7465ffe92dab0bcc6f4d0e60303c6bff4d0f72 [recipes.cfg] Add disable reason. (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: I37a683f7974c29d1d45344f9897908478feebb42 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/462535 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
Robert Iannucci authored
This is needed for making PostUploadHooks that don't have to re-invent the git footers library. Bug: Change-Id: I0a0ccf3dffd25152c2c273487ddbd9b279d80678 Reviewed-on: https://chromium-review.googlesource.com/461729Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
anatoly techtonik authored
Bug: Change-Id: Ib089dd4d9c6ee5ed93e12fd588e28a2eecff3690 Reviewed-on: https://chromium-review.googlesource.com/461184Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
anatoly techtonik authored
Windows paths use backward slash separator, which escapes regular expressions for white and black lists in PRESUBMIT.py filters See https://goo.gl/6c7aku for discussion Bug: Change-Id: Ia1d133c5b6cfa6cb364b1500b7b7abe583bce346 Reviewed-on: https://chromium-review.googlesource.com/461141 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
-
- 28 Mar, 2017 4 commits
-
-
Bruce Dawson authored
The versions of dbghelp.dll that ship with the latest 10.0.14393.0 SDK (yes, there are multiple versions) as of the VS 2017 launch cannot handle /debug:fastlink binaries created by VS 2017. This leads to hangs during symbol lookup, as reported here: https://developercommunity.visualstudio.com/content/problem/36255/chromes-base-unittests-fails-with-vs-2017-due-to-s.html The recommended fix is to copy dbghelp.dll from the VS install instead, from Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions\CppUnitFramework Without this fix base_unittests will hang and windbg will not work on /debug:fastlink binaries. With this fix base_unittests completes promptly. BUG=683729 Change-Id: Ie58b9d898a1feb04f11e99891035d2e40a2a9c0f Reviewed-on: https://chromium-review.googlesource.com/461385Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Robert Iannucci authored
Bug: Change-Id: Ie6b0df9729cdd34f138005ea811d2475de973a94 Reviewed-on: https://chromium-review.googlesource.com/461246Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2 [package.proto] convert deps from list to map. (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: I054023de3fb57a4680ba1e83c0f3942ca681484e Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/461401 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/8ec7b6d3ca59e7c178ad1b03e4408da556fddafa [recipes.cfg] set canonical_url and autoroller options (iannucci@chromium.org) TBR=iannucci@chromium.org Change-Id: Ia29d2ce955cc58c0ffbed15eee8aaa93a1cb6b6d Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/461557 Reviewed-by: <recipe-roller@chromium.org> Commit-Queue: <recipe-roller@chromium.org>
-