- 15 Dec, 2016 6 commits
-
-
Aaron Gable authored
This is a reland of 947f2ee8, which was reverted in a5a1eea5 BUG=672332 Change-Id: If33c54e500fbeac11f60d81a19549880506c63d8 Reviewed-on: https://chromium-review.googlesource.com/419737Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
For example, v8 has refs/heads/1.4.2 TBR=machenbach@chromium.org BUG=chromium:674448 Change-Id: Ia3405ee402a01153fc9744457d8fee9385446cae Reviewed-on: https://chromium-review.googlesource.com/420285Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Robbie Iannucci authored
This reverts commit 70f351e7. Reason for revert: CIPD bootstrap is now PS 2.0 compatible. BUG=674363,673940 Original change's description: > Revert "Stop adhoc cipd client bootstrap." > > This reverts commit c6569aab. > > Reason for revert: This caused crbug.com/674363, needs further investigation. > > Original change's description: > > Stop adhoc cipd client bootstrap. > > > > This was used before to get the git installer, but now depot_tools manages its > > own copy of CIPD. > > > > BUG=673940 > > > > Change-Id: I1077ff7eb27d9ca191dc0092b7cacaaa69c40449 > > Reviewed-on: https://chromium-review.googlesource.com/420303 > > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > > > > TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,sebmarchand@chromium.org,chromium-reviews@chromium.org > BUG=673940 > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I7aa5561ad0df67831987cd8d53a84105d42d9663 > Reviewed-on: https://chromium-review.googlesource.com/420320 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,chromium-reviews@chromium.org,sebmarchand@chromium.org BUG=673940 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I822312b1507003ee07930ef7527e12b997457673 Reviewed-on: https://chromium-review.googlesource.com/420321 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Robert Iannucci authored
BUG=673940 Change-Id: I64d26454db3693499d4fb8f82bafb9eb04125c0d Reviewed-on: https://chromium-review.googlesource.com/420408Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Robbie Iannucci authored
This reverts commit c6569aab. Reason for revert: This caused crbug.com/674363, needs further investigation. Original change's description: > Stop adhoc cipd client bootstrap. > > This was used before to get the git installer, but now depot_tools manages its > own copy of CIPD. > > BUG=673940 > > Change-Id: I1077ff7eb27d9ca191dc0092b7cacaaa69c40449 > Reviewed-on: https://chromium-review.googlesource.com/420303 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > TBR=iannucci@chromium.org,agable@chromium.org,vadimsh@chromium.org,dnj@chromium.org,sebmarchand@chromium.org,chromium-reviews@chromium.org BUG=673940 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I7aa5561ad0df67831987cd8d53a84105d42d9663 Reviewed-on: https://chromium-review.googlesource.com/420320 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Robert Iannucci authored
This was used before to get the git installer, but now depot_tools manages its own copy of CIPD. BUG=673940 Change-Id: I1077ff7eb27d9ca191dc0092b7cacaaa69c40449 Reviewed-on: https://chromium-review.googlesource.com/420303 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
- 14 Dec, 2016 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/63c1741d42b2e5e77af929cbdf7f69c03f35b627 Fix _GEN_TEST_CACHE. (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2579563002
-
Aaron Gable authored
This is a fix to 32978d96, which introduced a "Landed as <gerrit link>" feature to git-cl, but which at the last minute introduced a typo causing the whole feature to not actually work. BUG=661187 Change-Id: Ifef3379a51f035973bc5f3842862528f90bfdf84 Reviewed-on: https://chromium-review.googlesource.com/419782Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
BUG=669153 Change-Id: I1e078bfc83ccfa4fd3785fd7388560c4ba43b735 Reviewed-on: https://chromium-review.googlesource.com/416389Reviewed-by: Mike Stipicevic <stip@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Quinten Yearsley authored
Purpose: This is a unit test method refactoring to try to improve readability; I made this when adding unit tests for https://chromium-review.googlesource.com/c/419148/. In this CL: - Extract ExampleChange helper method - Explicitly write names of args for DoPresubmitChecks - Other minor changes to make the style more consistent Change-Id: I52236e285e50db890245c6c4b69c70ddf258f140 Reviewed-on: https://chromium-review.googlesource.com/419184Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
Andrii Shyshkalov authored
In other words, end 2 end test was a really awesome idea. R=machenbach@chromium.org,sergiyb@chromium.org BUG=642493 TEST=git cl land of https://codereview.chromium.org/2575043003 succeeded Change-Id: I568ce79baf109b2aa556e4343527b63f39c10d00 Reviewed-on: https://chromium-review.googlesource.com/419478 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
R=sergiyb@google.com BUG=chromium:642493 Change-Id: Id7b732d82c25ce88a3295ff54c79cf2a66e0d5b9 Reviewed-on: https://chromium-review.googlesource.com/419437Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 947f2ee8. Reason for revert: unnecessarily sets the title for the first upload, which isn't done for Rietveld. Original change's description: > Generate patchset name from commit subject > > BUG=672332 > > Change-Id: If9c662f11b217a52cac7c9c47ad9f3d978148c2e > Reviewed-on: https://chromium-review.googlesource.com/419330 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org BUG=672332 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I9dcec1b02c8f16ceca8338acef4a1fc174aef35c Reviewed-on: https://chromium-review.googlesource.com/419517 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/a556ab48b2ae66184ccc49bfd37775a245faa87c Add repr and str methods to config.Dict (dsansome@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2571153002
-
- 13 Dec, 2016 3 commits
-
-
Aaron Gable authored
BUG=672332 Change-Id: If9c662f11b217a52cac7c9c47ad9f3d978148c2e Reviewed-on: https://chromium-review.googlesource.com/419330 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Aaron Gable authored
If either the edit creation or edit publishing fail, we're left with an unpublished edit hanging around. This can result in a follow-up invocation of 'git cl desc' (e.g. if the user changes their mind, or retries) will also fail. So, clean up after ourselves. BUG=671091 Change-Id: Icfe53996acf2555b82be0695a3c86ebb8c50b936 Reviewed-on: https://chromium-review.googlesource.com/418449Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Robert Iannucci authored
This takes advantage of powershell on windows for a cleanish duplicate of the posix version. R=dnj@chromium.org, vadimsh@chromium.org BUG=663843 Change-Id: Ib23a044ff912e3239b58848a26143eb6575826d5 Reviewed-on: https://chromium-review.googlesource.com/414228 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
- 09 Dec, 2016 2 commits
-
-
Andrii Shyshkalov authored
R=machenbach@chromium.org BUG=chromium:642493,672043 Change-Id: Ie50637d6e01e40ddd15dcdfc1430c9554fa82976 Reviewed-on: https://chromium-review.googlesource.com/418715Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org,machenbach@chromium.org BUG= Change-Id: Ia89e91479c22adeebc85a4432cd9f7b8d95a8fde Reviewed-on: https://chromium-review.googlesource.com/418655Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 08 Dec, 2016 2 commits
-
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org Change-Id: I2df867e381ceb1035add84563d3b444b0ee0ea94 Reviewed-on: https://chromium-review.googlesource.com/417267Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
BUG=chromium:642493,672043 R=machenbach@chromium.org,iannucci@chromium.org Change-Id: I0abc31b95b1766fd5fd24c1379b538d0c5291011 Reviewed-on: https://chromium-review.googlesource.com/417259Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
- 07 Dec, 2016 1 commit
-
-
Andrii Shyshkalov authored
The new class is unused and doesn't change any existing functionality. BUG=chromium:642493 R=machenbach@chromium.org,iannucci@chromium.org Change-Id: Id3fe71b07b694339f0a620b427816e52560069d8 Reviewed-on: https://chromium-review.googlesource.com/416430Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 06 Dec, 2016 1 commit
-
-
Andrii Shyshkalov authored
BUG=642493 R=sergiyb@chromium.org Change-Id: I5d8588f2b6f30368188aecab2d2c462a11aa6883 Reviewed-on: https://chromium-review.googlesource.com/414369 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 05 Dec, 2016 3 commits
-
-
John Budorick authored
This adds an ndk_next gclient configuration to allow bots to use the upcoming version of the Android NDK. BUG=668202 Change-Id: I403e398094f4215cdb3783b68f465323264ca1ee Reviewed-on: https://chromium-review.googlesource.com/414184 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Mike Stipicevic <stip@chromium.org>
-
Michael Achenbach authored
BUG=v8:5603 Change-Id: Ib7bbdfae070ae4c55f99041befbade942d1d3f9c Reviewed-on: https://chromium-review.googlesource.com/416859 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
BUG=642493 Change-Id: Ic8eb121b0ad7adcc7a3f3f1967ef2261f415e731 Reviewed-on: https://chromium-review.googlesource.com/414466Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 02 Dec, 2016 2 commits
-
-
Mike Stipicevic authored
BUG=670678 Change-Id: I70f39618eea7dd6428d18e5ba60b539cdd57889c Reviewed-on: https://chromium-review.googlesource.com/416357 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
R=agable@chromium.org BUG=644101 TEST=manual Change-Id: I82b7209981a834c8f26d65d2701d665a4eb2ba51 Reviewed-on: https://chromium-review.googlesource.com/415829Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 01 Dec, 2016 2 commits
-
-
Henrik Kjellander authored
This is needed in order to be able to use the set_component_rev feature in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=0&l=169 which is needed for having the testers to sync the same WebRTC revision as the builders. This is a follow-up for https://chromium-review.googlesource.com/c/414110 BUG=chromium:669818 TBR=tandrii@chromium.org Change-Id: I6ca77e739513009e503a3b2a6fedacde8730e9a4 Reviewed-on: https://chromium-review.googlesource.com/415788Reviewed-by: Henrik Kjellander <kjellander-cc@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org>
-
Henrik Kjellander authored
BUG=chromium:669818 TBR=tandrii@chromium.org Change-Id: Icbefd12bd891c8fdb7b8278083f8b1accb53500c Reviewed-on: https://chromium-review.googlesource.com/414110 Commit-Queue: Henrik Kjellander <kjellander-cc@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
- 29 Nov, 2016 3 commits
-
-
Andrii Shyshkalov authored
R=katthomas@chromium.org,sergiyb@chromium.org BUG=chromium:601260 Change-Id: I79e1e807d1f8aed8d294742974d1f42a852c6b13 Reviewed-on: https://chromium-review.googlesource.com/415147 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Sergiy Byelozyorov authored
BUG=668162 Change-Id: Ie38542eb4627aa8c07adf9d2665b80cdcee2758f Reviewed-on: https://chromium-review.googlesource.com/414355 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Aaron Gable authored
Change-Id: I17884d9ef7efdaf75ed575e66aca1034db0672b5 Reviewed-on: https://chromium-review.googlesource.com/413289Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 28 Nov, 2016 2 commits
-
-
Mike Stipicevic authored
BUG=668526 Change-Id: Id49f1c1394a72880410eb06ba7356307fff7e8c5 Reviewed-on: https://chromium-review.googlesource.com/414496 Commit-Queue: Mike Stipicevic <stip@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
-
Sergiy Byelozyorov authored
BUG=668526 Change-Id: I8aa762e8836ddc4838baaca803de17f3ffcb1ad2 Reviewed-on: https://chromium-review.googlesource.com/414908Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 24 Nov, 2016 4 commits
-
-
Andrii Shyshkalov authored
R=sergiyb@chromium.org BUG=642493 Change-Id: Ic4acf4076fdf27c1ed5e75f0ed1dda4b16d675fc Reviewed-on: https://chromium-review.googlesource.com/414469Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
BUG=642493 Change-Id: I1c83c54f7ad938cf4abeadb42f8d9414521d6dc5 Reviewed-on: https://chromium-review.googlesource.com/414465Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
BUG=642493 Change-Id: Ib1234922e4bcd4ee286fffb8f7c637e4d2442a42 Reviewed-on: https://chromium-review.googlesource.com/414504 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Andrii Shyshkalov authored
This is preperatory work for Cr- footers generation in git cl instead of gnumbd. BUG=642493 Change-Id: I4cfdd882fe6caa7972e51ffa81d335104ddb56dd Reviewed-on: https://chromium-review.googlesource.com/414464 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
-
- 22 Nov, 2016 1 commit
-
-
agable authored
R=maruel@chromium.org BUG=475320 Review-Url: https://codereview.chromium.org/2394043002
-