Commit 02cdbb45 authored by Aaron Gable's avatar Aaron Gable Committed by Commit Bot

Fix gerrit/gitiles typo in git_cl

This is a fix to 32978d96,
which introduced a "Landed as <gerrit link>" feature to git-cl, but
which at the last minute introduced a typo causing the whole feature
to not actually work.

BUG=661187

Change-Id: Ifef3379a51f035973bc5f3842862528f90bfdf84
Reviewed-on: https://chromium-review.googlesource.com/419782Reviewed-by: 's avatarStephen Martinis <martiniss@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
parent f5644a92
......@@ -2704,7 +2704,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
print('Issue %s has been submitted.' % self.GetIssueURL())
links = self._GetChangeCommit().get('web_links', [])
for link in links:
if link.get('name') == 'gerrit' and link.get('url'):
if link.get('name') == 'gitiles' and link.get('url'):
print('Landed as %s' % link.get('url'))
break
return 0
......
......@@ -2763,7 +2763,7 @@ class TestGitCl(TestCase):
}
cl._codereview_impl._GetChangeCommit = lambda: {
'commit': 'deadbeef',
'web_links': [{'name': 'gerrit',
'web_links': [{'name': 'gitiles',
'url': 'https://git.googlesource.com/test/+/deadbeef'}],
}
cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment