Right now I get

Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...

which isn't very informative (or at least a bit confusing as to why it's
doing the same thing 6 times).

R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1671433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=584197

Review URL: https://codereview.chromium.org/1668803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/1670503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298586 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the option to use the current issue number, if any,
when doing a git cl patch. Instead of doing git cl issue (copy the
number) git cl patch <number>, one can simply do git cl patch -i

BUG=

Review URL: https://codereview.chromium.org/1641903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=440500

Review URL: https://codereview.chromium.org/1663753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298580 0039d316-1c4b-4281-b951-d872f2087c98

Gerrit doesn’t support patch titles.

BUG=579178

Review URL: https://codereview.chromium.org/1659633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298573 0039d316-1c4b-4281-b951-d872f2087c98

Original attempt: https://codereview.chromium.org/1660943002

Now adds depot_tools at the end of PATH to avoid issues with python
on Windows.

TBR=jochen

BUG=437264

Review URL: https://codereview.chromium.org/1661953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298562 0039d316-1c4b-4281-b951-d872f2087c98

Revert of bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (patchset #1 id:1 of https://codereview.chromium.org/1660943002/ )

Reason for revert:
I believe this breaks trybot patching on Windows. 

Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811

Error: 
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command,
operable program or batch file.

I'm speculatively reverting.

Original issue's description:
> bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
> 
> BUG=437264
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556

TBR=jochen@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437264

Review URL: https://codereview.chromium.org/1662763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1634923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1660943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298556 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1660403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298554 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/1667713002

BUG=583626

Review URL: https://codereview.chromium.org/1663493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298552 0039d316-1c4b-4281-b951-d872f2087c98

I acknowledge this is really gross. This allows us to roll the changes into
build_limited in the short term.

Longer term, paths could be passed from outside.

BUG=582074

Review URL: https://codereview.chromium.org/1665753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298550 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the script requires you to pass the unwanted commits on the
command line, but eventually, you could configure it with a file
(checked into the repo) that provides a fixed set of commits to always
skip (such as commits that do a huge amount of renaming and nothing
else).

BUG=574290

Review URL: https://codereview.chromium.org/1559943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298544 0039d316-1c4b-4281-b951-d872f2087c98

This change packages the api-ms-* DLLs and the VS 2015 CRT DLLs in all
of the VS package directories that we add to the path, so that they can
run without having the UCRT installed.

The Common7\IDE path was removed because it isn't actually packaged, in
VS 2013 or VS 2015, so adding it to the path is purely confusing.

In addition to changing the packaging script the installation script has
to change in order to continue if the UCRT cannot be installed. It
still makes sense to try to install it, and print a message saying where
the installer is, for the convenience of Google developers who may want
more flexibility in running VS 2015 binaries.

A 'calculating hash' message was added to make the mysterious hashing
hangs (which can be several minutes long) less mysterious.

BUG=440500

Review URL: https://codereview.chromium.org/1660723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298541 0039d316-1c4b-4281-b951-d872f2087c98

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org

Review URL: https://codereview.chromium.org/1650993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298531 0039d316-1c4b-4281-b951-d872f2087c98

recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist.

R=martiniss@chromium.org,luqui@chromium.org
TBR=iannucci@chromium.org
BUG=582280

Review URL: https://codereview.chromium.org/1660163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=579160

Review URL: https://codereview.chromium.org/1656373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298525 0039d316-1c4b-4281-b951-d872f2087c98

Previous attempt: https://codereview.chromium.org/1642023002

TBR=martiniss

BUG=582074

Review URL: https://codereview.chromium.org/1651033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1655983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298516 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Adds bot_update to depot_tools. (patchset #8 id:140001 of https://codereview.chromium.org/1641363002/ )

Reason for revert:
Exposed recipe engine bug with ambiguous names, causing roller blockage.

Original issue's description:
> Adds bot_update to depot_tools.
> 
> This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming.
> 
> Also moves the recipe stuff into the infra folder.
> 
> bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192
> 
> TBR=phajdan.jr@chromium.org
> 
> BUG=
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298490

TBR=iannucci@chromium.org,phajdan.jr@chromium.org,martiniss@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review URL: https://codereview.chromium.org/1651323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1654603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298491 0039d316-1c4b-4281-b951-d872f2087c98

This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192

TBR=phajdan.jr@chromium.org

BUG=

Review URL: https://codereview.chromium.org/1641363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298490 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1655503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298489 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1652623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=582074,582229
TBR=phajdan.jr@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/1641373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298459 0039d316-1c4b-4281-b951-d872f2087c98

Revert of depot_tools: import bot_update gclient git rietveld tryserver recipe modules (patchset #6 id:100001 of https://codereview.chromium.org/1642023002/ )

Reason for revert:
breakages: https://code.google.com/p/chromium/issues/detail?id=582229

Original issue's description:
> depot_tools: import bot_update gclient git rietveld tryserver recipe modules
> 
> BUG=582074
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298447

TBR=maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582074, 582229

Review URL: https://codereview.chromium.org/1644173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298457 0039d316-1c4b-4281-b951-d872f2087c98

Small fix that makes it possible to use ninja and depot-tools using
the mingw64 chroot bundled in git 2.7.0
With this change I can build succesfully on Windows and still have
a civilized shell.

BUG=
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/1638303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=577647

Review URL: https://codereview.chromium.org/1644973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298449 0039d316-1c4b-4281-b951-d872f2087c98

BUG=582074

Review URL: https://codereview.chromium.org/1642023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298447 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the test being dependent on the system time, and undefined
behaviour resulting from negative timestamps in positive-offset
timezones.

BUG=581895

Review URL: https://codereview.chromium.org/1640973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298438 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1640923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298423 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add extensions parameter to Pylint presubmit check. (patchset #1 id:1 of https://codereview.chromium.org/1639493003/ )

Reason for revert:
Sorry, turns out this change isn't necessary. You can specify extension-pkg-whitelist in pylintrc.

Original issue's description:
> Add extensions parameter to Pylint presubmit check.
> 
> This allows Pylint to analyze code that relies on C extensions (like numpy).
> https://bitbucket.org/logilab/pylint/issues/58#comment-14920640
> 
> 
> BUG=
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298392

TBR=dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review URL: https://codereview.chromium.org/1646633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298419 0039d316-1c4b-4281-b951-d872f2087c98

git rev-parse --git-dir returns a relative path, e.g. ".git". This
should be resolved relative to the cwd of the git command instead of the
current working dir. The cwd of the git command is set to _parent_repo
(=the absolute path after resolving --parent_checkout), so use that.

TEST=The following completes without errors.
$ cd /tmp
$ git init somegitrepo
$ cd somegitrepo
$ git drover --branch [branch] --cherry-pick [hash] -v --dry-run --parent_checkout /path/to/src
$ cd /path/to/src
$ git drover --branch [branch] --cherry-pick [hash] -v --dry-run

Review URL: https://codereview.chromium.org/1640233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1642493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298413 0039d316-1c4b-4281-b951-d872f2087c98

R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1636833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298394 0039d316-1c4b-4281-b951-d872f2087c98

Without this, we'd cause unnecessary toolchain redownloads if vctip.exe
crashed.

R=brucedawson@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1639623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298393 0039d316-1c4b-4281-b951-d872f2087c98

This allows Pylint to analyze code that relies on C extensions (like numpy).
https://bitbucket.org/logilab/pylint/issues/58#comment-14920640


BUG=

Review URL: https://codereview.chromium.org/1639493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298392 0039d316-1c4b-4281-b951-d872f2087c98

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1617163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298381 0039d316-1c4b-4281-b951-d872f2087c98

Currently apply_issue fail if the content of a newly added file is
missing (because of the 900ko threshold in upload.py). But this doesn't
apply to the large file that get modified (instead of being added). This
is wrong because apply_issue will indicates a success without really
applying the patch.

It looks like the patch content is set to "None" in this cases (the string
value, not the empty value None).

Review URL: https://codereview.chromium.org/1612323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298366 0039d316-1c4b-4281-b951-d872f2087c98