Commit 84bbf510 authored by dtu@chromium.org's avatar dtu@chromium.org

Add extensions parameter to Pylint presubmit check.

This allows Pylint to analyze code that relies on C extensions (like numpy).
https://bitbucket.org/logilab/pylint/issues/58#comment-14920640


BUG=

Review URL: https://codereview.chromium.org/1639493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298392 0039d316-1c4b-4281-b951-d872f2087c98
parent a975ba5d
......@@ -694,7 +694,8 @@ def _FetchAllFiles(input_api, white_list, black_list):
def GetPylint(input_api, output_api, white_list=None, black_list=None,
disabled_warnings=None, extra_paths_list=None, pylintrc=None):
disabled_warnings=None, extra_paths_list=None, extensions=None,
pylintrc=None):
"""Run pylint on python files.
The default white_list enforces looking only at *.py files.
......@@ -729,11 +730,16 @@ def GetPylint(input_api, output_api, white_list=None, black_list=None,
input_api.logging.info('Skipping pylint: no matching changes.')
return []
extra_args = []
if extensions:
extra_args.append('--extension-pkg-whitelist=' + ','.join(extensions))
if pylintrc is not None:
pylintrc = input_api.os_path.join(input_api.PresubmitLocalPath(), pylintrc)
else:
pylintrc = input_api.os_path.join(_HERE, 'pylintrc')
extra_args = ['--rcfile=%s' % pylintrc]
extra_args.append('--rcfile=%s' % pylintrc)
if disabled_warnings:
extra_args.extend(['-d', ','.join(disabled_warnings)])
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment