- 06 Jul, 2018 3 commits
-
-
Edward Lemur authored
Skip adding origin if the branch name already has 'origin/'. Bug: 859703 Change-Id: I0141c04189d00187c202a7885a7c6bb74571e7ea Reviewed-on: https://chromium-review.googlesource.com/1128390Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Edward Lemur authored
When syncing remote branches, checkout origin/<branch> instead of <branch>, since there might be a local branch with that name. Bug: 859703 Change-Id: I9a49b940f53f75a97e5458fdcf578c3b52b26de2 Reviewed-on: https://chromium-review.googlesource.com/1128271Reviewed-by:
-
Michael Achenbach authored
Obviates need to call api.step.active_result by callers. Bug: 711249 Change-Id: Ibd3278df01fc8f9d7cc73eacc72d9fc57578808d Reviewed-on: https://chromium-review.googlesource.com/1127372Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 03 Jul, 2018 5 commits
-
-
Andrii Shyshkalov authored
Today, whenever LUCI scheduler sets gitiles_commit, a revision property is also always set, thus this CL will have no effect on today's production. The goal of CL is to pave the way to avoid this duplication. For starters, one could start real writing tests with + api.buildbucket.ci_build(..., revision='sha1') without the need to duplicate the same revision as a property. All recipes which WAI with such input are thus ready to work w/o 'revision' property. After that, we'll be able to stop the duplication in LUCI scheduler. R=hinoka Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Change-Id: I1773b1c3d2a98a9dbd1cfdd9ac2b4fb99745ee99 Reviewed-on: https://chromium-review.googlesource.com/1123713 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:Ryan Tseng <hinoka@chromium.org>
-
Andrii Shyshkalov authored
Change-Id: Ie95e10784725176c94a584fa6dadef2318142053 Reviewed-on: https://chromium-review.googlesource.com/1123650Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Edward Lemur authored
gclient setdep used to assume that the version of a CIPD package was always of the form 'version:<something>'. However, the following are all valid: * SHA1 hashes that specify a single instance * tags (tagname:tagvalue) * References (e.g. 'latest') that are dynamically resolved by the CIPD server. This change adds support for all of them: * GetCIPD simply returns whatever the 'version' entry is, without assuming it begins with 'version:'. * SetCIPD sets 'version' ta whatever it is passed, without prepending 'version:' at the beginning. Bug: 858978 Change-Id: I53669c5df7fb51cde42e0af271139b5719a47622 Reviewed-on: https://chromium-review.googlesource.com/1120943Reviewed-by:Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/782ed0377a0a23f393a3a873194954825972b961 buildbucket recipe_module: accept typical git_repo URLs, too. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic13c85b02d8271d22223ecd9c88e306d46445523 Reviewed-on: https://chromium-review.googlesource.com/1123626 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/af0fe7159155bbbf93ae62322b78291ea2131a60 Fix nits in buildbucket recipe module. (tandrii@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib16763954eb8b264bce93cdf18eb4e77303f4e98 Reviewed-on: https://chromium-review.googlesource.com/1123623 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
- 02 Jul, 2018 4 commits
-
-
Deepanjan Roy authored
Adds '.ts' to list of extensions to be handled by clang-format. Change-Id: Ia00e59ba3ab617ebf248cfcf6df07dd98cdc14ce Reviewed-on: https://chromium-review.googlesource.com/1120325Reviewed-by:
-
Sergiy Byelozyorov authored
It is not possible to use cwd argument, since none of the methods called by this module define cwd explicitly and low-level modules like api.step do not support it anymore, resulting in a TypeError exception thrown due to unexpected keyword argument, e.g. see https://ci.chromium.org/swarming/task/3e74a52905a71110. Given that any users using cwd argument would be broken anyway, it should be safe to make this change. Planned usage: https://crrev.com/c/1122874 R=tandrii@chromium.org, iannucci@chromium.org Bug: 793687 Change-Id: Iadf6bf91d8d41dbc6751a848bb69d7922a206ade Reviewed-on: https://chromium-review.googlesource.com/1122873Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/57600791c9ce0381bffff5b8d5ffef235c661a09 Remove bogus test file. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie3173cf9044b45b1570b5283ff52d04c61d83d95 Reviewed-on: https://chromium-review.googlesource.com/1122699 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Follow up on https://crrev.com/c/1113036/2/my_activity.py#752 R=sergiyb@chromium.org Change-Id: I56e4936f2f2bc94a734aeb510594ee8384d6e2a9 Reviewed-on: https://chromium-review.googlesource.com/1121816Reviewed-by:
-
- 29 Jun, 2018 6 commits
-
-
Andrii Shyshkalov authored
R=sergiyb Change-Id: I020580302db491e4f355000daf901223b99d91e3 Reviewed-on: https://chromium-review.googlesource.com/1113036Reviewed-by:
-
Andrii Shyshkalov authored
R=sergiyb Change-Id: I97b117576f73ceb98435eda3158e22c31a5e851e Reviewed-on: https://chromium-review.googlesource.com/1113035Reviewed-by:
-
Robert Iannucci authored
R=phosek@chromium.org, tandrii@chromium.org, vadimsh@chromium.org Bug: 790650 Change-Id: Ia878004d6983dbbad882ec683da2e0db5e727c66 Reviewed-on: https://chromium-review.googlesource.com/1116073 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This is neccessary to ensure that generated ninja commands invoke python from PATH instead of the one from VPython's VirtualEnv. On LUCI builders that replace system python with VPython using vpython:native-python-wrapper swarming tag, a new VPython VirtualEnv bubble will be created for each script and contain that script's individual dependencies. Based on https://cs.chromium.org/chromium/infra/recipes-py/recipes.py?l=88&rcl=66d9d8c66f10ca37dffa4b6d374c3d802a061b01. R=iannucci@chromium.org Bug: 793687 Change-Id: I633d2e0dfeda0097072daba102fb013656aaafa2 Reviewed-on: https://chromium-review.googlesource.com/1120817 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Robert Iannucci authored
This CL makes a couple changes: * The goal here is to be able to specify git cache entirely from the environment variable $GIT_CACHE_PATH and not require special treatment from bot_update. Eventually this will be specified at the swarming task level instead of in the recipe (i.e. "cached git" will eventually be an implementation detail of git on the bots and completely transparent to all other software). * Removal of the general --cache-dir option from gclient. This option was error-prone; it doesn't actually make sense to configure this on a per-invocation basis. The sole exception was `gclient config`, which now allows this option to be set directly. * Consolidation of GitWrapper.cache_dir and GitWrapper._GetMirror; previously these two things could disagree, leading to weird intermediate states. Now they're the same value. R=agable@chromium.org, ehmaldonado@chromium.org, tandrii@chromium.org Bug: 823434 Change-Id: I14adc7619b5fc10768ce32be2651c6215ba94aff Reviewed-on: https://chromium-review.googlesource.com/1105473Reviewed-by: -
Yoshisato Yanagisawa authored
Let me make them exported via InputAPI to be used by our repo. Change-Id: I1a0c7f49ab5a3c00b2617062444d67bbb9600837 Reviewed-on: https://chromium-review.googlesource.com/1117958 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 28 Jun, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/66d9d8c66f10ca37dffa4b6d374c3d802a061b01 Update the user guide to refer to the correct script. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8766783fafc1c67d046587fcbbcc644bc57c6d1f Reviewed-on: https://chromium-review.googlesource.com/1119405 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
R=iannucci@chromium.org, tandrii@chromium.org BUG=801423 Change-Id: I28331e8b6210cbd972cc687fa71a234e75da4b95 Reviewed-on: https://chromium-review.googlesource.com/1119374Reviewed-by:
-
John Budorick authored
crrev.com/c/1097623 broke the official bots because the cipd variable escaping present in the normal DEPS file wasn't present in the flattened DEPS file. Change-Id: Iaae8b95a9d8c5ce0ed80071169e731a24e98b4c4 Reviewed-on: https://chromium-review.googlesource.com/1112935 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5c0c63e50c92e7a1a5fd81b3283f03b096abe667 Add stats and safemode to archive module. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia8af13b0f9785237d425810b8a884755cef8a255 Reviewed-on: https://chromium-review.googlesource.com/1118863Reviewed-by:
-
Edward Lemur authored
It causes flakiness, since the package that is responsible for printing the dependency is not always the same. Bug: None Change-Id: I887d740d6a903cb0d5e6c080b76feab78a54effd Reviewed-on: https://chromium-review.googlesource.com/1116191Reviewed-by:
-
- 27 Jun, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/82e233fa4e6fed0a5dd99501e0d52d3dce25c994 [cipd] Make the argument to ensure a class (phosek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9d98ce4b9ab792409ccade93df1fbcfc6056679e Reviewed-on: https://chromium-review.googlesource.com/1117329Reviewed-by:
-
- 26 Jun, 2018 5 commits
-
-
Scott Graham authored
Bug: 855791 Change-Id: I964df1a781da4335e9b77192faf7913d3546de13 Reviewed-on: https://chromium-review.googlesource.com/1112817Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b1546529ec629fa8ddf804916c94b6e06c44d693 Add simple `archive` module for tar + zip. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4a8a4f1269b9d791b87ffb720796b1d33e7cd5ae Reviewed-on: https://chromium-review.googlesource.com/1115784 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Edward Lemur authored
Report the dependencies that were not synced, due to their, or their parent's condition evaluating to False. Bug: 853010 Change-Id: I375703a1b91e3c3e31e444b0df1c95ecae17b6ba Reviewed-on: https://chromium-review.googlesource.com/1111113Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
2018-06-26 vadimsh [cipd] Do not barf on -pkg-var when using -in. 2018-06-26 vadimsh [cipd] Fix and improve output of ensure-file-verify. 2018-06-26 vadimsh [cipd] Fix hanging in 'ensure-file-verify' if the ensure file is broken. R=iannucci@chromium.org, tandrii@chromium.org BUG=801423 Change-Id: Ic48753e30f2412f214ebfb73bb7693e5834cdbf7 Reviewed-on: https://chromium-review.googlesource.com/1115464Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e autoroller: Search for gitattributes files only in modified dirs. (ehmaldonado@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6e6cde4f438eb189a6bd8f8623691e2c445d2a78 Reviewed-on: https://chromium-review.googlesource.com/1114263Reviewed-by:
-
- 25 Jun, 2018 2 commits
-
-
Vadim Shtayura authored
New versions understand CIPD_PROTOCOL=v2. R=tandrii@chromium.org BUG=801423 Change-Id: I6ca28638393957a9965a0ded7ed49c15b3a8f5b0 Reviewed-on: https://chromium-review.googlesource.com/1114296Reviewed-by:
-
Andrii Shyshkalov authored
Originally-Reviewed-on: https://chromium-review.googlesource.com/1111107 Led-test: https://ci.chromium.org/swarming/task/3e51ed0e31211710?server=chromium-swarm.appspot.com TBR=hinoka, iannucci Bug: 855137 Change-Id: I157ef6b9ee2a7ce45e4a474853ae769a82cc4c99 Reviewed-on: https://chromium-review.googlesource.com/1114234 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
- 23 Jun, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6cf964d26783026b01cdcdf8c40b30e9fb0c845d [cipd] Add support for acl-check command (phosek@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I929fca321284426c8c96ef7a1ceb00ac1ef857a2 Reviewed-on: https://chromium-review.googlesource.com/1112801 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
- 22 Jun, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/09ac15a0e9da9cf8f2c22320968f21544a0b25f0 gitattr_checker: Add tests for the cache. (ehmaldonado@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3f9902a2a8c781124f6c84f945fb2e298ca936fa Reviewed-on: https://chromium-review.googlesource.com/1112474Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit c48318a3. Reason for revert: likely broke ChromeOS Original change's description: > bot_update: Don't force solutions to be unmanaged. > > gclient should be the one syncing the solutions to the appropriate > revisions. > > Bug: 850812, 853032 > Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29 > Reviewed-on: https://chromium-review.googlesource.com/1102833 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=hinoka@chromium.org,agable@chromium.org,ehmaldonado@chromium.org Change-Id: I7e110108a9687d703ea8be39cc83e0888f7813c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850812, 853032, 855700 Reviewed-on: https://chromium-review.googlesource.com/1111925Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 568b7a89. Reason for revert: temporary revert to revert previous CL. Original change's description: > Wipe out shallow checkout support from bot_update. > > Bug: 855137 > Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c > Reviewed-on: https://chromium-review.googlesource.com/1111107 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,tandrii@chromium.org Change-Id: Iede67717be448be9bdd7c5dd4895fbab9fd65c66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855137, 855700 Reviewed-on: https://chromium-review.googlesource.com/1111924Reviewed-by:
-
Andrii Shyshkalov authored
Bug: 855137 Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c Reviewed-on: https://chromium-review.googlesource.com/1111107 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Edward Lemur authored
gclient should be the one syncing the solutions to the appropriate revisions. Bug: 850812, 853032 Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29 Reviewed-on: https://chromium-review.googlesource.com/1102833Reviewed-by:
-
Henrique Ferreiro authored
Renames DEPOT_TOOLS_WIN_TOOLCHAIN_HTTP_BASE_URL to DEPOT_TOOLS_WIN_TOOLCHAIN_BASE_LOCATION. This environment variable can now point to a local directory where the Windows SDK zip file is stored. This allows non-Googlers to cross-compile Chromium for Windows. Bug: 852347 Change-Id: I00650e84247f35b4b8cfba204e0f2afd0882b69b Reviewed-on: https://chromium-review.googlesource.com/1098256 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org>
-
Sergiy Byelozyorov authored
This reverts commit f7e1e10d. Reason for revert: breaks V8 presubmit, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_presubmit/b8943030202460843984 Original change's description: > cpplint: Pull in upstream changes > > The changes include: > - root flag now can process non-subdirectories > -- https://github.com/google/styleguide/commit/e7ddd2af622475b0c5e0f587d69fb061d2c10c46 > > - root flag can be configured with CPPLINT.cfg > -- https://github.com/google/styleguide/commit/2322e4ffaa19f4c55e5679102318ce67454fb7ed > > - root setting is relative to the CPPLINT.cfg file > -- https://github.com/google/styleguide/commit/8a87a46cc7f8d6cca5c0203ddba5d81149db7695 > > - Cleans up header file detection for hpp and hxx > > - Adds quite mode > > Bug: 852898 > > Change-Id: Id44bbfadc913cc27192049ab9a222f22d0deab5d > Reviewed-on: https://chromium-review.googlesource.com/1108381 > Commit-Queue: Amin Hassani <ahassani@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,ahassani@chromium.org Change-Id: I3d380ecf8cb80000d7f7dcc0a2c75bb8a12d2a51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852898 Reviewed-on: https://chromium-review.googlesource.com/1111797Reviewed-by:
-
- 21 Jun, 2018 1 commit
-
-
Michael Moss authored
BUG=crbug.com/854886,b/110032771 R=tandrii@google.com Change-Id: Iabd67f8042ab3bc7c6ef15101effeeebf39d4500 Reviewed-on: https://chromium-review.googlesource.com/1111007Reviewed-by:
-
