bot_update: remove legacy Gerrit patch property support.

Change-Id: Ie95e10784725176c94a584fa6dadef2318142053
Reviewed-on: https://chromium-review.googlesource.com/1123650Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

recipes/recipe_modules/bot_update/__init__.py

@@ -26,10 +26,6 @@ PROPERTIES = {
   'patch_repository_url': Property(default=None),
   'patch_ref': Property(default=None),
 
-  # TODO(tAndrii): remove legacy Gerrit fields.
-  # Legacy Gerrit fields.
-  'event.patchSet.ref': Property(default=None, param_name='gerrit_ref'),
-
   # Rietveld-only (?) fields.
   'repository': Property(default=None),
 

recipes/recipe_modules/bot_update/api.py

@@ -10,7 +10,7 @@ from recipe_engine import recipe_api
 class BotUpdateApi(recipe_api.RecipeApi):
 
   def __init__(self, properties, patch_issue, patch_set,
-               repository, patch_repository_url, gerrit_ref, patch_ref,
+               repository, patch_repository_url, patch_ref,
                patch_gerrit_url, revision, parent_got_revision,
                deps_revision_overrides, fail_patch, *args, **kwargs):
     self._apply_patch_on_gclient = properties.get(
@@ -18,7 +18,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
     self._issue = patch_issue
     self._patchset = patch_set
     self._repository = repository or patch_repository_url
-    self._gerrit_ref = gerrit_ref or patch_ref
+    self._gerrit_ref = patch_ref
     self._gerrit = patch_gerrit_url
     self._revision = revision
     self._parent_got_revision = parent_got_revision

recipes/recipe_modules/bot_update/examples/full.py

@@ -225,20 +225,6 @@ def GenTests(api):
       'gerrit get_patch_destination_branch',
       api.gerrit.get_one_change_response_data(branch='refs/branch-heads/67'),
   )
-  yield api.test('tryjob_gerrit_angle_deprecated') + api.properties.tryserver(
-      patch_project='angle/angle',
-      gerrit='https://chromium-review.googlesource.com',
-      patch_storage='gerrit',
-      repository='https://chromium.googlesource.com/angle/angle',
-      rietveld=None,
-      **{
-        'event.change.id': 'angle%2Fangle~master~Ideadbeaf',
-        'event.change.number': 338811,
-        'event.change.url':
-          'https://chromium-review.googlesource.com/#/c/338811',
-        'event.patchSet.ref': 'refs/changes/11/338811/3',
-      }
-  )
   yield api.test('tryjob_gerrit_webrtc') + api.properties.tryserver(
       gerrit_project='src',
       git_url='https://webrtc.googlesource.com/src',