Commits · 8d4c15c3baca8e4bb55ffce172c7cf77f1d408e4 · Linshizhi / Chromium_Depot_tools

08 Jan, 2010 7 commits

Change to a git repo before checking git-svn version · 8d4c15c3

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
R=maruel

Patch contributed by Nasser <nasser@codeaurora>

Review URL: http://codereview.chromium.org/530001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35817 0039d316-1c4b-4281-b951-d872f2087c98

8d4c15c3

Catch ValueErrors when trying to convert the CL issue number in git presubmit hooks · 0dfc4ef2

rsesek@chromium.org authored Jan 08, 2010

BUG=31695
TEST=none
Review URL: http://codereview.chromium.org/528004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35816 0039d316-1c4b-4281-b951-d872f2087c98

0dfc4ef2

Abort gclient sync when a svn command fails. · 54d1f1ae

maruel@chromium.org authored Jan 08, 2010

TEST=a svn locked directory will stop a gclient sync
BUG=none

Review URL: http://codereview.chromium.org/529002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35815 0039d316-1c4b-4281-b951-d872f2087c98

54d1f1ae

Using the root codereview.settings seems to be a problem for NACL · 4970aa2b

bradnelson@google.com authored Jan 08, 2010

(there isn't one in their repo).
They've been manually specifying --host etc for over a week.

Why the change in behavior?

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/528003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35814 0039d316-1c4b-4281-b951-d872f2087c98

4970aa2b

git svn --version doesn't work when called outside a git checkout. · 8dd7cc5c

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
TBR=nasser

Review URL: http://codereview.chromium.org/523166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35800 0039d316-1c4b-4281-b951-d872f2087c98

8dd7cc5c

Fix unit tests (mostly esthetical) · 40f35c32

maruel@chromium.org authored Jan 08, 2010

TEST=none
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/517068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35767 0039d316-1c4b-4281-b951-d872f2087c98

40f35c32

Check for the existence of git before running commands. · f3909bf2

maruel@chromium.org authored Jan 08, 2010

Checks in the gclient wrapper and when running any gclient git command.

TEST=none
BUG=none

Patch contributed by Nasser <nasser@codeaurora>

Review URL: http://codereview.chromium.org/518064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35762 0039d316-1c4b-4281-b951-d872f2087c98

f3909bf2

07 Jan, 2010 5 commits

Fixed wrong argument placement. · 0c401696

maruel@chromium.org authored Jan 07, 2010

TEST=none
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/519073

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35688 0039d316-1c4b-4281-b951-d872f2087c98

0c401696

Style fix. · ce3c8621

maruel@chromium.org authored Jan 07, 2010

TEST=none
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35685 0039d316-1c4b-4281-b951-d872f2087c98

ce3c8621

Add "diff against" support when sending try patches. · 1c7db8e6

maruel@chromium.org authored Jan 07, 2010

This is mostly useful with git when diffing against arbitrary branches.

Review URL: http://codereview.chromium.org/524046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35684 0039d316-1c4b-4281-b951-d872f2087c98

1c7db8e6

Fix checkout root detection for git. · 01d8c1d1

maruel@chromium.org authored Jan 07, 2010

Add shorthand parameters.

Stop changing the logging level in gcl and some logging changes.

Change SCM.GetCheckoutRoot() to SCM.checkout_root.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/523094

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35683 0039d316-1c4b-4281-b951-d872f2087c98

01d8c1d1

When running git presubmit hooks, use the changelist's description, · 4c098c85

rsesek@chromium.org authored Jan 07, 2010

rather than the local commit message's.

BUG=31695
TEST=git cl upload where commit message is missing BUG= but CL description has one. No presubmit error.
Review URL: http://codereview.chromium.org/523101

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35682 0039d316-1c4b-4281-b951-d872f2087c98

4c098c85

06 Jan, 2010 1 commit

Reduce log level to sanity. · a6220d1b

maruel@chromium.org authored Jan 06, 2010

TEST=use -v -v
BUG=none

Review URL: http://codereview.chromium.org/523099

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35648 0039d316-1c4b-4281-b951-d872f2087c98

a6220d1b

26 Dec, 2009 1 commit

Add back automatic fallback to svn access when http access fails. · b6d36495

maruel@chromium.org authored Dec 26, 2009

It was somehow ripped out by accident.

TEST=none
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/515037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35284 0039d316-1c4b-4281-b951-d872f2087c98

b6d36495

23 Dec, 2009 2 commits

Rips the guts out of git-try since trychange.py is now supper awesome. · e2b865ce

maruel@chromium.org authored Dec 23, 2009

TEST=try me (none)
BUG=none
TBR=brad

Review URL: http://codereview.chromium.org/516007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35219 0039d316-1c4b-4281-b951-d872f2087c98

e2b865ce

After much refactory, finally add significant functionalities to trychanges.py · d9141bff

maruel@chromium.org authored Dec 23, 2009

Add real logging support.
Fix the patch path mungling that was broken earlier.
Add and proper refactor automatic gclient and gcl settings detection.
Factored so it is possible to add other autodetection algorithms.
Now works standalone in hybrid svn&git checkouts within a gclient meta-checkout.

TEST=bah
BUG=none
TBR=bradnelson

Review URL: http://codereview.chromium.org/517005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35218 0039d316-1c4b-4281-b951-d872f2087c98

d9141bff

22 Dec, 2009 10 commits

Add gclient_scm.GitWrapper.pack() · ee4071d4

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507070

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35177 0039d316-1c4b-4281-b951-d872f2087c98

ee4071d4

Add --sup_rep support to trychange.py. · f7ae6d55

maruel@chromium.org authored Dec 22, 2009

This adds the functionality to try a job spread across multiple checkouts.

TEST=fixed unit tests and tested with hybrid svn-git checkouts
BUG=none

Review URL: http://codereview.chromium.org/504085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35168 0039d316-1c4b-4281-b951-d872f2087c98

f7ae6d55

Factor out PathDifference into gclient_utils for a later reuse. · 3ccbf7e6

maruel@chromium.org authored Dec 22, 2009

Make lack of email address an error.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35167 0039d316-1c4b-4281-b951-d872f2087c98

3ccbf7e6

Prints errors on http protocol · 6f6a801e

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/507071

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35156 0039d316-1c4b-4281-b951-d872f2087c98

6f6a801e

Fix a typo in scm.GIT.GetBranch() and add --dry_run to trychange.py to ease testing. · c308a744

maruel@chromium.org authored Dec 22, 2009

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/503085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35155 0039d316-1c4b-4281-b951-d872f2087c98

c308a744

Add full_move flag to GIT.GenerateDiff and Factor out FindGclientRootDir into gclient_utils. · a9371767

maruel@chromium.org authored Dec 22, 2009

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/501171

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35154 0039d316-1c4b-4281-b951-d872f2087c98

a9371767

Small cleanups in trychange.py · 650bb1f9

maruel@chromium.org authored Dec 22, 2009

Review URL: http://codereview.chromium.org/509020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35145 0039d316-1c4b-4281-b951-d872f2087c98

650bb1f9

Remove more logic out of trychange.py into scm.py. · b24a8e1a

maruel@chromium.org authored Dec 22, 2009

The goal is to (almost) completely remove git-try.

TEST=none

Review URL: http://codereview.chromium.org/501166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35144 0039d316-1c4b-4281-b951-d872f2087c98

b24a8e1a

Simplify call site. · 1227c7de

maruel@chromium.org authored Dec 22, 2009

Do a review comment I forgot to apply in a previous change.

TEST=none

Review URL: http://codereview.chromium.org/508012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35124 0039d316-1c4b-4281-b951-d872f2087c98

1227c7de

Move GenerateDiff into a common function. · f2f9d554

maruel@chromium.org authored Dec 22, 2009

Fix standalone trychange usage on both svn and git.
Remove implicit dependency on git-cl.

TEST=unit test

Review URL: http://codereview.chromium.org/507061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35121 0039d316-1c4b-4281-b951-d872f2087c98

f2f9d554

20 Dec, 2009 2 commits

Make breakpad, gcl and presubmit_support dependencies optional · ea8c1a9b

maruel@chromium.org authored Dec 20, 2009

TEST=unit tests

Review URL: http://codereview.chromium.org/503068

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35072 0039d316-1c4b-4281-b951-d872f2087c98

ea8c1a9b

Remove gclient-specific hacks from trychange into gcl. · 18111359

maruel@chromium.org authored Dec 20, 2009

Remove upload dependency.

This is towards making trychange.py work mostly standalone for the webkit try server.

TEST=unit tests and tested both gcl try and git-try.

Review URL: http://codereview.chromium.org/501143

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35071 0039d316-1c4b-4281-b951-d872f2087c98

18111359

19 Dec, 2009 2 commits

Factor out gcl.GetRepositoryRoot() into scm.SVN.GetCheckoutRoot() · 94b1ee9d

maruel@chromium.org authored Dec 19, 2009

This is to reduce trychange.py dependency on gcl.py

Review URL: http://codereview.chromium.org/502085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35055 0039d316-1c4b-4281-b951-d872f2087c98

94b1ee9d

Remove trychange.RunCommand and replace it by gclient_utils.CheckCall. · 9a2f37ea

maruel@chromium.org authored Dec 19, 2009

TEST=unit tests

Review URL: http://codereview.chromium.org/502078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35052 0039d316-1c4b-4281-b951-d872f2087c98

9a2f37ea

18 Dec, 2009 5 commits

Fix the author search for branches (only an issue on reverts), looking at... · 461843e2

laforge@chromium.org authored Dec 18, 2009

Fix the author search for branches (only an issue on reverts), looking at trunk w/ the revision won't tell you
the correct author.
Review URL: http://codereview.chromium.org/505053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35009 0039d316-1c4b-4281-b951-d872f2087c98

461843e2

One liner fix. · 2185f006

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/502075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34984 0039d316-1c4b-4281-b951-d872f2087c98

2185f006

Get rid of gcl.ReadFile. · 0fca4f37

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/501106

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34950 0039d316-1c4b-4281-b951-d872f2087c98

0fca4f37

Remove gcl.WriteFile · fc83c11b

maruel@chromium.org authored Dec 18, 2009

Review URL: http://codereview.chromium.org/502066

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34949 0039d316-1c4b-4281-b951-d872f2087c98

fc83c11b

Fix a character encoding issue · f5a1163b

laforge@chromium.org authored Dec 18, 2009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34897 0039d316-1c4b-4281-b951-d872f2087c98

f5a1163b

17 Dec, 2009 2 commits

Add eol ignore logic to make webkit merges less problematic. · ee98c9fd

laforge@chromium.org authored Dec 17, 2009

Review URL: http://codereview.chromium.org/505042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34895 0039d316-1c4b-4281-b951-d872f2087c98

ee98c9fd

Add a minimum SVN version check to drover, to enforce the 1.5.x requirement. · 004d2efe

laforge@chromium.org authored Dec 17, 2009

Review URL: http://codereview.chromium.org/501081

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34894 0039d316-1c4b-4281-b951-d872f2087c98

004d2efe

15 Dec, 2009 1 commit

gclient: implement a less hacky relative URL implementation · c532e17e

msb@chromium.org authored Dec 15, 2009

Doing something like basename when concatenating base_url with
relative url.

Added use_relative_urls2 to enable switching between old
implementation and new implementation. Once the old implementation
is deprecated we can remove the use_relative_urls2.

Review URL: http://codereview.chromium.org/500015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34563 0039d316-1c4b-4281-b951-d872f2087c98

c532e17e

14 Dec, 2009 2 commits

--replace-all so we don't accum variables · 4c317183

jrg@chromium.org authored Dec 14, 2009

Review URL: http://codereview.chromium.org/504002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34500 0039d316-1c4b-4281-b951-d872f2087c98

4c317183

gclient: Add better error reporting and handling when there is a rebase conflict · 5bde4853

msb@chromium.org authored Dec 14, 2009

When a rebase generates a conflict, report an error and exit immediately.
If in an existing conflict (no branch), report an error and exit immediately.

Review URL: http://codereview.chromium.org/496003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34459 0039d316-1c4b-4281-b951-d872f2087c98

5bde4853