Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 17 Apr, 2017 1 commit
  3. 14 Apr, 2017 1 commit
    • Dave Schuyler's avatar
      [presub] lstrip line limit exceptions; ignore <g and <path · 9b9b94c4
      Dave Schuyler authored 
      Previously, the <link lines in HTML are allowed to have longer than 80 characters.
This CL adds <g and <path to the HTML lines that may have unlimited characters.
(These g and path tags are used in svg image data).
These HTML exemptions also have a trailing space. The space is intended to reduce
false-positives in matching. There are some occurrences of these tags followed by a 
\n which will not match (but the line ends there, so it's not an issue).

These new tags may be preceded by blank space so .lstrip() was added to
the test. I believe this .lstrip() should not be an issue for the other
languages and exemptions present.

Bug: None
Change-Id: Ie9c2bca0e7147033e360ddcfc6eee3b73e167228
Reviewed-on: https://chromium-review.googlesource.com/477371Reviewed-by: 's avatarMarc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
      9b9b94c4
  5. 10 Apr, 2017 1 commit
  7. 29 Mar, 2017 1 commit
  9. 06 Mar, 2017 1 commit
  11. 24 Jan, 2017 2 commits
  13. 16 Jan, 2017 1 commit
  15. 07 Jan, 2017 1 commit
    • Wez's avatar
      Fix OWNERS canned check to avoid duplicate output. · 66c50ea1
      Wez authored 
      1. Update PanProjectChecks() to supply source_filter to CheckOwners().
   This prevents files under e.g. third_party/WebKit being checked both
   by the top-level and sub-directory PRESUBMIT rules.
2. Fix CheckOwners() to list missing-OWNERS only for the sub-directory
   it is invoked on, rather than the whole CL. This prevents files under
   sub-directories with their own PRESUBMIT rule, within the same repo,
   from causing OWNERS to be checked for files outside that directory.

BUG=

Change-Id: I9bd5677a69efe9c78b4174a917780d6688991a38
Reviewed-on: https://chromium-review.googlesource.com/426003
Commit-Queue: James Weatherall <wez@chromium.org>
Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
      66c50ea1
  17. 16 Dec, 2016 1 commit
  19. 05 Dec, 2016 1 commit
  21. 22 Nov, 2016 1 commit
  23. 29 Aug, 2016 1 commit
  25. 24 Aug, 2016 1 commit
  27. 05 Aug, 2016 1 commit
    • brettw's avatar
      Update "git cl format" for GN changes. · 4b8ed59b
      brettw authored 
      "gn format" changed to remove the --in-place argument. This updates the
instructions for formatting and fixes existing usage.

git cl format --diff never worked, it just printed the full formatted output
unconditionally. This change improves things slightly by indicating there's a
diff for a file. A proper diff can be hooked up in a later stage if somebody
so desires.

Review-Url: https://codereview.chromium.org/2220123002
      4b8ed59b
  29. 17 Jun, 2016 1 commit
  31. 07 Jun, 2016 1 commit
  33. 09 May, 2016 1 commit
  35. 29 Apr, 2016 5 commits
  37. 28 Apr, 2016 2 commits
  39. 27 Apr, 2016 1 commit
  41. 27 Jan, 2016 1 commit
  43. 25 Jan, 2016 1 commit
  45. 11 Jan, 2016 2 commits
  47. 01 Dec, 2015 1 commit
  49. 23 Nov, 2015 1 commit
  51. 16 Nov, 2015 2 commits
  53. 08 Oct, 2015 1 commit
  55. 16 Jul, 2015 1 commit
  57. 01 Jul, 2015 1 commit
    • iannucci@chromium.org's avatar
      Changes to improve multiprocessing PRESUBMIT support in Windows · d61a4950
      iannucci@chromium.org authored 
        * make RunTest's multiprocessing.Pool in the constructor of InputApi
    to avoid getting tripped up by chdir manipulation.
  * Don't do the split cyclic-import check when the invoker of the
    Pylint presubmit checks explicitly sends cyclic import check
    parameters via extra_args
  * fix pseudobug where ownership of the files variable was unclear,
    and pass all arguments on stdin (instead of mix of CLI + stdin).
  * fix bug in pylint which caused it to manipulate sys.path before
    spawning its subprocesses, which caused multiprocessing to fail
    on windows.
    * Note: This may carry a slight semantic change. Before, pylint would
      add all .py files' directories to sys.path while checking any of
      them. Now in parallel mode, pylint will only add the path of the
      single file to sys.path. This behavior actually mirrors Python's
      own behavior, so the check should be more-correct than before (and
      should cut down on pylint import scanning time with very large
      sys.path's).
    * If someone encounters an issue with this, please note that the
      GetPylint check also includes an extra_paths_list which is
      expressly for this purpose.

R=dpranke@chromium.org, kbr@chromium.org, maruel@chromium.org
BUG=501012

Review URL: https://codereview.chromium.org/1208743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295908 0039d316-1c4b-4281-b951-d872f2087c98
      d61a4950
  59. 12 Jun, 2015 1 commit
  61. 21 Apr, 2015 1 commit
  63. 16 Apr, 2015 1 commit