- 17 May, 2013 1 commit
-
-
maruel@chromium.org authored
TBR=joi@chromium.org BUG= Review URL: https://codereview.chromium.org/14972010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2013 1 commit
-
-
ilevy@chromium.org authored
Enable parallel tests on depot_tools. On Z620 presubmit times: 3m -> 35s. Review URL: https://codereview.chromium.org/14247012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@195377 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Mar, 2013 1 commit
-
-
ilevy@chromium.org authored
This suite is very slow (26s), while the rest of the test suites are fast.. Since subprocess2 is a relatively static module, blacklist the suite for upload. Review URL: https://chromiumcodereview.appspot.com/12544027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@188657 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2012 1 commit
-
-
maruel@chromium.org authored
Update pylintrc to be near the pylint 0.25.1 default file. R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10199016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@133707 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Mar, 2012 1 commit
-
-
maruel@chromium.org authored
Remove the stale presubmit warning. TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9655005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@125696 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Feb, 2012 1 commit
-
-
chrisha@chromium.org authored
This CL introduces package_management.py, a module for managing third-party Python packages in a site directory within depot_tools. A future CL will integrate this with depot_tools, causing the packages to be downloaded and installed on first run after that CL lands. Once in place presubmit_canned_checks will be extended to make use of the locally installed version of pylint. BUG= TEST= Review URL: http://codereview.chromium.org/8965033 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@120225 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2011 1 commit
-
-
maruel@chromium.org authored
It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'. Reenable W0403 that was disabled in the previous CL. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
Add a warning when RunUnitTestsInDirectory() finds no test to run to catch this kind of regression. Fix all the regressions that where introduced in the meantime... TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7906009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
stderr is not redirected by default. stdout is not allowed. Both were oversight. Do not override stdin=None in case the user would response to stderr output for example. Increase test coverage. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7860041 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Sep, 2011 1 commit
-
-
asvitkine@chromium.org authored
Needed for: http://codereview.chromium.org/7834045/ BUG=none TEST=Check that cpplint_chromium.py does not trigger presubmit warnings. Review URL: http://codereview.chromium.org/7789033 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100025 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Sep, 2011 1 commit
-
-
maruel@chromium.org authored
gclient_scm_test.py throws randomly gclient_utils.Error. Simply update the test expectation. It has no effect on runtime. BUG= TEST= Review URL: http://codereview.chromium.org/7828024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99436 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jun, 2011 1 commit
-
-
maruel@chromium.org authored
R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7172014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@89208 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Add propagation of verbose flag from git cl to presubmit_support Rename NotImplementedException to standard NotImplementError. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6810012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80798 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Also fix a few issues found along the way. Tests had regressed a lot. Add a lot of tweaks to make most test pass. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792060 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Fix execution on windows. Remove more code. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6792054 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80617 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6791018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80212 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Not changed git-cl integration tests because they assume the current directory is ./tests/ R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6690046 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80156 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Remove git_cl_hooks.py since it's now unnecessary. BUG= TEST= Review URL: http://codereview.chromium.org/6758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79715 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Reapply r79006 with fixes for ubuntu 10.4. The only change is in fix_default_encoding() to trap an exception locale.getlocale() may throw. R=dpranke@chromium.org BUG=none TEST=unit test Review URL: http://codereview.chromium.org/6721029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79144 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Mar, 2011 2 commits
-
-
maruel@chromium.org authored
It is causing exception for some users on ubuntu 10.4 with: "category LC_ALL is not supported" TBR=dpranke Review URL: http://codereview.chromium.org/6717025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79012 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
With this code in action, I can successfully print arabic and chinese on linux and cygwin. It fails to print chinese on my Mac but prints arabic. It prints '?' on Windows console but it *doesn't throw* which is the biggest improvement here. It was particularly a problem on windows because WindowsError's description text is in the current ANSI code page so it failed to print if the text was not pure ASCII, like error message when using Windows' French UI. R=dpranke@chromium.org BUG=none TEST=manual unit test ./tests/fix_encoding_test.py and it shouldn't throw Review URL: http://codereview.chromium.org/6676090 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79006 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Mar, 2011 1 commit
-
-
dpranke@chromium.org authored
pass pylint cleanly. There should be no functional changes in this patch, although there's at least one minor bug that lint caught. Review URL: http://codereview.chromium.org/6685023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78638 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Mar, 2011 1 commit
-
-
dpranke@chromium.org authored
R=chase@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6676058 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78632 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2011 1 commit
-
-
dpranke@chromium.org authored
This change requires us to change the previous signature for the CheckOwners() hook to provide the server address and email regexp to use for parsing approvals from Rietveld. Review URL: http://codereview.chromium.org/6657028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77891 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Mar, 2011 2 commits
-
-
dpranke@chromium.org authored
Also, this properly wires up the presubmit code to the owners code and adds unit tests. Review URL: http://codereview.chromium.org/6623074 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77523 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
Review URL: http://codereview.chromium.org/6651009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77518 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jan, 2011 1 commit
-
-
maruel@chromium.org authored
Add logging to presubmit_support.py. BUG= TEST= Review URL: http://codereview.chromium.org/6004006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70378 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Dec, 2010 1 commit
-
-
chase@chromium.org authored
Also update the PRESUBMIT check to exclude git_cl/. BUG=none TEST=git-cl hooks run TBR=maruel@chromium.org Review URL: http://codereview.chromium.org/5998008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70108 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Change RunPylint to parse all .py files when one is modified. Make all depot_tools/tests pass on pylint. That mostly meant fixing some builtins aliasing, wrong alignment and turning off most remaining warnings. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/5695007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Dec, 2010 1 commit
-
-
maruel@chromium.org authored
Adding it as I figured out how to make it run correctly on ubuntu 10.4 and it's used in enough places it warrants a canned check. BUG=none TEST=it self tests itself. Review URL: http://codereview.chromium.org/5682011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69051 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Nov, 2010 2 commits
-
-
maruel@chromium.org authored
This causes some code clutter. TEST=Increased pylint warning level BUG=none Review URL: http://codereview.chromium.org/4321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=presubmit.py BUG=none Review URL: http://codereview.chromium.org/4279002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64903 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
The class WindowsError is only a builtin on Windows. Use OSError instead. Also make the exception more comprehensible on the other platforms when pylint is not installed. TEST=none BUG=none Review URL: http://codereview.chromium.org/3331022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59253 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Sep, 2010 2 commits
-
-
maruel@chromium.org authored
For now that involves disabling a lot of tests when they can't be run. I'm unsure about the ascii encoding, it fails here if I keep this call on a French UI. TEST=none BUG=none Review URL: http://codereview.chromium.org/3333028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59137 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This tool has been quite useful noticing errors in the past and I'd have avoided a breakage in r58936 if I had run it. Had to fix a few scripts first. BUG=none TEST=new test Review URL: http://codereview.chromium.org/3337018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@59107 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Sep, 2010 1 commit
-
-
maruel@chromium.org authored
Simplify GIT.Capture() code to always redirect stderr by default and always throw an exception on failure. Make gclient_scm_test silent. Replace raise Exception() with raise gclient_utils.Error(). BUG=54084 TEST=none Review URL: http://codereview.chromium.org/3353018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58936 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
gclient_scm_test is really flaky and is a pain to maintain. gclient_scm.py coverage is good enough with gclient_smokte_test. TBR=chase Review URL: http://codereview.chromium.org/3155024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56351 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Aug, 2010 1 commit
-
-
maruel@chromium.org authored
It raises the time to run the presubmit to ~30 seconds but it's still worth. TEST=run more often Review URL: http://codereview.chromium.org/3146010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@55759 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2010 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/2806020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@50481 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 May, 2010 1 commit
-
-
maruel@chromium.org authored
""" Enable automatic command and one-liner doc. Reformat pydoc accordingly. Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. R.I.P. gclient_test.py """ original code review at: http://codereview.chromium.org/2253002 In addition: - Add more smoke tests: vars, hooks, runhooks - Bugs filed about misbehavior with git checkout - Fixed gclient runhooks TEST=smoke test BUG=23328 Review URL: http://codereview.chromium.org/2265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48309 0039d316-1c4b-4281-b951-d872f2087c98
-