Commit 399318ec authored by maruel@chromium.org's avatar maruel@chromium.org

Fix gclient_utils_test and disable gclient_scm_test.

gclient_scm_test is really flaky and is a pain to maintain. gclient_scm.py
coverage is good enough with gclient_smokte_test.

TBR=chase

Review URL: http://codereview.chromium.org/3155024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56351 0039d316-1c4b-4281-b951-d872f2087c98
parent 8ad1cee6
......@@ -10,7 +10,8 @@ details on the presubmit API built into gcl.
UNIT_TESTS = [
'tests.gcl_unittest',
'tests.gclient_scm_test',
# The git tests are broken.
#'tests.gclient_scm_test',
'tests.gclient_smoketest',
'tests.gclient_utils_test',
'tests.presubmit_unittest',
......
......@@ -11,7 +11,13 @@ from super_mox import SuperMoxTestBase
import gclient_utils
class GclientUtilsUnittest(SuperMoxTestBase):
class GclientUtilBase(SuperMoxTestBase):
def setUp(self):
super(GclientUtilBase, self).setUp()
gclient_utils.sys.stdout.flush = lambda: None
class GclientUtilsUnittest(GclientUtilBase):
"""General gclient_utils.py tests."""
def testMembersChanged(self):
members = [
......@@ -29,7 +35,7 @@ class GclientUtilsUnittest(SuperMoxTestBase):
self.compareMembers(gclient_utils, members)
class CheckCallTestCase(SuperMoxTestBase):
class CheckCallTestCase(GclientUtilBase):
def testCheckCallSuccess(self):
command = ['boo', 'foo', 'bar']
process = self.mox.CreateMockAnything()
......@@ -65,7 +71,7 @@ class CheckCallTestCase(SuperMoxTestBase):
self.assertEqual(e.stderr, 'foo')
class SubprocessCallAndFilterTestCase(SuperMoxTestBase):
class SubprocessCallAndFilterTestCase(GclientUtilBase):
def testSubprocessCallAndFilter(self):
command = ['boo', 'foo', 'bar']
in_directory = 'bleh'
......@@ -102,7 +108,7 @@ class SubprocessCallAndFilterTestCase(SuperMoxTestBase):
self.assertEquals(capture_list, ['cc', 'dd'])
class SplitUrlRevisionTestCase(SuperMoxTestBase):
class SplitUrlRevisionTestCase(GclientUtilBase):
def testSSHUrl(self):
url = "ssh://test@example.com/test.git"
rev = "ac345e52dc"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment