Commits · 8818977467d88125743535010c5b37521694df0a · Linshizhi / Chromium_Depot_tools

29 Sep, 2016 2 commits

Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld · 88189774

tandrii authored Sep 29, 2016

Originally landed as issue 2378703002 at patchset 60001
(http://crrev.com/2378703002#ps60001).

BUG=chromium:649660
TBR=rmistry@chromium.org

Review-Url: https://codereview.chromium.org/2376323002

88189774

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs... · 31d165a5

tandrii authored Sep 29, 2016

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ )

Reason for revert:
Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround.

Original issue's description:
> Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
>
> BUG=chromium:649660
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5

TBR=rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:649660

Review-Url: https://codereview.chromium.org/2375393002

31d165a5

28 Sep, 2016 3 commits

Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld · 35747409
rmistry authored Sep 28, 2016
```
BUG=chromium:649660

Review-Url: https://codereview.chromium.org/2378703002
```
35747409

Roll recipe dependencies (trivial). · 3e1cde7a

recipe-roller authored Sep 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/69af4e53c1be1b0fbbc9e57edd70926b8d4f9370 Fix whitelist feature to preserve step order. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380433002

3e1cde7a

Roll recipe dependencies (trivial). · 2ca16919

recipe-roller authored Sep 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/01049d305bfe49d91aab3207372b5b0a0791ba63 Force printing of exception message. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650831

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375813002

2ca16919

27 Sep, 2016 1 commit

Roll recipe dependencies (trivial). · a8d76db7

recipe-roller authored Sep 27, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/79cf78db1a3c32c7730f3e9006825a95261abe06 Cleanup fetch, fix missing network flake instances (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650355

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2376543002

a8d76db7

26 Sep, 2016 4 commits

Roll recipe dependencies (trivial). · 6b2cc381

recipe-roller authored Sep 26, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/970fe6881473f82045801dff8c317a372c51d052 Update vendoring (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2370123002

6b2cc381

Remove git-svn support from fetch · 72762286

agable authored Sep 26, 2016

R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2360873002

72762286

git recipe_module: git new-branch. · bef52ff0

tandrii authored Sep 26, 2016

R=iannucci@chromium.org,qyearsley@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2369073002

bef52ff0

Use a whitelist for depot_tools pylint instead · f39c3338
agable authored Sep 26, 2016
```
R=maruel@chromium.org
BUG=644995

Review-Url: https://codereview.chromium.org/2353393004
```
f39c3338

23 Sep, 2016 4 commits

Introduce git merge driver for the blink reformatting · ff84560e

dcheng authored Sep 23, 2016

Based on CL from primiano@: https://codereview.chromium.org/2348793003/

This is a simple tool that can help automatically resolve conflicts
from clang-format reformatting patches.

BUG=574611

Review-Url: https://codereview.chromium.org/2356933002

ff84560e

Roll recipe dependencies (trivial). · 15ab0822

recipe-roller authored Sep 23, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:649466,chromium:649529

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2360143005

15ab0822

Delete unneeded test. · f3cc160f

stip authored Sep 23, 2016

Follow-up to https://codereview.chromium.org/2352393003. Note that a lot of these tests seem svn related, and can probably be deleted. I defer to to agable@ on what we can carve out here.

BUG=
R=agable@chromium.org

Review-Url: https://codereview.chromium.org/2360113002

f3cc160f

Change usage of deprecated flag. · 7a3dd357

stip authored Sep 23, 2016

BUG=Every time I run 'git cl upstream' I get "The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to."

Review-Url: https://codereview.chromium.org/2352393003

7a3dd357

22 Sep, 2016 2 commits

Roll recipe dependencies (trivial). · 32d8737b

recipe-roller authored Sep 22, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5b64ce6370b70afd63e463ae72f02e69ecc034ec Require recipes to emit at least one full test case. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2364463003

32d8737b

Delete git-auto-svn and its docs · 3b9a5bb8

agable authored Sep 22, 2016

We no longer support git-svn as a workflow.

R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2360143002

3b9a5bb8

21 Sep, 2016 1 commit

Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue · b61b9b75

hinoka authored Sep 21, 2016

Reland of https://codereview.chromium.org/2294413002/ after a rebase fix.

BUG=642150

Review-Url: https://codereview.chromium.org/2353833002

b61b9b75

20 Sep, 2016 2 commits

Updating git-for-windows to 2.10.0. · 23fe6cfb

vadimsh authored Sep 20, 2016

R=iannucci@chromium.org, hinoka@chromium.org
BUG=647446

Review-Url: https://codereview.chromium.org/2357633004

23fe6cfb

Revert of bot_update: add --auth-refresh-token-json passthrough for... · ad842878

hinoka authored Sep 20, 2016

Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (patchset #7 id:120001 of https://codereview.chromium.org/2294413002/ )

Reason for revert:
Pointing to the wrong file :(

Original issue's description:
> bot_update: add --auth-refresh-token-json passthrough for apply_issue
>
> BUG=642150
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f898f25b64a3ec4f5c003f7554e7

TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642150

Review-Url: https://codereview.chromium.org/2350363003

ad842878

19 Sep, 2016 5 commits

docs: Removing references to SVN · 186449d3
benhenry authored Sep 19, 2016
```
BUG=643697
TEST=None

Review-Url: https://codereview.chromium.org/2350293002
```
186449d3
bot_update: add --auth-refresh-token-json passthrough for apply_issue · e465667e
hinoka authored Sep 19, 2016
```
BUG=642150

Review-Url: https://codereview.chromium.org/2294413002
```
e465667e

Roll recipe dependencies (trivial). · e4abcee6

recipe-roller authored Sep 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f7ada90c926c78704f048767e29e8ae836d8a65b Prefer overridden dependencies. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354683004

e4abcee6

depot_tools: Remove third_party/gsutil · 8ea74908

hinoka authored Sep 19, 2016

A quick "git grep gsutil" reveals that this is no longer being used, and all
references to gsutil are pointed to gsutil.py.

BUG=

Review-Url: https://codereview.chromium.org/2280023003

8ea74908

Add ability to set topic during "git cl upload" · 9eadede7
rmistry authored Sep 19, 2016
```
BUG=chromium:628237

Review-Url: https://codereview.chromium.org/2343363003
```
9eadede7

16 Sep, 2016 5 commits

owners.py: partial fix for owners-check perf regression · 7e16cf30

nick authored Sep 16, 2016

fnmatch.fnmatch seems to fall off a performance cliff once you start cycling through more patterns than can fit in its internal cache.

BUG=642793

Review-Url: https://codereview.chromium.org/2293233002

7e16cf30

Make bot_update.py print git version it uses. · 6ac12ffd

vadimsh authored Sep 16, 2016

R=iannucci@chromium.org, dnj@chromium.org
BUG=647446

Review-Url: https://codereview.chromium.org/2344313002

6ac12ffd

Bump git-on-windows bleeding edge version to 2.10.0. · 7f245d07
vadimsh authored Sep 16, 2016
```
R=iannucci@chromium.org
BUG=647446

Review-Url: https://codereview.chromium.org/2347243002
```
7f245d07

Revert of bot_update: ensure correct depot_tools checkout is used. (patchset... · 15a24812

tandrii authored Sep 16, 2016

Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ )

Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.

Original issue's description:
> bot_update: ensure correct depot_tools checkout is used.
>
> R=vadimsh@chromium.org,martiniss@chromium.org
> BUG=635641,647446
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/972ac5040176acd90c8a1ce412f75d19f77cc4e8

TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2349673002

15a24812

bot_update: ensure correct depot_tools checkout is used. · 972ac504

tandrii authored Sep 16, 2016

R=vadimsh@chromium.org,martiniss@chromium.org
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2346973003

972ac504

15 Sep, 2016 2 commits

Teach bot_update to remove partially deleted git repos. · 18ca30ca

vadimsh authored Sep 15, 2016

Also add logging to 'remove', helps to debug issues with 'build.dead' filling
up with crap.

R=iannucci@chromium.org, hinoka@chromium.org
BUG=647046

Review-Url: https://codereview.chromium.org/2342973002

18ca30ca

presubmit_support: Remove a noisy logging.debug() · adcd4b78

thakis authored Sep 15, 2016

On a CL with a single file, presubmit writes all this noise:

Running /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames; cwd=/b/build/slave/linux/build/src
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc']
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:Running CheckChangeOnCommit done.

The "a matched b" lines are boring and numerous, so remove this log line.
If we ever need it to debug something, we can add it back then (temporarily).

(From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio)

BUG=none

Review-Url: https://codereview.chromium.org/2341103002

adcd4b78

14 Sep, 2016 7 commits

repo: update to v1.12.17-cr1 · 7475196d

vapier authored Sep 14, 2016

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted

Review-Url: https://codereview.chromium.org/2340073002

7475196d

git cl land to refs/pending: remove unused arg. · bf429405
tandrii authored Sep 14, 2016
```
R=iannucci@chromium.org
BUG=642493

Review-Url: https://codereview.chromium.org/2322783002
```
bf429405

Gerrit git cl land: abort if not uploaded. · 73449b0b

tandrii authored Sep 14, 2016

R=agable@chromium.org
BUG=642759,609225

Review-Url: https://codereview.chromium.org/2317253003

73449b0b

git_cl: update outdated TODOs. · 5d0a0421

tandrii authored Sep 14, 2016

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2339903002

5d0a0421

codereview.settings: add GIT_NUMBER_FOOTER setting. · f46c20fc

tandrii authored Sep 14, 2016

This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.

R=iannucci@chromium.org
BUG=642493

Review-Url: https://codereview.chromium.org/2324583002

f46c20fc

Roll recipe dependencies (nontrivial). · 34aa4d98

recipe-roller authored Sep 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/82c60d376b779c86f78ce98884fd4f887382e9ec Add better documentation, trigger namedtuple. (dnj@chromium.org)

R=dnj@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2335163004

34aa4d98

Add recipe-roller as an OWNER of recipe modules. · 33061f78

martiniss authored Sep 14, 2016

See https://codereview.chromium.org/2335163004 for why this is needed. The
roller can't land a non-trivial CL with the upstream author's LGTM, because
it's not an OWNER of the recipes in the repo it's rolling into.

Review-Url: https://codereview.chromium.org/2337263002

33061f78

13 Sep, 2016 2 commits

Roll recipe dependencies (trivial). · 65cc5b19

recipe-roller authored Sep 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ca75ca80dcfcc2a2dc38096ba0522065ebd347ec Revert of Require recipe tryjob for CQ. (patchset #1 id:1 of https://codereview.chromium.org/2153303002/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644609,628801

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338723003

65cc5b19

Roll recipe dependencies (nontrivial). · 1ce79108

recipe-roller authored Sep 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3 Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2336313002

1ce79108