Revert of bot_update: ensure correct depot_tools checkout is used. (patchset...

Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ )

Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.

Original issue's description:
> bot_update: ensure correct depot_tools checkout is used.
>
> R=vadimsh@chromium.org,martiniss@chromium.org
> BUG=635641,647446
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/972ac5040176acd90c8a1ce412f75d19f77cc4e8

TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2349673002

recipe_modules/bot_update/api.py

@@ -34,7 +34,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
     kwargs.setdefault('env', {})
     kwargs['env'].setdefault('PATH', '%(PATH)s')
     kwargs['env']['PATH'] = self.m.path.pathsep.join([
-        str(self._module.PACKAGE_REPO_ROOT), kwargs['env']['PATH']])
+        kwargs['env']['PATH'], str(self._module.PACKAGE_REPO_ROOT)])
     return self.m.python(name, bot_update_path, cmd, **kwargs)
 
   @property

recipe_modules/bot_update/example.expected/basic.json

@@ -18,7 +18,7 @@
       "src@abc"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update (without patch)",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/basic_output_manifest.json

@@ -19,7 +19,7 @@
       "--output_manifest"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/basic_with_branch_heads.json

@@ -19,7 +19,7 @@
       "--with_branch_heads"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update - with branch heads",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/clobber.json

@@ -19,7 +19,7 @@
       "--clobber"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json

@@ -19,7 +19,7 @@
       "--gerrit_no_rebase_patch_ref"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/gerrit_no_reset.json

@@ -19,7 +19,7 @@
       "--gerrit_no_reset"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/no_shallow.json

@@ -19,7 +19,7 @@
       "--no_shallow"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/reset_root_solution_revision.json

@@ -18,7 +18,7 @@
       "src@revision"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/trychange.json

@@ -20,7 +20,7 @@
       "+refs/change/1/2/333"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/trychange_oauth2.json

@@ -22,7 +22,7 @@
       "src@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob.json

@@ -24,7 +24,7 @@
       "src@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_fail.json

@@ -24,7 +24,7 @@
       "src@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_fail_patch.json

@@ -24,7 +24,7 @@
       "src@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

@@ -24,7 +24,7 @@
       "src@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json

@@ -24,7 +24,7 @@
       "src/third_party/angle@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_v8.json

@@ -26,7 +26,7 @@
       "src/v8@abc"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [

recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json

@@ -26,7 +26,7 @@
       "src/v8@HEAD"
     ],
     "env": {
-      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
     },
     "name": "bot_update",
     "~followup_annotations": [