- 05 Aug, 2022 1 commit
-
-
Brian Ryner authored
The bundled python interpreter is used instead. Bug: 1318617 Change-Id: I86c359ad765ecf494a11d199f2e01a711c86d4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3807202Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Ryner <bryner@google.com>
-
- 04 Aug, 2022 2 commits
-
-
Chan Li authored
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3811860 Bug: 1350060 Change-Id: I35081e93fd966a6b3da02f7fa4fbb6f458be83eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3812434 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Yuanjun Huang <yuanjunh@google.com>
-
Yuki Shiino authored
In case of PartitionAlloc project in Chromium, there is a case that it's useful to declare 'noparent' in the DEPS due to the situation that a sub directory is exported to a standalone git project. //base/allocator/partition_allocator/ (sub directory) is exported to https://chromium.googlesource.com/chromium/src/base/allocator/partition_allocator.git Change-Id: Ic51b6cd3928002962f25620b4d8797bed7802d1e Bug: chromium:1151236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3802719Reviewed-by:
Joanna Wang <jojwang@chromium.org>
-
- 03 Aug, 2022 3 commits
-
-
Garrett Beaty authored
This will pull in the change that allows for "led edit-cr-crl" to accept URLs in the form output by "git cl issue": URLs that do not contain the gerrit project. Bug: 1348269 Change-Id: Icb360686c9ca1548636e755bc9a611351d78d2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3807651 Commit-Queue: Garrett Beaty <gbeaty@google.com> Reviewed-by:
Chan Li <chanli@chromium.org>
-
Joanna Wang authored
Change-Id: I47961f3208a22cc05b5a38db3ccfd38a0f32520f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3808331Reviewed-by:
-
Brian Ryner authored
Once this is rolled out, we will no longer need to bootstrap python(3) in the vpython wrapper, only vpython itself. Bug: 1318617 Change-Id: If11b81f19d1d15eda74aae94ddc95c2997148c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3760318Reviewed-by:
Chenlin Fan <fancl@chromium.org> Commit-Queue: Brian Ryner <bryner@google.com> Reviewed-by:
-
- 02 Aug, 2022 2 commits
-
-
Bruce Dawson authored
Change crrev.com/c/3788227 fixed one instance of errors being treated as warnings when running "git cl presubmit" with the --upload option. This is undesirable when testing "git cl presubmit" with --all or --files, because it makes the errors harder to find. This change fixes four more newly discovered instances of this behavior. That is, this change makes it so that pylint issues and other serious problems will be reported as errors when running: git cl presubmit --force --all --upload This will make the pylint errors that this command triggers easier to find and fix: git cl presubmit --force --upload --files mojo\public\tools\bindings\*.py This change does _not_ turn cpplint warnings into errors, even though they are errors when running non-upload presubmits. That is because there are several directories that only run cpplint on upload and these directories have many errors and there is no short-term path to changing this. Bug: 1309977 Change-Id: If49f820fc6894dcd1d9aaaf4d932b04f79922bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3791744 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com>
-
Quinten Yearsley authored
Includes this change: https://chromium.googlesource.com/infra/luci/luci-go.git/+/85ebd26fcae0dcc91d12871da48babc572ee3d1b This changes the generation of location_filters from location_regexp in some cases. Bug: 1171945 Change-Id: I233281adb2edd62771f47ccb941fa99ade628f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3799232Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 01 Aug, 2022 3 commits
-
-
Brian Ryner authored
Contains commits: 7979d954927af292bd5a57dd398a9791cc43099c Use the full paths of bundled interpreters. ededcc9ee88d285f6c1ea6154b0c61da5cc6fd6a Provide a way to pass in the full python executable path. 376c57dec286030d5321b4aeffbbc26dd297d28c Add a test that inheritable file handles are passed through to Python. Bug: 1318617 Change-Id: Ib163c6b8d88667dcec5afe975006586d13b2b2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3787826Reviewed-by:
-
Joanna Wang authored
Bug: 1339472 Change-Id: I250dd72dd806d26ba6cbe213280ecd65fbc66123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3789864 Commit-Queue: Joanna Wang <jojwang@chromium.org> Reviewed-by:
-
Joanna Wang authored
Tested locally with chromium/src. going from 17s -> <1s Bug: 1339472 Change-Id: I71b90dcd6a7934ea7c9722dd040d63645792078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3791746 Commit-Queue: Joanna Wang <jojwang@chromium.org> Reviewed-by:
-
- 29 Jul, 2022 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807297222984475361 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dd96320d1653687c45d6e00d4e9024f99f021082 dd96320 (gerb@google.com) resultdb: Ensure Artifacts.contents is binary Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ic50d6d209d8ee3d482a13aa2ca46182a06622307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3793318 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 28 Jul, 2022 4 commits
-
-
Allen Xie authored
Include crrev.com/c/3779863 via https://chromium.googlesource.com/infra/infra/+/0fbf0c3c84a67bca202dd5002fb38bd93b08d0a1 Regenerate cipd_manifest.versions using `cipd ensure-file-resolve -ensure-file ./cipd_manifest.txt` rdb rollout example: crrev.com/c/3627691 BUG=b:1337692 TEST=No test Change-Id: I8407e55ed6054131e091a494ff7c016a346f0b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3789454Reviewed-by:
-
Arthur Milchior authored
Applying a command on a value usually mean to call `cmd value`. Hence it seemed important to me to clarify that the current working directory is changed. Tested: * Entered `gclient recurse --help` and checked the new message appear. * Entered both examples in the terminal and checked the output. Thanks to sdefresne for his help understanding recurse. Change-Id: I729efc2014ed3cf90112cc89875a283d58ce8af0 Fixed: 1345272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3769966Reviewed-by:
Arthur Milchior <arthurmilchior@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Arthur Milchior <arthurmilchior@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807367053469350273 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0cfa0e6e5b06a87c5b9de3f392158f721154b10a 0cfa0e6 (mohrr@google.com) [autoroll] Update to be Python 3-compatible Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ice762f8df9e6dba516011bc01f002cdc5057b604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3792804 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Vadim Shtayura authored
Changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/dd9f484..60808fd/lucicfg BUG=1347252 R=iannucci@chromium.org, ddoman@chromium.org Change-Id: I92b7f30d4589b116b3c2799a1df8e0d9a55eb356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3790164 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 27 Jul, 2022 2 commits
-
-
Joanna Wang authored
Bug:1339472 Change-Id: I19abca1f4319a89cc461935a83d136c8870944dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3721601Reviewed-by:
-
Bruce Dawson authored
When upload presubmits are being run then GetUnitTests would treat errors as warnings, so as to not stop developers from uploading their changes. This makes sense when patches are being manually uploaded, but doesn't make sense when running a "git cl presubmit --all --upload" bot. This behavior caused nine failures (but not all failures) to be missed when doing these tests. This change makes these failures errors when testing with --all --upload, but leaves them as warnings for other --upload purposes. Bug: 1309977 Change-Id: Ibf149475e4cdee10bbbbc86fd0ab668b7a679089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3788227Reviewed-by:
-
- 25 Jul, 2022 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807640106088174017 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/cfdb92cc6933d8f72c2340233ba03b602b447507~..4b7ba01b8ce8d4052feff1408188ef7932351b91 cfdb92c (akashmukherjee@google.com) [snoopy] Uprev client provenance reporter tool. 4b7ba01 (olivernewman@google.com) [analyze] Fix py3 incompatibility Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ic101705474072d9a238219194b0a6836832be4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3784103 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807647656305646913 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5db4d2294a373484109112db221911a729d2f160 5db4d22 (mohrr@google.com) [lint] Fix Py3 'Disallowed import' failures Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I4b4de2cb018388ba3e68f93de2995dad772a6326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3784098 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Mike Frysinger authored
We want people to use specific pylint-$VER wrappers now to get stable behavior and make it easier to roll updates. This one is just a link to pylint-1.5 which uses Python 2. Anyone still linting Python 2 code should be using pylint-1.5 explicitly. Let's drop this to get it out of $PATH for developers who want pylint from their host system to "just work". Change-Id: I14411db7cddd0ecce40a370366c21f496166fe1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3780302 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Brian Ryner <bryner@google.com>
-
- 22 Jul, 2022 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807898056175051073 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/8f92d0c510bcddd3c369a14d222ecc18d7c63783 8f92d0c (iannucci@chromium.org) [python3] Allow repos to be python3-only. Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I700d91111f462a371849459e4638f080692cd003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3781435 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Joanna Wang authored
Fixed: 1345847 Change-Id: I3d4ea30210f0bf7cb5ace5095d06ca459a7039b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3783155Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8807914413282070673 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5226416ff445b80b55042d5e28d51b5da035f48d 5226416 (iannucci@chromium.org) [legacy_annotations] Only merge properties if legacy_global_nam... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I9de30ac3c727d55826bcb029f8cf44465d4228c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3781431 Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Thiago Perrotta authored
Bug: None Change-Id: I4c161b05ab5c743cf8d6fddbf40af759f186eccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3782487Reviewed-by:
-
Thiago Perrotta authored
This change has precedent, c.f. 04d16a56 for infra_internal. R=yangguo Bug: None Change-Id: I089b114bcfe110ad138284bb71802cfc5d7f157d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3782488Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Thiago Perrotta authored
Although many things are private, the existence of Chrome is not. This change has precedent, c.f. 04d16a56 for infra_internal. Bug: None Change-Id: I6fb9719a44c2e5f5cc492bacb442d9554b0d4480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3779641Reviewed-by:
-
- 21 Jul, 2022 2 commits
-
-
Bruce Dawson authored
When investigating presubmits it is sometimes handy to get stacks in order to understand where a presubmit is being called from. In one recent investigation to see why CheckOwners was being called multiple times the traceback just said: File "c:\src\depot_tools\presubmit_support.py", line 1646, in _run_check_function result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "PRESUBMIT.py", line 251, in CheckChangeOnUpload That's not very helpful because Chromium has 288 files named PRESUBMIT.py. This change just uses the actual presubmit path as the filename parameter to compile instead of a hard-coded string, which means that "PRESUBMIT.py" is replaced with the full path in the tracebacks. Bug: 1309977 Change-Id: Icacfae4399444cb24e9cfb07475b90099e2e18d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3776955 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: -
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8808073586393338977 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/65f334b082e9fbec26b9de072da7666b86ec4d90 65f334b (iannucci@chromium.org) [legacy_annotation] Allow recipes to specify legacy mode. Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I61b1d17e983ea5b3042eea4cdf863b645cbc638f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3777903 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 20 Jul, 2022 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8808080509653586833 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e57338e3daf0ba532f2b29e369ab5d6ba4a503ba e57338e (iannucci@chromium.org) [luciexe] Update engine to emit build streams with MergeBuild. Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I49645bd087ca2c378f837efe26f03fa13760c564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3777902 Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Thiago Perrotta authored
Currently, `git cl help baseurl` fails as it tries to execute the subcommand, completely bypassing the help. Parse the arguments early so that the help command runs cleanly for baseurl. Fixed: 1345909 Change-Id: Icad7aca6cdc7c9938e91a421cb72e08433a30fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3776942 Auto-Submit: Thiago Perrotta <tperrotta@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Bug: 1327534 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: infra Change-Id: I5c84648eef8930f51d3809692d1cb3ffa46db6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3775846 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
-
Joanna Wang authored
- Instead of expecting the caller to run `rev-parse HEAD` before calling gclient, we can just store the latest commit on disk - this gets around the problem where gclient might git reset to the base checkout after applying patch-refs, so calling rev-parse before calling gclient sync might not actually return the latest commit of the last sync. - also moving os.environ[PREVIOUS_CUSTOM_VARS] setting to earlier when we only have the solutions in self.dependencies because all other dependencies inherit from the solutions so there's no point storing custom_vars for the rest. Bug: 1339472 Change-Id: I6a3570f09153bd8087bbe6bdab7ece4949856aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3750491Reviewed-by:
-
- 19 Jul, 2022 6 commits
-
-
Chan Li authored
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3761317 Bug: 1340318 Change-Id: Ib95bb8a8405695e4f4a93c6c954ca03e5d29d73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3774444Reviewed-by:
-
Quinten Yearsley authored
This reverts commit f05fcf70. Reason for revert: Reason for revert: I realized it's not yet safe to support directly specifying only location_filters because legacy CQ still triggers tryjobs and doesn't handle location_filters. Original change's description: > Update lucicfg from version 1.31.5 to 1.31.6 > > Changes: > - Allow direct use of location_filters in luci.cq_tryjob_verifier(...) > > Bug: 1171945 > Change-Id: I0aca6dd01976c66f106906958bc63a81dbd5e6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3770293 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Bug: 1171945 Change-Id: Ic7bea4b2ae73413361f8c239e0d6b823c1e7fd8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3774528 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Quinten Yearsley <qyearsley@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Chan Li authored
To include changes: - https://chromium-review.googlesource.com/c/infra/infra/+/3763941 - https://chromium-review.googlesource.com/c/infra/infra/+/3756684 - https://chromium-review.googlesource.com/c/infra/infra/+/3756685 Bug: 1343600, 1343601 Change-Id: Id18673ce7355875a207f52315383c039713f7aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3773731Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8808178026285733873 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a53cb2cf417da7ec0419cc283e9813586c9eea6b a53cb2c (iannucci@chromium.org) [manual_roll] Allow manual_roll to work even when protoc breaks. Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Id479cbfd324701c2dfda18c61936cbe4ef5919dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3774517 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8808180542829350001 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0ade4d7c8f99ecee1cfde3c9bbbe4160ec5f17a1 0ade4d7 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 46e5b6417320 to 9fbd373abf97 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I63357086edbf39b7b95e39d19270766b85c4ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3774516 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Takuto Ikuta authored
This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
- 18 Jul, 2022 1 commit
-
-
Quinten Yearsley authored
Changes: - Allow direct use of location_filters in luci.cq_tryjob_verifier(...) Bug: 1171945 Change-Id: I0aca6dd01976c66f106906958bc63a81dbd5e6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3770293Reviewed-by:
-
