-
Bruce Dawson authored
Change crrev.com/c/3788227 fixed one instance of errors being treated as warnings when running "git cl presubmit" with the --upload option. This is undesirable when testing "git cl presubmit" with --all or --files, because it makes the errors harder to find. This change fixes four more newly discovered instances of this behavior. That is, this change makes it so that pylint issues and other serious problems will be reported as errors when running: git cl presubmit --force --all --upload This will make the pylint errors that this command triggers easier to find and fix: git cl presubmit --force --upload --files mojo\public\tools\bindings\*.py This change does _not_ turn cpplint warnings into errors, even though they are errors when running non-upload presubmits. That is because there are several directories that only run cpplint on upload and these directories have many errors and there is no short-term path to changing this. Bug: 1309977 Change-Id: If49f820fc6894dcd1d9aaaf4d932b04f79922bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3791744 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Jesse McKenna <jessemckenna@google.com>
d895d01a