- 11 Oct, 2016 3 commits
-
-
tandrii authored
R=nodir@chromium.org,sergiyb@chromium.org BUG=599931 Review-Url: https://codereview.chromium.org/2400713003
-
tandrii authored
R=nodir@chromium.org,sergiyb@chromium.org BUG=599931 Review-Url: https://codereview.chromium.org/2401943002
-
tandrii authored
The flow looks like this: $ git cl status Branches associated with reviews: gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting) $ git cl try-results Warning: Codereview server has newer patchsets (2) than most recent upload from local checkout (None). Did a previous upload fail? By default, git cl try uses latest patchset from codereview, continuing using such patchset 2. Warning: Some results might be missing because You are not logged in. Please login first by running: depot-tools-auth login chromium-review.googlesource.com Started: Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/... Infra Linux Trusty 64 Tester https://luci-milo.appspot.com/swarming/... Total: 2 try jobs $ depot-tools-auth login chromium-review.googlesource.com <<<auth in my browser>>> Logged in to chromium-review.googlesource.com as <some@email.com> To login with a different email run: depot-tools-auth login chromium-review.googlesource.com To logout and purge the authentication token run: depot-tools-auth logout chromium-review.googlesource.com $ git config branch.gerrit-4483.gerritpatchset 2 $ git cl try-results Started: Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/... Infra Linux Trusty 64 Tester https://luci-milo.appspot.com/swarming/... Infra Mac Tester https://luci-milo.appspot.com/swarming/... Total: 3 try jobs R=sergiyb@chromium.org,emso@chromium.org BUG=599931 TEST=new unittests + end-to-end local. Review-Url: https://codereview.chromium.org/2392463009
-
- 10 Oct, 2016 2 commits
-
-
tandrii authored
No stacktrace is printed, instead just a user-friendly string is shown. Add test + some tests refactoring. This CL also improve missing Gerrit issue exception elsewhere by raising user-friendly exception. BUG=654360 R=sergiyb@chromium.org TEST=manual Review-Url: https://codereview.chromium.org/2403793002
-
tandrii authored
R=nodir@chromium.org BUG= Review-Url: https://codereview.chromium.org/2399993004
-
- 07 Oct, 2016 1 commit
-
-
tandrii authored
R=phajdan.jr@chromium.org,sergiyb@chromium.org BUG=599931 Review-Url: https://codereview.chromium.org/2400793004
-
- 06 Oct, 2016 2 commits
-
-
tandrii authored
R=emso@chromium.org,phajdan.jr@chromium.org BUG=599931 TEST=new teste + local end-to-end Review-Url: https://codereview.chromium.org/2395113002
-
tandrii authored
R=emso@chromium.org BUG= Review-Url: https://codereview.chromium.org/2393253002
-
- 29 Sep, 2016 2 commits
-
-
tandrii authored
Originally landed as issue 2378703002 at patchset 60001 (http://crrev.com/2378703002#ps60001). BUG=chromium:649660 TBR=rmistry@chromium.org Review-Url: https://codereview.chromium.org/2376323002
-
tandrii authored
Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ ) Reason for revert: Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround. Original issue's description: > Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld > > BUG=chromium:649660 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5 TBR=rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:649660 Review-Url: https://codereview.chromium.org/2375393002
-
- 28 Sep, 2016 1 commit
-
-
rmistry authored
BUG=chromium:649660 Review-Url: https://codereview.chromium.org/2378703002
-
- 23 Sep, 2016 1 commit
-
-
stip authored
BUG=Every time I run 'git cl upstream' I get "The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to." Review-Url: https://codereview.chromium.org/2352393003
-
- 22 Sep, 2016 1 commit
-
-
agable authored
We no longer support git-svn as a workflow. R=iannucci@chromium.org BUG=475320 Review-Url: https://codereview.chromium.org/2360143002
-
- 19 Sep, 2016 1 commit
-
-
rmistry authored
BUG=chromium:628237 Review-Url: https://codereview.chromium.org/2343363003
-
- 14 Sep, 2016 4 commits
-
-
tandrii authored
R=iannucci@chromium.org BUG=642493 Review-Url: https://codereview.chromium.org/2322783002
-
tandrii authored
R=agable@chromium.org BUG=642759,609225 Review-Url: https://codereview.chromium.org/2317253003
-
tandrii authored
R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2339903002
-
tandrii authored
This will be used in repositories that use Cr-Commit-Position footers to generate them at the time of git cl land instead of gnumbd. R=iannucci@chromium.org BUG=642493 Review-Url: https://codereview.chromium.org/2324583002
-
- 09 Sep, 2016 1 commit
-
-
agable authored
R=andybons@chromium.org, tandrii@chromium.org Review-Url: https://codereview.chromium.org/2324283002
-
- 08 Sep, 2016 1 commit
-
-
dsansome authored
BUG=641838 Review-Url: https://codereview.chromium.org/2318903002
-
- 02 Sep, 2016 1 commit
-
-
dnj authored
Currently, if one edits one's local CL description (e.g., `git commit --amend`), there is no path for that update to get pushed to Rietveld. This adds a "+" sentinel to the "-n" flag for `git cl description` that tells it to load description content from the local commit. The description should match what would be generated by "git cl upload". BUG=None TEST=local Review-Url: https://codereview.chromium.org/2307463002
-
- 01 Sep, 2016 1 commit
-
-
qyearsley authored
For use in scripts that check try job results, this is currently practically the same as making requests to https://codereview.chromium.org/api/<cl-number>/<patchset-number>. However, I think that this might be more future-proof, since it fetches try job information from Buildbucket, and I expect to still work after migration from Rietveld to Gerrit. BUG=640354 Review-Url: https://codereview.chromium.org/2274743003
-
- 29 Aug, 2016 2 commits
-
-
thomasanderson authored
Review-Url: https://codereview.chromium.org/2285393002
-
tandrii authored
R=andybons@chromium.org BUG=641127 Review-Url: https://codereview.chromium.org/2280563003
-
- 24 Aug, 2016 4 commits
-
-
agable authored
R=tandrii@chromium.org BUG=638750 Review-Url: https://codereview.chromium.org/2271873003
-
agable authored
These tools are relatively standalone, and only ever worked for SVN. Removing these is a good start to removing other SVN support code. R=maruel@chromium.org BUG=475321 Review-Url: https://codereview.chromium.org/2269413002
-
qyearsley authored
This should only change spelling in: - messages that are printed - comments - docstrings Review-Url: https://codereview.chromium.org/2277513002
-
qyearsley authored
I know this is an unimportant change, and that across Chromium, "try job" and "tryjob", and "try bot" and "trybot" are basically interchangeable, still I think it's nice to have the spelling consistent within one module. I prefer the version with a space just because that's what's used in the documentation: https://www.chromium.org/developers/testing/try-server-usage Review-Url: https://codereview.chromium.org/2269283002
-
- 23 Aug, 2016 2 commits
-
-
kmarshall authored
This CL adds a couple flags to "git cl archive". dry-run: Lists the cleanup tasks, but exits before any changes are made to Git. notags: Deletes branches only; does not create archival tags. R=tandrii@chromium.org,groby@chromium.org BUG= Review-Url: https://codereview.chromium.org/2276663002
-
tandrii authored
R=maruel@chromium.org,phajdan.jr@chromium.org BUG=640115 Review-Url: https://codereview.chromium.org/2272613002
-
- 22 Aug, 2016 1 commit
-
-
phajdan.jr authored
This was requested in https://chromium-review.googlesource.com/c/373499 BUG=none Review-Url: https://codereview.chromium.org/2263103002
-
- 18 Aug, 2016 3 commits
-
-
tandrii authored
This is because later calls to SetIssue() would fail. R=michaelpg@chromium.org BUG=611020 Review-Url: https://codereview.chromium.org/2259993002
-
tandrii authored
Previously there was a soup with add-hoc formatting with current branch name, which wasn't always set (see bug 611020). This CL makes sure all such operations now: * properly use types --int and --bool * go through the *only* appropriate get/set/unset function. Furthermore, tests were a mess wrt to raising exceptions when git processes terminated with an exception. This CL cleaned up, though I didn't go through all expectations, so some returns of empty stdout instead of raising CalledProcess error are likely remaining. Disclaimer: this CL is not necessarily fixing the referenced bug below, but it should at least provide better stacktrace when the bug manifestst itself. BUG=611020 R=agable@chromium.org Review-Url: https://codereview.chromium.org/2259043002
-
tandrii authored
R=andybons@chromium.org BUG= Review-Url: https://codereview.chromium.org/2260453002
-
- 17 Aug, 2016 5 commits
-
-
iannucci authored
R=phajdan.jr@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2245263007
-
tandrii authored
BUG=626364 R=andybons@chromium.org TEST=manual: https://chromium-review.googlesource.com/#/c/372138 Review-Url: https://codereview.chromium.org/2259583002
-
iannucci authored
R=phajdan.jr@chromium.org, vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2250323003
-
tandrii authored
BUG=629863 R=seanmccullough@chromium.org,andybons@chromium.org Review-Url: https://codereview.chromium.org/2249303003
-
tandrii authored
Without it, upload fails because ref is invalid. BUG=622062 R=andybons@chromium.org Review-Url: https://codereview.chromium.org/2252043002
-
- 16 Aug, 2016 1 commit
-
-
phajdan.jr authored
BUG=620494 Review-Url: https://codereview.chromium.org/2252473004
-