Commit 4d895505 authored by tandrii's avatar tandrii Committed by Commit bot

git cl: avoid infinite recursion during debug/development.

R=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2260453002
parent 196aa81d
......@@ -1461,7 +1461,12 @@ class Changelist(object):
# This is because lots of untested code accesses Rietveld-specific stuff
# directly, and it's hard to fix for sure. So, just let it work, and fix
# on a case by case basis.
return getattr(self._codereview_impl, attr)
# Note that child method defines __getattr__ as well, and forwards it here,
# because _RietveldChangelistImpl is not cleaned up yet, and given
# deprecation of Rietveld, it should probably be just removed.
# Until that time, avoid infinite recursion by bypassing __getattr__
# of implementation class.
return self._codereview_impl.__getattribute__(attr)
class _ChangelistCodereviewBase(object):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment