Commits · 7ccf2f0c21b30b88a462108ee2e39ed7d55b2f2f · Linshizhi / Chromium_Depot_tools

26 Jun, 2018 3 commits

gclient: Report what dependencies were not processed. · 7ccf2f0c

Edward Lemur authored Jun 26, 2018

Report the dependencies that were not synced, due to their, or their parent's
condition evaluating to False.

Bug: 853010
Change-Id: I375703a1b91e3c3e31e444b0df1c95ecae17b6ba
Reviewed-on: https://chromium-review.googlesource.com/1111113Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7ccf2f0c

[cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d. · 83a57e01

Vadim Shtayura authored Jun 26, 2018

2018-06-26 vadimsh [cipd] Do not barf on -pkg-var when using -in.
2018-06-26 vadimsh [cipd] Fix and improve output of ensure-file-verify.
2018-06-26 vadimsh [cipd] Fix hanging in 'ensure-file-verify' if the ensure file is broken.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=801423

Change-Id: Ic48753e30f2412f214ebfb73bb7693e5834cdbf7
Reviewed-on: https://chromium-review.googlesource.com/1115464Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

83a57e01

Roll recipe dependencies (trivial). · 4c50badb

recipe-roller authored Jun 26, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e autoroller: Search for gitattributes files only in modified dirs. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e6cde4f438eb189a6bd8f8623691e2c445d2a78
Reviewed-on: https://chromium-review.googlesource.com/1114263Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

4c50badb

25 Jun, 2018 2 commits

[cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9. · a02505f5

Vadim Shtayura authored Jun 25, 2018

New versions understand CIPD_PROTOCOL=v2.

R=tandrii@chromium.org
BUG=801423

Change-Id: I6ca28638393957a9965a0ded7ed49c15b3a8f5b0
Reviewed-on: https://chromium-review.googlesource.com/1114296Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

a02505f5

Reland of "Wipe out shallow checkout support from bot_update." · 77094f7f

Andrii Shyshkalov authored Jun 25, 2018

Originally-Reviewed-on: https://chromium-review.googlesource.com/1111107
Led-test: https://ci.chromium.org/swarming/task/3e51ed0e31211710?server=chromium-swarm.appspot.com

TBR=hinoka, iannucci

Bug: 855137
Change-Id: I157ef6b9ee2a7ce45e4a474853ae769a82cc4c99
Reviewed-on: https://chromium-review.googlesource.com/1114234
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

77094f7f

23 Jun, 2018 1 commit

Roll recipe dependencies (trivial). · d91a468a

recipe-roller authored Jun 23, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6cf964d26783026b01cdcdf8c40b30e9fb0c845d [cipd] Add support for acl-check command (phosek@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I929fca321284426c8c96ef7a1ceb00ac1ef857a2
Reviewed-on: https://chromium-review.googlesource.com/1112801
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

d91a468a

22 Jun, 2018 7 commits

Roll recipe dependencies (trivial). · 08d753e8

recipe-roller authored Jun 22, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/09ac15a0e9da9cf8f2c22320968f21544a0b25f0 gitattr_checker: Add tests for the cache. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f9902a2a8c781124f6c84f945fb2e298ca936fa
Reviewed-on: https://chromium-review.googlesource.com/1112474Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

08d753e8

Revert "bot_update: Don't force solutions to be unmanaged." · 612d62d0

Andrii Shyshkalov authored Jun 22, 2018

This reverts commit c48318a3.

Reason for revert: likely broke ChromeOS

Original change's description:
> bot_update: Don't force solutions to be unmanaged.
> 
> gclient should be the one syncing the solutions to the appropriate
> revisions.
> 
> Bug: 850812, 853032
> Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29
> Reviewed-on: https://chromium-review.googlesource.com/1102833
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=hinoka@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: I7e110108a9687d703ea8be39cc83e0888f7813c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850812, 853032, 855700
Reviewed-on: https://chromium-review.googlesource.com/1111925Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

612d62d0

Revert "Wipe out shallow checkout support from bot_update." · 565fa6a4

Andrii Shyshkalov authored Jun 22, 2018

This reverts commit 568b7a89.

Reason for revert: temporary revert to revert previous CL.

Original change's description:
> Wipe out shallow checkout support from bot_update.
> 
> Bug: 855137
> Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c
> Reviewed-on: https://chromium-review.googlesource.com/1111107
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=iannucci@chromium.org,hinoka@chromium.org,tandrii@chromium.org

Change-Id: Iede67717be448be9bdd7c5dd4895fbab9fd65c66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855137, 855700
Reviewed-on: https://chromium-review.googlesource.com/1111924Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

565fa6a4

Wipe out shallow checkout support from bot_update. · 568b7a89

Andrii Shyshkalov authored Jun 22, 2018

Bug: 855137
Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c
Reviewed-on: https://chromium-review.googlesource.com/1111107
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

568b7a89

bot_update: Don't force solutions to be unmanaged. · c48318a3

Edward Lemur authored Jun 22, 2018

gclient should be the one syncing the solutions to the appropriate
revisions.

Bug: 850812, 853032
Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29
Reviewed-on: https://chromium-review.googlesource.com/1102833Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c48318a3

[win-cross] Support using a zip file for the Windows SDK · c5a26a76

Henrique Ferreiro authored Jun 22, 2018

Renames DEPOT_TOOLS_WIN_TOOLCHAIN_HTTP_BASE_URL to
DEPOT_TOOLS_WIN_TOOLCHAIN_BASE_LOCATION. This environment variable can
now point to a local directory where the Windows SDK zip file is stored.
This allows non-Googlers to cross-compile Chromium for Windows.

Bug: 852347
Change-Id: I00650e84247f35b4b8cfba204e0f2afd0882b69b
Reviewed-on: https://chromium-review.googlesource.com/1098256
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>

c5a26a76

Revert "cpplint: Pull in upstream changes" · 7999d926

Sergiy Byelozyorov authored Jun 22, 2018

This reverts commit f7e1e10d.

Reason for revert: breaks V8 presubmit, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_presubmit/b8943030202460843984

Original change's description:
> cpplint: Pull in upstream changes
> 
> The changes include:
> - root flag now can process non-subdirectories
> -- https://github.com/google/styleguide/commit/e7ddd2af622475b0c5e0f587d69fb061d2c10c46
> 
> - root flag can be configured with CPPLINT.cfg
> -- https://github.com/google/styleguide/commit/2322e4ffaa19f4c55e5679102318ce67454fb7ed
> 
> - root setting is relative to the CPPLINT.cfg file
> -- https://github.com/google/styleguide/commit/8a87a46cc7f8d6cca5c0203ddba5d81149db7695
> 
> - Cleans up header file detection for hpp and hxx
> 
> - Adds quite mode
> 
> Bug: 852898
> 
> Change-Id: Id44bbfadc913cc27192049ab9a222f22d0deab5d
> Reviewed-on: https://chromium-review.googlesource.com/1108381
> Commit-Queue: Amin Hassani <ahassani@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ahassani@chromium.org

Change-Id: I3d380ecf8cb80000d7f7dcc0a2c75bb8a12d2a51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 852898
Reviewed-on: https://chromium-review.googlesource.com/1111797Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

7999d926

21 Jun, 2018 12 commits

Add gerrit retries for HTTP 409 Conflict responses. · 120b2e4f

Michael Moss authored Jun 21, 2018

BUG=crbug.com/854886,b/110032771
R=tandrii@google.com

Change-Id: Iabd67f8042ab3bc7c6ef15101effeeebf39d4500
Reviewed-on: https://chromium-review.googlesource.com/1111007Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

120b2e4f

Demote linux-386 to "best effort support", just like e.g. linux-ppc64. · 09098853

Vadim Shtayura authored Jun 21, 2018

It seems unfair to completely kill linux-386, while we still provide minimal
best-effort support for more exotic platforms like linux-ppc64 or linux-s390x.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=854300

Change-Id: Ia31ebb42f7e596c495b09bb99ecb376801256d55
Reviewed-on: https://chromium-review.googlesource.com/1111026Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

09098853

Roll recipe dependencies (trivial). · 18405eb8

recipe-roller authored Jun 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/94bb0a758456a5df6891677a8cf2876c07ea5f0c Fix typo in autoroll code. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I806e869de63aaed37a56a227176360e44c1ff9fe
Reviewed-on: https://chromium-review.googlesource.com/1110713
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

18405eb8

gclient: Make gclient respect unmanaged dependencies when syncing. · e4213704

Edward Lemur authored Jun 21, 2018

gclient syncs unmanaged dependencies when '--revision' files are passed,
regardless of whether the dependency appears in the revision flags or not.

Bug: 853032
Change-Id: I66de0865e1103d92524f565f4392dae24a5648e1
Reviewed-on: https://chromium-review.googlesource.com/1105416Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e4213704

Roll recipe dependencies (trivial). · cf0324cd

recipe-roller authored Jun 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/76d8765a8b0b0f8702de49231b7f3eba66970afc Prune more evidence of VPython from the environment. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I63bd91b469fd1c46d97813e986e6146b0078a078
Reviewed-on: https://chromium-review.googlesource.com/1110709
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

cf0324cd

Stop checking CIPD packages exist on linux-386. · 87b879ed

Vadim Shtayura authored Jun 21, 2018

We no longer support linux-386 and there are no CIPD builders that build
packages for it.

R=tandrii@chromium.org
BUG=854300

Change-Id: Ibfefee828118c898432784c8ef3dd5894a28cfaa
Reviewed-on: https://chromium-review.googlesource.com/1110845Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

87b879ed

cpplint: Pull in upstream changes · f7e1e10d

Amin Hassani authored Jun 21, 2018

The changes include:
- root flag now can process non-subdirectories
-- https://github.com/google/styleguide/commit/e7ddd2af622475b0c5e0f587d69fb061d2c10c46

- root flag can be configured with CPPLINT.cfg
-- https://github.com/google/styleguide/commit/2322e4ffaa19f4c55e5679102318ce67454fb7ed

- root setting is relative to the CPPLINT.cfg file
-- https://github.com/google/styleguide/commit/8a87a46cc7f8d6cca5c0203ddba5d81149db7695

- Cleans up header file detection for hpp and hxx

- Adds quite mode

Bug: 852898

Change-Id: Id44bbfadc913cc27192049ab9a222f22d0deab5d
Reviewed-on: https://chromium-review.googlesource.com/1108381
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

f7e1e10d

bot_update: default to non-shallow checkouts. · 124365b8

Andrii Shyshkalov authored Jun 21, 2018

shallow mode is a special git mode that only checks out a shallow copy
of git so the full history is not downloaded. It is not well supported
by googlesource.com servers because git has to do a giant negotiation
with the server and transmit every single commit that the local checkout
has or doesn't have (instead of just the latest commit of each ref),
which ends up taking more than 10x longer than a non-shallow checkout.

R=ehmaldonado, hinoka, iannucci

Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 855137
Change-Id: I5f9e31f8b2730cf80b79bfd0e08201c33eb942f5
Reviewed-on: https://chromium-review.googlesource.com/1110450
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

124365b8

Fix minor regression in git_upstream_diff. · eb5f85b1

Robert Iannucci authored Jun 21, 2018

89734301 introduced a new useful feature
to `git upstream-diff`, but unfortunately also regressed the behavior
of the tool when used with additional arguments for `git diff`.

This adds some additional documentation to demonstrate the intended
original feature (and fixes some of the bit-rot in the documentation
pipeline).

R=agable@chromium.org, mattm@chromium.org

Change-Id: I3ae48db3232c1ac84a7edbfe2225a17cda391a1e
Reviewed-on: https://chromium-review.googlesource.com/1107491
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

eb5f85b1

gclient: Use posixpath-style separators for cipd subdirs on all platforms. · 4099daa9

John Budorick authored Jun 21, 2018

Bug: 854219
Change-Id: Ibd83135dcb96979f8ab989a248e3e2cf59b9dd43
Reviewed-on: https://chromium-review.googlesource.com/1106698
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

4099daa9

chromite_wrapper: add python3 support for except · 04925ac3

Simon Glass authored Jun 21, 2018

I don't have an account on the chrome gerrit or whatever, and don't
really want to create one for a oneline patch, so I was hoping you'd be
ok with passing this along through the proper channels.

R=ehmaldonado@chromium.org
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
Bug: None
Change-Id: I3daf58ee802e7c9b144227999f1832b364c5759a
Reviewed-on: https://chromium-review.googlesource.com/1096128Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

04925ac3

Roll recipe dependencies (trivial). · a28b14f1

recipe-roller authored Jun 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0e71eb80de4e88898496b6dcc752ca9554c0433c Remove all bootstrapping logic from recipe engine. (iannucci@chromium.org)
  https://crrev.com/59ce6b333bae640882c70e5eb79a3f37662925f4 Do not rely on recipes.py to update recipe_engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c683261f5fd7909be761557e6ec41c697868945
Reviewed-on: https://chromium-review.googlesource.com/1109392Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

a28b14f1

20 Jun, 2018 3 commits

Add yapf · 081487b9

Nodir Turakulov authored Jun 20, 2018

Add yapf and yapf.bat with a vpython spec, so it can be used anywhere, e.g.
bots.

Change-Id: I363c0251ed766b2bb15a8c0f03615bc9a3ecb37a
Reviewed-on: https://chromium-review.googlesource.com/1107170
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

081487b9

Roll recipe dependencies (trivial). · b65b611d

recipe-roller authored Jun 20, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb autoroller: Take into account files with the recipes git attribute. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I373065df9648da4ca1e801c72f672e2ab82b3012
Reviewed-on: https://chromium-review.googlesource.com/1108091
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

b65b611d

pylint: update to 1.4.5 · 49083eaa

Mike Frysinger authored Jun 20, 2018

Grab a few random fixes like deleting old abstract-class-little-used,
abstract-class-not-used, and star-args.

Bug: None
Test: `./pylint *.py` shows no regressions
Change-Id: I494379e18da002d479cb193412fcc49f8c66f376
Reviewed-on: https://chromium-review.googlesource.com/1103763Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

49083eaa

19 Jun, 2018 2 commits

Roll recipe dependencies (trivial). · 1cabdc46

recipe-roller authored Jun 19, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/632ab33e87ee81e14a936c475b4bdbae264154ac Fix all tests to use vpython. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67c7cae74db2bf38fb3407c34b205b1bdb4df53c
Reviewed-on: https://chromium-review.googlesource.com/1106912Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

1cabdc46

AIX: Enable usage of fetch and gclient · 179059f6

Vasili Skurydzin authored Jun 19, 2018

Change-Id: I4fe559cb44ccd9c6b037b7b096b088adf652ef9b
Reviewed-on: https://chromium-review.googlesource.com/1102718
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

179059f6

15 Jun, 2018 4 commits

Third whitespace change to test builder. · 79d42dfb

Robert Iannucci authored Jun 15, 2018

TBR=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: I6185d79594f63a4652d458d33f9fed325b8d3b85
Reviewed-on: https://chromium-review.googlesource.com/1103302
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

79d42dfb

More testing whitespace. · 09160517

Robert Iannucci authored Jun 15, 2018

TBR=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: I2aa5f1aabeeaa46a64defa4947a5a814851a056c
Reviewed-on: https://chromium-review.googlesource.com/1103010Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

09160517

Whitespace change to test new builder. · 44fccfae

Robert Iannucci authored Jun 15, 2018

R=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: Ibba096deee850fc695a0823e5a22247f394053fb
Reviewed-on: https://chromium-review.googlesource.com/1103007Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

44fccfae

Revert "gclient: Don't allow None URLs (except in .gclient files)" · d683d7ce

Michael Moss authored Jun 15, 2018

This reverts commit 0c91147d.

Reason for revert: This is causing 'gclient revinfo' to fail on the release builders, and appears to be somehow related to the "--output-json" flag.

Original change's description:
> gclient: Don't allow None URLs (except in .gclient files)
> 
> This reverts commit crrev.com/4e9b50ab
> and thus relands the following commits:
> 
>   ebdd0db4: "gclient: Remove URLs from hierarchy."
>   54a5c2ba: "gclient: Refactor PrintRevInfo"
>   083eb25f: "gclient: Don't allow URL to be None."
> 
> When a None URL is specified in a .gclient file, and a DEPS file is
> given, the DEPS file is treated as a .gclient file and its dependencies
> are added.
> 
> Bug: 839925
> 
> Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e
> Reviewed-on: https://chromium-review.googlesource.com/1083340
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I46785bd272b16b3672e553b6443cee6d6b370ec1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839925, 853093
Reviewed-on: https://chromium-review.googlesource.com/1101978Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

d683d7ce

14 Jun, 2018 5 commits

Add infradata/config repo to gclient. · fce7bc9e

Andrii Shyshkalov authored Jun 14, 2018

This way it'll be discoverable by run_presubmit recipe.

R=vadimsh

Bug: 613739
Change-Id: I84ec3b84292940e74e4d707e4d257eb560004f56
Reviewed-on: https://chromium-review.googlesource.com/1102010Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

fce7bc9e

Revert "gclient_scm: Use cherry-picking instead of rebasing." · 690d8d43

Andrii Shyshkalov authored Jun 14, 2018

This reverts commit c9121141.

Reason for revert: broke patch application on infra/config https://crbug.com/853032

Original change's description:
> gclient_scm: Use cherry-picking instead of rebasing.
> 
> We have a problem when in this situation, we checkout |patch| and rebase it on
> top of |base|, thus including an |extra commit| that we shouldn't.
> 
> o master
> |
> . o patch
> |/
> o extra commit
> |
> o base (what gclient synced src at)
> 
> This does merge-base between |patch| and |master|, and cherry-picks only the
> changes belonging to the patch.
> 
> Bug: 850812
> Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
> Reviewed-on: https://chromium-review.googlesource.com/1098228
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org

Change-Id: Ib3feeee2f44f5441713383f1dbf08db16fae4717
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850812, 853032
Reviewed-on: https://chromium-review.googlesource.com/1101977Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

690d8d43

gclient_scm: Use cherry-picking instead of rebasing. · c9121141

Edward Lemur authored Jun 14, 2018

We have a problem when in this situation, we checkout |patch| and rebase it on
top of |base|, thus including an |extra commit| that we shouldn't.

o master
|
. o patch
|/
o extra commit
|
o base (what gclient synced src at)

This does merge-base between |patch| and |master|, and cherry-picks only the
changes belonging to the patch.

Bug: 850812
Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
Reviewed-on: https://chromium-review.googlesource.com/1098228
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

c9121141

gclient: Don't allow None URLs (except in .gclient files) · 0c91147d

Edward Lemur authored Jun 14, 2018

This reverts commit crrev.com/4e9b50ab
and thus relands the following commits:

  ebdd0db4: "gclient: Remove URLs from hierarchy."
  54a5c2ba: "gclient: Refactor PrintRevInfo"
  083eb25f: "gclient: Don't allow URL to be None."

When a None URL is specified in a .gclient file, and a DEPS file is
given, the DEPS file is treated as a .gclient file and its dependencies
are added.

Bug: 839925

Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e
Reviewed-on: https://chromium-review.googlesource.com/1083340
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

0c91147d

Allow CheckPatchFormatted to cause a failure · 425d9ce2

Nodir Turakulov authored Jun 14, 2018

Extend CheckPatchFormatted to allow other presubmit result types.

Change-Id: I1c592d73657aa9c8a8fd04dbd66f086ce7bb1274
Reviewed-on: https://chromium-review.googlesource.com/1100127Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

425d9ce2

13 Jun, 2018 1 commit

gclient recipe: use env_suffixes insetad of custom ENV manipulation. · cd8d4a65

Andrii Shyshkalov authored Jun 13, 2018

R=iannucci@chromium.org

Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Change-Id: Ie0b042389b7e2c505cd8dbecc1a30a37244ae238
Reviewed-on: https://chromium-review.googlesource.com/1100110Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

cd8d4a65