- 11 Jan, 2020 1 commit
-
-
Edward Lesmes authored
Bug: 1036606 Change-Id: I035250757e346f89390b36d44701f0b6b8d8d024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1995888 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
- 10 Jan, 2020 6 commits
-
-
Edward Lesmes authored
This is a reland of 797d74a2 Original change's description: > vpython: Specify interpreter to run. > > Specify the interpreter to run to avoid issues with several > python installations on Windows. > > Bug: 1036606 > > Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1036606 Change-Id: Ibf6727249b40c5a9f5f877353c8d42fe66404cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994215Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
On Windows, scripts on the current directory take precedence over PATH. When pylint.bat calls vpython, it executes the vpython of the depot_tools under test instead of the one in the bot. As a workaround, run the tests from the parent directory instead. Change-Id: I7fa3f5b268df516194063ff39907ada18f7ef544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994216Reviewed-by:
-
Edward Lemur authored
Change-Id: I8fd0034f6a6d7623792620f92208b25961fa174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1990142Reviewed-by:
-
Edward Lesmes authored
Bug: 1041020 Change-Id: I725a599dcd5dc8b2a18d49bad33b2dbdcfe7ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994428 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Jamie Madill authored
This reverts commit fc132e61. Reason for revert: Causes all presubmit checks to return dirty format because of a non-zero diff output. Original change's description: > git-cl: Fix format --dry-run not working with --full. > > The --full option would skip setting the return value of the format > command when used with --dry-run. This in turn would cause the > presubmit check to always pass when --full was enabled in a repo by > default. > > Was discovered in the ANGLE repository. > > Bug: angleproject:4241 > Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> TBR=ehmaldonado@chromium.org,jmadill@chromium.org Change-Id: I0a4c51117ab20606f6dbb1f7a3ba40f87da1e939 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993907Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
The --full option would skip setting the return value of the format command when used with --dry-run. This in turn would cause the presubmit check to always pass when --full was enabled in a repo by default. Was discovered in the ANGLE repository. Bug: angleproject:4241 Change-Id: Ie6cb423a6818c1e26781d77938a0dd22c02b4c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987835 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
-
- 09 Jan, 2020 4 commits
-
-
Edward Lesmes authored
This reverts commit 797d74a2. Reason for revert: Causes pylint to fail executing on "Depot Tools Presubmit (win)". Original change's description: > vpython: Specify interpreter to run. > > Specify the interpreter to run to avoid issues with several > python installations on Windows. > > Bug: 1036606 > > Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com Change-Id: I5902ceb9db85fdad81e781b51281fba8534a99d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1994114Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ec5140c30b91e961996b5bd690b8c27f01dd9c56 path: add relpath to the list of filtered methods. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I637192b1f4ad38d75300267a88031a3ac593130c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1993512Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Specify the interpreter to run to avoid issues with several python installations on Windows. Bug: 1036606 Change-Id: Ib70d041acc52c940711460219acd8f4ad58637a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992608Reviewed-by:
-
Edward Lesmes authored
As a workaround, add the Python3 bin dir to PATH so that the necessary DLLs are available. Bug: 1003139 Change-Id: I7b3e05922be3fcb7b0ec2b06783a86f25484310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992270Reviewed-by:
smut <smut@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 08 Jan, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2438e081638a16b8de53752c5a78c807195ed186 Return a disabled ModuleTestData from DisabledTestData. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ide989abae53f5c3f7079f0da4f7305fe41b158a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1991991Reviewed-by:
-
Edward Lemur authored
Remove default value from optional arguments, since they are always passed. In particular, the default value for `out` was a text stream (sys.stdout), but the value passed to `out` is always a binary stream, which is confusing. Get rid of the `err` argument, since it is always sys.stderr, and only used for testing. Change-Id: Ia289e9a97b968a0c802fc2f419397c1e494f713c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986064Reviewed-by:
-
Edward Lemur authored
Change-Id: I544aa85b040544508df8ed16310def982356fbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1949417 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a100ae5fb1cd5a66508d69f9bee7fb69b70b0135 [vpython] Bump asn1crypto to 1.0.1 to fix crash on macOS Catalina (athom@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9247a743105b8d1a5a0e4796cdec8fc4710863e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992106Reviewed-by:
-
- 07 Jan, 2020 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1cbfca1cec9aedcd01cfe190a1569d2f42c8912b Update the attrs dependency to the current version. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic4173c4b07358fdbbeb53ee9d204d44311cda951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987844Reviewed-by:
-
Edward Lesmes authored
This reverts commit cd1331ea. Reason for revert: Original CL was reverted. Original change's description: > Move httplib2 import above third_party. > > 7fd6347b removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest. > > move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix. > > Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Mark Orchard <morchard@google.com> TBR=ehmaldonado@webrtc.org,ehmaldonado@chromium.org,morchard@google.com,apolito@google.com Change-Id: Ic7775cdb4abae1855358711335349fc39eb37dfb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988739Reviewed-by:
-
Andrew Grieve authored
This matches the recent change Chromium's Python style guide. This also changes the .style.yapf in depot_tools to be explicit about the style used in this repo. Bug: 846432 Change-Id: I4947a90aec1739a9a86ffc9bfc5eacc1182dc186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987006Reviewed-by:
-
Mark Orchard authored
7fd6347b removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest. move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix. Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f46d187695175b7a4cd0a76ef58b364890499f2d Minor clean-up of docs (garymm@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0af5598af451814b5c2d700e114522bed577443b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989013Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/bf4885534ce2e5214c7ef1a015296d79bfab6b7b [resultdb] Log output (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iceccf6abb75db28c2155e48d540c0be5d0d6f31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989011Reviewed-by:
-
Dan Field authored
This reverts commit 7fd6347b. Reason for revert: This broke Flutter CI - we're not using vpython everywhere yet Original change's description: > depot_tools: Remove third_party/httplib2. > > depot_tools' scripts have been using vpython httplib2 for a while. > > Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com Change-Id: Ie53a8d07ccfba5a7cc5bcb431d4f7b897f66788a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1989012Reviewed-by:
Dan Field <dnfield@google.com> Commit-Queue: Dan Field <dnfield@google.com>
-
- 06 Jan, 2020 7 commits
-
-
Edward Lemur authored
Change-Id: I3a188b34ae5f62649108afe08fe0e389a408c2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1947933 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Garrett Beaty authored
In repos that are checked out separately from chromium, invoking "git cl format" on a change that has files that would be formatted using clang-format causes an error because the depot_tools version of clang-format looks for a clang-format inside the repo. This prevents using proto-based properties (the preferred mechanism going forward) in recipe repos that enforce formatting. The --no-clang-format flag provides a workaround that can be used to prevent trying to format any files where clang-format doesn't work. Bug: 979330 Change-Id: Ice8561d88b29623deb953465253f92c88aa7fc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1986111 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Garrett Beaty authored
The current behavior of the --no-python flag doesn't disable formatting for python files. Instead, it has the same effect as the --python flag. Change-Id: I26024d3030b9c873180b488d00351676c37c9492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1985785 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Edward Lemur authored
Change-Id: I7a434d4420573c6e5fc014455b011984f4d681b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1952159Reviewed-by:
-
Edward Lemur authored
depot_tools' scripts have been using vpython httplib2 for a while. Change-Id: I9403d92332c74de0ed69d6f59f60c81772d0577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978983Reviewed-by:
-
Dan Beam authored
Bug: 1028829 Change-Id: Iafc40952e402884639543436281e93942c0257a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959813 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d459837f12b4d8d7e032c9b474d9a23f6935ff35 [swarming] Add bot_id property to TaskResult (athom@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3de181cfca521f0ff358362c0af4bd5980ab20b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988192Reviewed-by:
-
- 03 Jan, 2020 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f44ad10ae5127aa3120f4d105db62e080b4af9ec [swarming] Expose swarming task duration (olivernewman@google.com) https://crrev.com/5591fe66be52b94aab70120f5401343521aaa4cc Enable use of 'cipd ensure -max-threads'. (mohrr@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie1cf92f7b93cc207ed253a31c8dfb326104d1d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1987009Reviewed-by:
-
- 20 Dec, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d2fba763e27b1b169856f5eff7135584426967c4 Stop running a ton of tests on upload (maruel@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3578cecbe46d8c03a2208c8c20eb4742a2d21fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1979422Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ef92c00521e4df0b3c0f1d0d1ce5a6a36d58050e [swarming] Document how to use task fallback (maruel@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0ef8225675e4b7cfcc0b385bbb8e040960b53375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1978783Reviewed-by:
-
- 19 Dec, 2019 2 commits
-
-
Edward Lesmes authored
Bug: 1024683 Change-Id: I1c30473699c1bd6b198188b53b632e3617fed335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1929653Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5ed573b5fc71c25e1821f2756d9637ca4eff066e [resultdb] Parse invocation (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I315213908cd6f00cfb9ac8d357963f5147aca143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1974804Reviewed-by:
-
- 17 Dec, 2019 4 commits
-
-
Sarthak Kukreti authored
In python3, dict.keys() returns a view instead of a separate dictionary, which results in the following error while trying to use cpplint: "RuntimeError: dictionary changed size during iteration" Use a list of the keyset instead. R=ehmaldonado@chromium.org Bug: 1027160 Change-Id: I0040b8912d7e446d35d755bb021670c9f2248f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1966743Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
Includes bug fix for handling cache corruption. R=tandrii@chromium.org BUG=1034124 Change-Id: I06e2be15d97522c0a78a97c6ebd202824f8f8c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1972372 Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
Edward Lemur authored
Bug: 642523 Change-Id: I0e52b6a4d7b45af31aa293f69895c3775044a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1971120Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I8fe6e68ab93025b461722fc6ce43274c091902e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1963407 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 13 Dec, 2019 2 commits
-
-
Vadim Shtayura authored
Notable changes: - Bug fix for an edge case of "symlink => dir" replacement. - Ask to login on permission errors. R=tandrii@chromium.org BUG=1031057, 1033987 Change-Id: I60175e79d37cf5425c9b777159bd10d47353f003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1967964 Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ee9e27dca1ca19f086e572a4266ef7d35f5462a8 Whitelist RECIPE_MODULES imports. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifeae30970270145c8ccfd2f6430fdac248e76683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1966416Reviewed-by:
-
