- 01 Jun, 2017 10 commits
-
-
Dan Jacques authored
Second attempt at landing. Fix quotes around python in "gclient.bat". Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I0fceb99c8adb96e72dac706819be032d400aad37 Reviewed-on: https://chromium-review.googlesource.com/521704 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
Daniel Jacques authored
This reverts commit 2f5f0b7a. Reason for revert: <INSERT REASONING HERE> Original change's description: > [.bat] Remove "depot_tools" override. > > Currently, all ".bat" entry points use "~dp0python" to ensure that the > Python that is used to execute the tool is the one in depot_tools. This > prevents any sort of system override. > > Remove this override so that PATH solely determines which Python is > used. To accommodate users who invoked these tools without Python on the > PATH, we still still add "depot_tools" as a catch-all PATH suffix. > > Some tools were also not using DOS-style line endings. This CL fixes > this. > > BUG=chromium:714293, chromium:724902 > TEST=None > > Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 > Reviewed-on: https://chromium-review.googlesource.com/517236 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > TBR=maruel@chromium.org,iannucci@chromium.org,vadimsh@chromium.org,dnj@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:714293, chromium:724902 Change-Id: I822abdd4e02abd32d2f4789fb16d5a7f78fdd02d Reviewed-on: https://chromium-review.googlesource.com/521867Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Dave Tu authored
`parsed_root.path` already contains the leading slash in the the URL, so adding an additional slash gives an incorrect URL. Change-Id: I84f04179356bb132a31531232a5c30c7808f7c1b Reviewed-on: https://chromium-review.googlesource.com/520724Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: David Tu <dtu@chromium.org>
-
Dan Jacques authored
Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 Reviewed-on: https://chromium-review.googlesource.com/517236 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
-
Robert Iannucci authored
R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org Bug: Change-Id: I47d8f9311b6ee71583fb989888a1e4d28b5495df Reviewed-on: https://chromium-review.googlesource.com/520731 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Icb15bcd354c9b524674c6b4496f430c26cf7b89e Reviewed-on: https://chromium-review.googlesource.com/521482Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
John Budorick authored
Bug: 728618 Change-Id: I0706f9c0b6d17e82a77cad95a9264038f594b80d Reviewed-on: https://chromium-review.googlesource.com/521222Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Paweł Hajdan, Jr authored
This is a step towards implementing conditions. Bug: 570091 Change-Id: I99467033082d96021854c23dcff3fc2b56f995b4 Reviewed-on: https://chromium-review.googlesource.com/517107Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d878bba594c81c7ba4cc16b8bf078097b00a102d [recipe_modules/file] add real file module to engine. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0f11eb017b42f090cc49c0c4a325205a2e92e504 Reviewed-on: https://chromium-review.googlesource.com/520644Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8ff178b2ec0c099d49ecb1df1c411f487c6bc657 [context] simplify step context implementation (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9f963c1cdfee1e9ee0a4ecf00a4cd7d9e45dc0d9 Reviewed-on: https://chromium-review.googlesource.com/520783Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 31 May, 2017 9 commits
-
-
Bruce Dawson authored
On recent SDKs the size of the toolchain package grew. This change filters out some unneeded directories in order to minimize this growth. This change also fixes the bin paths for the 10.0.15063.0 SDK. Starting with this SDK version the SDK version is part of the path. The script does *not* handle packaging older SDKs anymore - older versions of the script can be used for that purpose. The 10.0.15063.0 SDK will be needed eventually in order to support Windows 10 Creators Update. Test builds are running on crrev.com/2913873003 (VS 2017) and crrev.com/2914643003 (VS 2015). Bug: 683729,682416 Change-Id: Ia89e3253869a45dd10c923a2edee53aaf086e12c Reviewed-on: https://chromium-review.googlesource.com/519982 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/458ce956c9d91d184e0107c5fa6b34a8267b8e9b [step_runner] run _merge_envs in simulation too. (iannucci@chromium.org) R=martiniss@chromium.org, phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0d60499b06718827776739eb0413a79baa15cd9e Reviewed-on: https://chromium-review.googlesource.com/520462 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Pierre-Antoine Manzagol authored
_CalculateAddedDeps calls into depot tools' scm.py GetOldContents to compare previous and current versions of the DEPS file. GetOldContents attempts to 'git show <sha>:<path>'. The problem on Windows is that path uses '\' but git show seems to want a posix path. Git show therefore doesn't find the file and returns an empty output, leading presubmit to think all the deps are new. Bug:725933 Change-Id: Ifbbfbcba4be466d9be623826818fd191bd2ca525 Reviewed-on: https://chromium-review.googlesource.com/514142 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8d7bd42ec1713294cf6cb36127c96a1f439f9419 Enable unbuffered output for bundled recipes. (benjaminwagner@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I13297698e934ae231178838d2e74e02044646afd Reviewed-on: https://chromium-review.googlesource.com/519824Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Quinten Yearsley authored
This mostly changes simple typos, e.g.: strack->stack assosiated->associated unsettin->unsetting diangose->diagnose desciption->description commment->comment This CL also changes some docstrings and capitalizes some printed messages. Change-Id: I758b47f069a6de2d0d94a76ff85587bdc51c9daf Reviewed-on: https://chromium-review.googlesource.com/519614 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Quinten Yearsley authored
For a bit of context, see the TODO in the code -- I think that the original intent of that TODO was that we to make the way that CQ dry runs are triggered consistent, and also make the behavior of dry runs consistent across different commands. Change-Id: I80dfc31ade302a6af7fa84011e2871d416ea9c96 Reviewed-on: https://chromium-review.googlesource.com/518930 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/84a695b241eb61b3b6d1a0fa9d63ef572d26cdbd [loader] Make recipe engine support examples/ module subdir (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifedefe752fc745708ea367e2a978b5511732d12a Reviewed-on: https://chromium-review.googlesource.com/519683Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Paweł Hajdan, Jr authored
Some recipes interacting with older revisions (e.g. bisect) will need this. Bug: 570091 Change-Id: I38e5ffa2db1a9bfae3667f015f00977c32ebe51e Reviewed-on: https://chromium-review.googlesource.com/519407 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Francois Doray authored
`git cl split` splits a branch into smaller branches and uploads CLs. Change-Id: Ic41cdabdd6241008ff48766e31a8d9d07995f2b0 Reviewed-on: https://chromium-review.googlesource.com/439706 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 30 May, 2017 2 commits
-
-
Bruce Dawson authored
VS 2017 Preview installs to a different directory from VS 2017 RTM, so the packaging script needs to be updated to handle this. It does this by using vswhere.exe so that any VS 2017 install can be found automatically. If there are multiple installs then it is not well defined which one will be found, so make sure you don't have multiple installs. The other change is to more robustly find the many directory paths which contain embedded version numbers. Previously these were hard-coded for VS 2017 RTM but this quickly gets tedious so now glob.glob is used to find the matching directories. This will intentionally fail if there is any ambiguity. R=scottmg@chromium.org BUG=683729 Change-Id: I02f7ae7589e271d6d9897f899e0730d7163f76ef Reviewed-on: https://chromium-review.googlesource.com/516442 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 727685, 570091 Change-Id: I97a99d15930c1662c0ecfacd3755af27b282f686 Reviewed-on: https://chromium-review.googlesource.com/517800Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 29 May, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
This is a follow-up after https://chromium-review.googlesource.com/c/517049/ Bug: 727334, 570091 Change-Id: I49f9ad07f1b79cba547d88e93b2d2064c33e1f4b Reviewed-on: https://chromium-review.googlesource.com/518125Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib3296a201bdcbd4ec350ee0e98112a89e388fd61 Reviewed-on: https://chromium-review.googlesource.com/517049Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509451 Please pass --disable-syntax-validation as an escape hatch. Bug: 570091 Change-Id: Ia9812506347685c31907225837ed50a0510952ee Reviewed-on: https://chromium-review.googlesource.com/517950Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 27 May, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5da7e1fbc1f0e8b14d0ac6c1dc770ce9ca39d6ac Remove "Recipe Roll Downstream Tester" builder (nodir@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I34ed90f4533863c47790b642daf0fb6222f07069 Reviewed-on: https://chromium-review.googlesource.com/517862Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Robert Iannucci authored
TBR=dnj@chromium.org, nodir@chromium.org Bug: Change-Id: I4f1dada9e4aa395e796c93a0a54e0b6899ac6597 Reviewed-on: https://chromium-review.googlesource.com/517235Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Robert Iannucci authored
R=nodir@chromium.org Bug: 662654 Change-Id: I18898cb426ccbb895a82410dc61910a8b8e48f14 Reviewed-on: https://chromium-review.googlesource.com/517664 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
- 25 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This should make error messages more friendly and easier to address. Bug: 570091 Change-Id: Id43d6ecdc5521b07fbe684b6fdbcc09f6fbc6448 Reviewed-on: https://chromium-review.googlesource.com/513907Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 24 May, 2017 2 commits
-
-
Dan Jacques authored
Several boilerplate batch files include a provision to prepend "depot_tools" to PATH prior to running those tools. This undermines the utility of PATH overrides, since these tools specifically force their "depot_tools" sub-paths to be used regardless of environment. The origin of this behavior is likely limited to a specific fix for a specific problem, but was then perpetuated by the copy/paste of boilerplate bootstrap code as more bootstraps were added. This is important in upcoming configurations, where core tools such as Python and Git will be overridden via PATH on the bots. Cygwin users who depended on this behavior should just add "depot_tools" to their PATH in the appropriate location (i.e. in their .bashrc). BUG=chromium:714293, chromium:724902 TEST=None Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537 Reviewed-on: https://chromium-review.googlesource.com/510290 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
If the repo is a btrfs subvolume, take a snapshot instead of using "cp --reflink". Taking a snapshot is much faster, and uses less disk space for metadata. Bug: 721585 Change-Id: I97753dc30d46ff56d84d65f8d815c19d09cf104b Reviewed-on: https://chromium-review.googlesource.com/513586Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
-
- 23 May, 2017 10 commits
-
-
Aaron Gable authored
The private mode is a better fit for how we want private (e.g. security-critical) changes to be reviewed. Draft was simply a placeholder until private was ready for use, which it now is. Bug: 721880, 722627 Change-Id: Ib7b76c555437f4ddc7ab2b0e7ce5a9f9ee8be825 Reviewed-on: https://chromium-review.googlesource.com/513243 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Bonventre <andybons@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
When the repo is copied in copy-on-write mode, print informative messages afterwards to help users. Also, skip "git clean" step in copy-on-write mode. Bug: 721585, 723856 Change-Id: I3235398c960d59a4cf44cfe7dffc79ed008a5190 Reviewed-on: https://chromium-review.googlesource.com/512262Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
-
Paweł Hajdan, Jr authored
- allow None in deps_os values (for chromeos buildspecs) - allow string formatting (%) in expressions (for dart) - allow empty lists/dicts (for build slaves) - allow target_os (for internal android) Bug: 570091, 722206, 725422 Change-Id: I7f3d822a1c4aac16fddd96ef2f9f365e05b2d0e8 Reviewed-on: https://chromium-review.googlesource.com/512724Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
This relands the safe portion of outage-causing https://chromium-review.googlesource.com/c/509451/ Landing this simple CL will allow pre-emptively adding escape hatch to critical places (such as update_scripts) to make relanding validation safer. Bug: 570091 Change-Id: I4d963bd9b140b7b6bca35d4d5e41768bc1a3d7e0 Reviewed-on: https://chromium-review.googlesource.com/512744 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509693 This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I0d83b537b57d0b9ca65c7101d13e0ad6c1642a29 Reviewed-on: https://chromium-review.googlesource.com/512842Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509614 This feature seems to be unused, and removing it will simplify handling hooks a little bit. Bug: 661382 Change-Id: I7f02b34fc399c78bef76420df19a93105ab098ac Reviewed-on: https://chromium-review.googlesource.com/512644Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 568e5919. Reason for revert: maybe caused outage Original change's description: > gclient validate: allow None in deps_os values > > Bug: 722206 > Change-Id: I15024670e481c166ca34a2ec8dac93c739684121 > Reviewed-on: https://chromium-review.googlesource.com/509537 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 722206 Change-Id: Ia0f3825d204e65575020d108873dee82da47a1e6 Reviewed-on: https://chromium-review.googlesource.com/512345Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 3e6d7c1c. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for $matching_files in hooks > > This feature seems to be unused, and removing it will > simplify handling hooks a little bit. > > Bug: 661382 > Change-Id: I89f28dedb7f59cd475b176cfb1f023094520d6b7 > Reviewed-on: https://chromium-review.googlesource.com/509614 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I47fe26e7381682b5b428a3775bf27a551c57d5e6 Reviewed-on: https://chromium-review.googlesource.com/512344Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit bf72b593. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for From() > > This feature appears unused, and removing it will simplify the codebase. > > Bug: 661382 > Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 > Reviewed-on: https://chromium-review.googlesource.com/509693 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I4db9554a0a3a64a3a69908560b6da2a9963518f2 Reviewed-on: https://chromium-review.googlesource.com/512343Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 8db72efd. Reason for revert: maybe caused outage. Original change's description: > gclient: enable syntax validation by default > > Please pass --disable-syntax-validation as an escape hatch. > > Bug: 570091 > Change-Id: Iceadc0d2fc54ca68e775c3bc7590f4329ddb4951 > Reviewed-on: https://chromium-review.googlesource.com/509451 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 570091 Change-Id: I5b91653839f09a29c4c633fba91b23260ba96761 Reviewed-on: https://chromium-review.googlesource.com/512342Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-