Manual roll to pick up crrev.com/28c10d465e3161ec3b862b525c5351ffe9343399.

TBR=dnj@chromium.org
BUG=

Change-Id: Idfcfe80aa9ada7550b6389ac0aaa8d28682d46b7
Reviewed-on: https://chromium-review.googlesource.com/451602Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/928cf06d73113b2b349aaeb0b13d94e30ea3f0e1 [tests] add custom assertion test for whitelist_steps. (iannucci@chromium.org)
  https://crrev.com/22e413ad35481ecd49d232620e7794ce6f544958 [package.proto] add canonical_base_url field. (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I6c369caa4e5d7e68664d1abebb2bde66ab1a9d68
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/451559
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

So that we can roll the cit.py pin without breaking other services.

BUG=

Change-Id: I5992d753d8ddf23c29f1ef6c09866a86c7f7c2ae
Reviewed-on: https://chromium-review.googlesource.com/450760Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/272fea9be6b978a2e4862314ce814e8428518b3b Support realpath in path module (phosek@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I1620bbd3a3bcc6ae07dfabee27cedc3880383bcd
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/451121
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

Previously, if an OWNERS file included //foo/API_OWNERS, then the
code would get confused and think that it had already read and processed
//foo/OWNERS, transferring the contents of the former to the latter.
This was wrong. This change fixes the attribution and adds tests to make
sure we catch this in the future.

R=thakis@chromium.org
BUG=697156

Change-Id: I1f1b846cafac2ad6d792d2dccfce94911e9d15c3
Reviewed-on: https://chromium-review.googlesource.com/447962Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

This CL is a step toward checking for long lines in HTML webui files.
Those files may have long <link ...> lines which should be exempted from
the max line length.

BUG=None

Change-Id: I6fa33c004a58ea599651ae03b814fcdefbc887a1
Reviewed-on: https://chromium-review.googlesource.com/448967Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>

If a constructor is marked constexpr it evades the explicit constructor
check right now, since the check only knows about the inline keyword.
Teach it that constexpr can be used also.

Change-Id: Ia76ddd00b69c5a76a385d22a2b9eb18b690bd8c8
Reviewed-on: https://chromium-review.googlesource.com/445932Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

BUG=697327

Change-Id: Ie220a09f243da08a24520203b622197be27a396b
Reviewed-on: https://chromium-review.googlesource.com/448658Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

Otherwise it can make the log overwhelming when the number of rolls is higher
than the number of meaningful commits.

R=iannucci@chromium.org
BUG=620765

Change-Id: Iec0b41304d50091498d43abc4883e522b8cc9a2c
Reviewed-on: https://chromium-review.googlesource.com/448676
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ea723457b7a1d098594e68ad82f98964dc3d6cfa [step_runner] add logic to resolve absolute path of argv[0] on windows. (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I54bf86b92631aba905aa261a633260b16978fc92
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/448062
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/91d331a98de5bbb709ddda15684059a3e1255088 Mark timeouts as failures (martiniss@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I8b7765072cdf4c6c76e701616383c32f73e4c4a7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/448082
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

BUG=662654

Change-Id: I7019285b085b4a4e22463d0333770e328fda9b6b
Reviewed-on: https://chromium-review.googlesource.com/444282
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5e45bcc6040a453636baccc4063667a87a415b4f [bundle] add mechanism to express precise file dependencies. (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: Ia3357de1596494a25aaf249c962684c88eb6b447
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/447918
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

Currently if you set `pre_deps_hooks` in your gclient DEPS file,
they will be executed regardless of whether your repo was supposed
to be recursed into (via recursionlimit or recursedeps) or not.

This change fixes that so that we only run the hooks that were
explicitly configured to be run.

R=kjellander@chromium.org, agable@chromium.org
BUG=696495

Change-Id: Ic0ef641903cf3f56d7c2e119d8b0db862258d995
Reviewed-on: https://chromium-review.googlesource.com/447318Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

BUG=

Change-Id: Idb463b68c2ce2f42a25f4aadc5482c443d7c2038
Reviewed-on: https://chromium-review.googlesource.com/447240Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f9018a9957d36e4149083cb3a6a0fdca619c9706 Handle environment variables with newlines. (dnj@chromium.org)

TBR=martiniss@chromium.org

Change-Id: Id45bc8da39e7e4c14054be5ad76c28e6c2cb7e4c
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/446407
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

Needed because bad change broke the recipe engine

BUG=696100
TBR=iannucci

Change-Id: Ia8a293a22ead5654313b5bdcdaaf475f41e96519
Reviewed-on: https://chromium-review.googlesource.com/446869Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

BUG=

Change-Id: Ie10ffc40a89070e8e20ad933d6e9fa4fb73673d1
Reviewed-on: https://chromium-review.googlesource.com/446530Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/90e24d410ab511aac5cdf0d20ee216cf488aa379 [environment] Remove environment variable whitelisting. (iannucci@chromium.org)

TBR=martiniss@chromium.org

Change-Id: I3cfe0642bc4803424ea9b022a7cfb9172f0a8d02
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/446537
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

Reverts the changes from https://chromium-review.googlesource.com/c/437710/
It was decided to add the hooks to src/DEPS instead of trying to get
bot-specific hooks to work.

BUG=

Change-Id: I1d995eafc282e7a9b6ab9b4b2805904344943e27
Reviewed-on: https://chromium-review.googlesource.com/446679Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/40a0e58e42217e0d5249897487d6f2a9cf423bc9 remove use_subprocess42 flag for good (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Change-Id: I34ab9ae948095a0a1c1304f531d2bf6a3281d122
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/446536
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/fd54405ae7498eddf828c022f53726a7dca1c9ed Include slavename in properties.legacy() (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Change-Id: Ib00f2ed7f1dff5234a537676f73f606315e29f11
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/446397
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

TBR=sergiyb@chromium.org, dnj@chromium.org
BUG=695038

Change-Id: I1190d31f34f0a6b124533900bf3fdfe98ade0614
Reviewed-on: https://chromium-review.googlesource.com/445931
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

BUG=none

Change-Id: I8cf86841baf56288a3c5565dc7fae897e8789cd3
Reviewed-on: https://chromium-review.googlesource.com/446376Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6729d02ce7ca07c49d47bcc685178cb269873af9 [info] Remove useless info command. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2709133002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8c2660cea6c23f9626ae1065cd1168567ef7497c Provide bot_id property (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2705163004

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9245c2502f9d0333f6653b36829296bedbdcd043 [recipes.py] don't crash when NO overrides are specified :( (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2707173002

BUG=662654
TBR=nodir@chromium.org

Change-Id: Ifbce962d4968af9871ee62862b485dc1cc06cc22
Reviewed-on: https://chromium-review.googlesource.com/445044Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/13039c892fec5a915230fbc8eb744749f0cf03f4 [recipes.py] Enable a single repo's bootstrap script to override engine. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2706293002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2caf59ff4bdd1b0aad8612376263af1f073d2cd3 Update coverage to 4.3.4 (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2706033006

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0583864aaa098dd42dec532d31e0faeb2841170c Remove unused imports and fix some other linter errors. (vadimsh@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2702413002

BUG=

Change-Id: I6bef1c91f1d0025ab7aeaa7add9f788d5b7222c1
Reviewed-on: https://chromium-review.googlesource.com/443424Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/419045652e20cb31a22ef9c761bea91b05df0cbb Enforce strict module coverage (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2700113005

For some reason some of these issues were only detected on
recipe autoroller bot.

TBR=iannucci

BUG=693058

Change-Id: I5d4a1243850a31d5430f2dc07be4a5138551ef82
Reviewed-on: https://chromium-review.googlesource.com/444884Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/fe633673c459d05467e0faeb5baaec2d547a1f37 Fix initial property emission. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2702663003

BUG=635641

Change-Id: I66f669ed45199107643fced174c0cd1b8eaa80ad
Reviewed-on: https://chromium-review.googlesource.com/444449Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

This includes gerrit_cq_ability verifier.

TBR=sergiyb@chromium.org,rmistry@chromium.org
BUG=

Change-Id: Ifdb09bb33dd6a6fc7fdcb592e6bc4a2f8ac474ad
Reviewed-on: https://chromium-review.googlesource.com/444767Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

BUG=689652
R=agable@chromium.org,martiniss@chromium.org

Change-Id: Ib9f5b08f5b31a1519a5f5916042885967a263d88
Reviewed-on: https://chromium-review.googlesource.com/443325Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

Gclient sometimes ignores "unmanaged": "False" in the gclient solution
if --revision <anything> is passed.  This forces gclient to always
treat solutions deps as unmanaged.

BUG=693296

Change-Id: I91d5f4c9377fab0fde23cf15d1475779978820fa
Reviewed-on: https://chromium-review.googlesource.com/444098
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=iannucci

BUG=693058

Change-Id: I82be959933162a99172cc58aba0f62b28b360596
Reviewed-on: https://chromium-review.googlesource.com/444764Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>