Commits · 6cfbbcf467d85de87004733aa421b7fa1bc62e48 · Linshizhi / Chromium_Depot_tools

29 Apr, 2016 7 commits

depot_tools: add dependencies on infra_paths · 6cfbbcf4

phajdan.jr@chromium.org authored Apr 29, 2016

This is a preparation for removal of infra-specific
paths from the recipe engine.

BUG=chromium:605919

Review-Url: https://codereview.chromium.org/1930373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300335 0039d316-1c4b-4281-b951-d872f2087c98

6cfbbcf4

Revert of Implement owners check in presubmit for Gerrit. (patchset #3... · 6996a106

machenbach@chromium.org authored Apr 29, 2016

Revert of Implement owners check in presubmit for Gerrit. (patchset #3 id:40001 of https://codereview.chromium.org/1927773002/ )

Reason for revert:
Breaks presubmit:
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175120/steps/presubmit/logs/stdio

Original issue's description:
> Implement owners check in presubmit for Gerrit.
> 
> R=machenbach@chromium.org,phajdan.jr@chromium.org
> BUG=605563
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300320

TBR=phajdan.jr@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605563

Review-Url: https://codereview.chromium.org/1928343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300326 0039d316-1c4b-4281-b951-d872f2087c98

6996a106

depot_tools: add infra_paths recipe module for infra-specific paths (attempt #2) · c3c12290

phajdan.jr@chromium.org authored Apr 29, 2016

This is different from previous attempt https://codereview.chromium.org/1915463002 .

The change is completely backwards-compatible, and doesn't introduce recipe
expectation changes.

Modules can be switched to depend on infra_paths independently,
without any expectation changes either.

By moving path module's config.py to paths_config.py here, we also guarantee
that the returned results are going to be exactly the same.

Depends on https://codereview.chromium.org/1923363003 .

BUG=chromium:605919

Review-Url: https://codereview.chromium.org/1926033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300324 0039d316-1c4b-4281-b951-d872f2087c98

c3c12290

Roll recipe dependencies (trivial). · 1c378606

recipe-roller@chromium.org authored Apr 29, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/53217bee9af1ac4284df50b3e4e334b770eb0ddb recipe engine: add a hook for initializing recipe module with injected deps (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:605919

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1933093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300322 0039d316-1c4b-4281-b951-d872f2087c98

1c378606

Implement owners check in presubmit for Gerrit. · f48a3751

tandrii@chromium.org authored Apr 29, 2016

R=machenbach@chromium.org,phajdan.jr@chromium.org
BUG=605563

Review-Url: https://codereview.chromium.org/1927773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300320 0039d316-1c4b-4281-b951-d872f2087c98

f48a3751

git-hyper-blame: Fix pagination (uses less if on a TTY). · 63906bac

mgiuca@chromium.org authored Apr 29, 2016

This was broken in r299682 (adding setup_color). git_hyper_blame now
initializes setup_color.

BUG=607771

Review-Url: https://codereview.chromium.org/1930813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300316 0039d316-1c4b-4281-b951-d872f2087c98

63906bac

Subprocess uses shell=True on Windows when launching GN. · 627d9002

bsep@chromium.org authored Apr 29, 2016

BUG=600051

Review-Url: https://codereview.chromium.org/1917863009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300311 0039d316-1c4b-4281-b951-d872f2087c98

627d9002

28 Apr, 2016 12 commits

Roll recipe dependencies (trivial). · ddbc4037

recipe-roller@chromium.org authored Apr 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/1f0b237bd9e097a0b7f15e247ed6a7767f81148d Quiet clone, don't fetch overriden deps. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=586649

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1931933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300309 0039d316-1c4b-4281-b951-d872f2087c98

ddbc4037

Revert of Add ability to override DEPS file in recursedeps. (patchset #1 id:1... · 242de27d

martiniss@chromium.org authored Apr 28, 2016

Revert of Add ability to override DEPS file in recursedeps. (patchset #1 id:1 of https://codereview.chromium.org/1919103003/ )

Reason for revert:
Looks like this broke some bots; see https://build.chromium.org/p/chromium.infra.cron/builders/recipe-autoroller-public/builds/2960

https://build.chromium.org/p/chromium.infra.cron/builders/gsubtreed-luci-py/builds/52912

Original issue's description:
> Add ability to override DEPS file in recursedeps.
> 
> This will allow ANGLE to have a recursible deps-file in their repo instead of
> relying on chromium's DEPS file to specify an accurate dependency for itself.
> 
> R=agable@chromium.org, jmadill@chromium.org
> BUG=
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300293

TBR=agable@chromium.org,dpranke@chromium.org,jmadill@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/1932063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300304 0039d316-1c4b-4281-b951-d872f2087c98

242de27d

Reland of git cl try: don't skip presubmit builders, but set dry_run property. · c68f7b51

tandrii@chromium.org authored Apr 28, 2016

With a fix: actually set dry_run for presubmit, and don't set it for other builders.

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128,594127,591030

Review-Url: https://codereview.chromium.org/1926663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300295 0039d316-1c4b-4281-b951-d872f2087c98

c68f7b51

Add ability to override DEPS file in recursedeps. · c38fd01b

iannucci@chromium.org authored Apr 28, 2016

This will allow ANGLE to have a recursible deps-file in their repo instead of
relying on chromium's DEPS file to specify an accurate dependency for itself.

R=agable@chromium.org, jmadill@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/1919103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300293 0039d316-1c4b-4281-b951-d872f2087c98

c38fd01b

Add Skia to list of can-be-patched projects in chromium checkout. · da3bfae5

rmistry@google.com authored Apr 28, 2016

BUG=

Review-Url: https://codereview.chromium.org/1929993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300287 0039d316-1c4b-4281-b951-d872f2087c98

da3bfae5

Update ninja version in shell script too. · 121126fe

thakis@chromium.org authored Apr 28, 2016

BUG=607268
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1924033004 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300283 0039d316-1c4b-4281-b951-d872f2087c98

121126fe

Update ninja to v1.7.1 on Mac, Linux32, Linux64, Windows. · ce4d6c02

thakis@chromium.org authored Apr 28, 2016

See the bug for how these were built (comment 16 onwards).
See the bug comment 0 also for what's new in this version.

All binaries built by thakis@chromium.org.

The Windows binary is now (as of 1.7.x)  64-bit instead of 32-bit.

BUG=607268
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1925133002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300281 0039d316-1c4b-4281-b951-d872f2087c98

ce4d6c02

Revert of git cl try: don't skip presubmit builders, but set dry_run property.... · 3ea2614b

tandrii@chromium.org authored Apr 28, 2016

Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ )

Reason for revert:
Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/

reverting first, then investigating.

Original issue's description:
> git cl try: don't skip presubmit builders, but set dry_run property.
> 
> R=machenbach@chromium.org,sergiyb@chromium.org
> BUG=601128,594127,591030
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265

TBR=machenbach@chromium.org,sergiyb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601128,594127,591030

Review-Url: https://codereview.chromium.org/1929483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300274 0039d316-1c4b-4281-b951-d872f2087c98

3ea2614b

Roll recipe dependencies (trivial). · 3a929ef0

recipe-roller@chromium.org authored Apr 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/571d980027fd27c602ec16bce9922327f30d5d87 recipe engine: convert path resolving logic to object-oriented style (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:605919

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1922303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300272 0039d316-1c4b-4281-b951-d872f2087c98

3a929ef0

Remove manual check using Rietveld for dry run. · 9dea2ac1

tandrii@chromium.org authored Apr 28, 2016

It's now passed using command line flags.

This depends on https://codereview.chromium.org/1931633002,
which actually uses this command line flag.

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=601128

Review-Url: https://codereview.chromium.org/1929653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300268 0039d316-1c4b-4281-b951-d872f2087c98

9dea2ac1

git cl try: don't skip presubmit builders, but set dry_run property. · c39431ae

tandrii@chromium.org authored Apr 28, 2016

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128,594127,591030

Review-Url: https://codereview.chromium.org/1926663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300265 0039d316-1c4b-4281-b951-d872f2087c98

c39431ae

Add --dry_run to presubmit_support. · 57bafac9

tandrii@chromium.org authored Apr 28, 2016

Also, implement skipping of CheckOwners presumbit canned check. To be used by run_presubmit recipe in build repo in
https://codereview.chromium.org/1931633002

R=sergiyb@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org
BUG=594127

Review-Url: https://codereview.chromium.org/1923623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300262 0039d316-1c4b-4281-b951-d872f2087c98

57bafac9

27 Apr, 2016 4 commits

Update ninja to v1.7.0 on Mac, Linux32, Linux64, Windows. · 2b6ed98e

thakis@chromium.org authored Apr 27, 2016

See the bug for how these were built. See the bug comment 0 also
for what's new in this version.

The linux binaries were built by thestig@chromium.org.
The windows and mac binaries were built by thakis@chromium.org.

The Windows binary is now 64-bit instead of 32-bit.

BUG=607268
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1919773006 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300251 0039d316-1c4b-4281-b951-d872f2087c98

2b6ed98e

Deprecate CheckRietveldTryJobExecution "temporarily fixed" in 2012. · 5f30f2f7

tandrii@chromium.org authored Apr 27, 2016

See https://codereview.chromium.org/8353039/

R=maruel@chromium.org
BUG=605563

Review URL: https://codereview.chromium.org/1917883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300238 0039d316-1c4b-4281-b951-d872f2087c98

5f30f2f7

Pedantic follow up nitfix. · 8c3b442a

tandrii@chromium.org authored Apr 27, 2016

Follow up on https://codereview.chromium.org/1901733003.

R=martiniss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1924643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300236 0039d316-1c4b-4281-b951-d872f2087c98

8c3b442a

Roll recipe dependencies (nontrivial). · b7708093

recipe-roller@chromium.org authored Apr 27, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d9039313202dfb6adaf890674abdd8ee6aec940d recipe engine: remove explicit cwd default in step recipe module (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1926633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300229 0039d316-1c4b-4281-b951-d872f2087c98

b7708093

26 Apr, 2016 12 commits

Revert of Reland of depot_tools: add infra_paths recipe module for... · 25837199

martiniss@chromium.org authored Apr 26, 2016

Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )

Hopefully everything will be back to normal now...

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98

25837199

git_cl: description fetching from code review servers. · 2b55fe30

martiniss@chromium.org authored Apr 26, 2016

BUG=

Review URL: https://codereview.chromium.org/1901733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300207 0039d316-1c4b-4281-b951-d872f2087c98

2b55fe30

Roll recipe_engine to 2f86f02a302172514bf282684e0a4aa18b683e41 · 3407a996

martiniss@chromium.org authored Apr 26, 2016

TBR=phajdan.jr

BUG=606708

Review URL: https://codereview.chromium.org/1921893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300206 0039d316-1c4b-4281-b951-d872f2087c98

3407a996

Reland of depot_tools: add infra_paths recipe module for infra-specific paths... · d34c9060

tandrii@chromium.org authored Apr 26, 2016

Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )

Reason for revert:
re-landing because wrong order of reverts :(

Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
> 
> Reason for revert:
> breaks skia bots :(
> 
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> > 
> > Depends on https://codereview.chromium.org/1906323003
> > 
> > BUG=chromium:605919
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
> 
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1921373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98

d34c9060

Revert of depot_tools: add infra_paths recipe module for infra-specific paths... · 54e0d263

tandrii@chromium.org authored Apr 26, 2016

Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )

Reason for revert:
breaks skia bots :(

Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
> 
> Depends on https://codereview.chromium.org/1906323003
> 
> BUG=chromium:605919
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919

Review URL: https://codereview.chromium.org/1917263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98

54e0d263

GetChangeDescriptionFromGitiles followup: future todo for no gitiles. · c767e3f2

tandrii@chromium.org authored Apr 26, 2016

R=andybons@chromium.org
BUG=603207, 605563

Review URL: https://codereview.chromium.org/1913913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300194 0039d316-1c4b-4281-b951-d872f2087c98

c767e3f2

depot_tools: only add mock infra_paths when test data is enabled · c808c555

phajdan.jr@chromium.org authored Apr 26, 2016

BUG=chromium:605919

Review URL: https://codereview.chromium.org/1917093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300193 0039d316-1c4b-4281-b951-d872f2087c98

c808c555

depot_tools: add test_api to infra_paths recipe module · cf482063

phajdan.jr@chromium.org authored Apr 26, 2016

BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300191 0039d316-1c4b-4281-b951-d872f2087c98

cf482063

Make `git cl description` work for Gerrit · 6d1266ee

scottmg@chromium.org authored Apr 26, 2016

Example change at https://chromium-review.googlesource.com/c/340430/.

R=tandrii@chromium.org
BUG=603207

Review URL: https://codereview.chromium.org/1917473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300188 0039d316-1c4b-4281-b951-d872f2087c98

6d1266ee

Add missing method stub for _GerritCodereviewImpl. · 600b4925

tandrii@chromium.org authored Apr 26, 2016

This should make presubmit happy for oncoming git cl desc for Gerrit:
https://codereview.chromium.org/1917473002/

BUG=603207
TBR=hinoka@chromium.org,scottmg@chromium.org

Review URL: https://codereview.chromium.org/1917933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300186 0039d316-1c4b-4281-b951-d872f2087c98

600b4925

Add Pdfium to list of can-be-patched projects in chromium checkout. · aa71406c

tandrii@chromium.org authored Apr 26, 2016

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1914123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300185 0039d316-1c4b-4281-b951-d872f2087c98

aa71406c

depot_tools: add infra_paths recipe module for infra-specific paths · f30e8728

phajdan.jr@chromium.org authored Apr 26, 2016

Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919

Review URL: https://codereview.chromium.org/1915463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98

f30e8728

25 Apr, 2016 5 commits

Gclient: Don't check if repository is clean if --force is passed in · 3f0dacf0

hinoka@chromium.org authored Apr 25, 2016

Instead just do a git checkout --force, since there are some states that reset cannot fix.

BUG=606420

Review URL: https://codereview.chromium.org/1916973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300176 0039d316-1c4b-4281-b951-d872f2087c98

3f0dacf0

Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of... · 56d0de79

hinoka@chromium.org authored Apr 25, 2016

Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ )

Reason for revert:
Broke presubmit

Original issue's description:
> Make `git cl description` work for Gerrit
> 
> This works in that it actually changes the description, but after
> multiple changes, there's multiple footers added. I'm not sure if they
> should be stripped in setting the description? Or is the problem in
> FetchDescription() where it shouldn't be returning
> 'commit_with_footers', but rather something else?
> 
> Example change at https://chromium-review.googlesource.com/c/340430/.
> 
> R=tandrii@chromium.org
> BUG=603207
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169

TBR=tandrii@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603207

Review URL: https://codereview.chromium.org/1922733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300175 0039d316-1c4b-4281-b951-d872f2087c98

56d0de79

Make `git cl description` work for Gerrit · 4d038b43

scottmg@chromium.org authored Apr 25, 2016

This works in that it actually changes the description, but after
multiple changes, there's multiple footers added. I'm not sure if they
should be stripped in setting the description? Or is the problem in
FetchDescription() where it shouldn't be returning
'commit_with_footers', but rather something else?

Example change at https://chromium-review.googlesource.com/c/340430/.

R=tandrii@chromium.org
BUG=603207

Review URL: https://codereview.chromium.org/1917473002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300169 0039d316-1c4b-4281-b951-d872f2087c98

4d038b43

Revert of Use CLs more consistently instead of branch names (patchset #3... · 04ea846b

tandrii@chromium.org authored Apr 25, 2016

Revert of Use CLs more consistently instead of branch names (patchset #3 id:40001 of https://codereview.chromium.org/1893563002/ )

Reason for revert:
speculative revert.

Original issue's description:
> Use CLs more consistently instead of branch names
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300132

TBR=clemensh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1913923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300167 0039d316-1c4b-4281-b951-d872f2087c98

04ea846b

Add basic Gerrit support for presubmit_support. · 015ebae7

tandrii@chromium.org authored Apr 25, 2016

R=andybons@chromium.org,scottmg@chromium.org
BUG=605563

Review URL: https://codereview.chromium.org/1915153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300164 0039d316-1c4b-4281-b951-d872f2087c98

015ebae7