Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 22 Oct, 2019 1 commit
  3. 20 Aug, 2019 1 commit
    • Mike Frysinger's avatar
      pylint: rework wrapper to use vpython for multiple versions · 53297790
      Mike Frysinger authored 
      This allows people to pin a specific version of pylint when running
it.  The default behavior is unchanged: we run pylint-1.5.6 still
as we've created a vpython wheel in cipd for it.  But for projects
that want to move to a newer version, they can pick any of the new
1.x wrappers.  Having the full set of versions here allows projects
to incrementally move to newer versions as the lint delta between
1.5 & 1.6 tends to be much smaller than 1.5 & 1.9.

We don't include support for the newer 2.x series as those only
support Python 3 which the codebase isn't ready for.

Bug: 866772
Test: `./pylint ...` still works & shows pylint-1.5
Test: `./pylint-1.5 ...` runs the v1.5 version
Test: `./pylint-1.8 ...` runs the v1.8 version
Change-Id: I7c47187493564db81e3eb28c6dbd09e6309ead46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752507Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
      53297790
  5. 06 Aug, 2019 2 commits
  7. 25 Jul, 2019 2 commits
  9. 24 Jul, 2019 1 commit
  11. 18 Jul, 2019 1 commit
  13. 16 Jul, 2019 1 commit
  15. 15 Jul, 2019 1 commit
  17. 14 May, 2019 1 commit
  19. 06 May, 2019 1 commit
  21. 24 Jan, 2019 1 commit
  23. 12 Dec, 2018 1 commit
  25. 20 Aug, 2018 1 commit
  27. 20 Jul, 2018 3 commits
    • Mike Frysinger's avatar
      pylint: reland upgrade to 1.5.6 · 862370c6
      Mike Frysinger authored 
      ** WARNING: please do not revert this CL without checking with vapier@ first ***

We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged.  The
repos checked: depot_tools, src, and build.

Also update its deps along the way:
- Update astroid to 1.4.9.
- Drop now unused logilab.common.
- Import lazy_object_proxy 1.3.1.
- Import wrapt 1.10.11.

This should address the issue where some Chromium bots don't have the
lazy_object_proxy/wrapt python modules installed.  These have optional
C modules that we don't compile either as they have Python fallbacks.

Bug: 863669
Change-Id: Iade0e6d89598e2c836ed647996f43db356c43cd0
Reviewed-on: https://chromium-review.googlesource.com/1145485
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
Reviewed-by: 's avatarJohn Budorick <jbudorick@chromium.org>
      862370c6
    • Ned Nguyen's avatar
      Revert "pylint: upgrade to 1.5.6" · 807abf14
      Ned Nguyen authored 
      This reverts commit 3899f1bc.

Reason for revert: causing PRESUBMIT error on catapult repo 

BUG:chromium:865897

Original change's description:
> pylint: upgrade to 1.5.6
> 
> We disable new warnings that are triggered in depot_tools to pylintrc.
> So the lint output before & after this CL are mostly unchanged.  The
> repos checked: depot_tools, src, and build.
> 
> Also update astroid to 1.4.9 and drop logilab.common as needed.
> 
> Bug: 863669
> Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
> Reviewed-on: https://chromium-review.googlesource.com/1137382
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

TBR=vapier@chromium.org,iannucci@chromium.org,jbudorick@chromium.org

Change-Id: I8ea087123db4e52fdf7ebff8b1ed356fd60a6059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863669
Reviewed-on: https://chromium-review.googlesource.com/1145160Reviewed-by: 's avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
      807abf14
    • Mike Frysinger's avatar
      pylint: upgrade to 1.5.6 · 3899f1bc
      Mike Frysinger authored 
      We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged.  The
repos checked: depot_tools, src, and build.

Also update astroid to 1.4.9 and drop logilab.common as needed.

Bug: 863669
Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
Reviewed-on: https://chromium-review.googlesource.com/1137382Reviewed-by: 's avatarJohn Budorick <jbudorick@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
      3899f1bc
  29. 17 Jul, 2018 1 commit
  31. 20 Jun, 2018 1 commit
  33. 24 May, 2018 1 commit
  35. 22 Nov, 2017 1 commit
  37. 13 Nov, 2017 1 commit
  39. 29 Aug, 2017 1 commit
  41. 29 Jun, 2017 1 commit
  43. 11 May, 2017 1 commit
  45. 15 Mar, 2017 1 commit
    • Aaron Gable's avatar
      Workaround Python Issue 26083 in upload.py · edfd7cd8
      Aaron Gable authored 
      This issue is fixed in Python 2.7.12, but we don't guarantee
that we use that version everywhere. The root issue is that,
on certain platforms (e.g. Mac), the exception indicating that
the underlying command (e.g. 'hg') was not found is too large,
and loading the pickle representing the exception fails.

This CL catches this specific exception and treats it identically
to the OS properly raising a 'command not found' code.

BUG=699173

Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f
Reviewed-on: https://chromium-review.googlesource.com/455537Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      edfd7cd8
  47. 17 Feb, 2017 1 commit
  49. 19 Dec, 2016 1 commit
  51. 28 Nov, 2016 2 commits
  53. 08 Nov, 2016 1 commit
  55. 19 Oct, 2016 1 commit
  57. 19 Sep, 2016 1 commit
  59. 24 Aug, 2016 1 commit
  61. 27 Jun, 2016 1 commit
  63. 22 Jun, 2016 1 commit
  65. 17 Jun, 2016 1 commit
  67. 16 Jun, 2016 2 commits