Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 16 Jun, 2017 2 commits
  3. 15 Jun, 2017 3 commits
  5. 14 Jun, 2017 7 commits
  7. 13 Jun, 2017 9 commits
  9. 12 Jun, 2017 5 commits
  11. 10 Jun, 2017 2 commits
  13. 09 Jun, 2017 5 commits
  15. 08 Jun, 2017 7 commits
    • Dan Jacques's avatar
      Update vpython version. · 433d34c7
      Dan Jacques authored 
      Update the "vpython" CIPD version to pick up schema and runtime
performance changes.

BUG=None
TEST=None
R=iannucci@chromium.org

Change-Id: If0e3c393abb16b8918b5fa16593a8788ef8947ec
Reviewed-on: https://chromium-review.googlesource.com/527608Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>
      433d34c7
    • Dan Jacques's avatar
      Add cleanup dir, use with bot_update. · 59a74ed5
      Dan Jacques authored 
      Currently, "bot_update" relies on a BuildBot cleanup mechanism and, to a
lesser extent, the standard BuildBot directory layout. Both of these are
problematic when projecting it into other circumstances, notably
"remote_run" and LUCI.

Have "bot_update" handle its own cleanup. It will now choose a cleanup
directory within the hierarchy of its checkout, and explicitly purge it
prior to execution if it exists. This enforces its expected behavior in
all circumstances and removes its expectations of the greater checkout
layout.

Export "cleanup_dir" via "infra_paths" to point to "build.dead" when
running on BuildBot builds. Otherwise, it is a default directory which,
on Kitchen, is ephemeral by design.

BUG=chromium:725631
TEST=expectations

Change-Id: I664434c542a25aaa7ff3eac216208a2425730fde
Reviewed-on: https://chromium-review.googlesource.com/528057
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      59a74ed5
    • recipe-roller's avatar
      Roll recipe dependencies (nontrivial). · 459b67de
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/154ef7e5d8f964ef30b1250dd33751582705f6f2 [path] Add concept of a "cleanup" directory. (dnj@chromium.org)


R=dnj@chromium.org, martiniss@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I31787615cfaa6f33deae6c1c0c3d7b748c222d05
Reviewed-on: https://chromium-review.googlesource.com/527503
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
      459b67de
    • Robert Iannucci's avatar
      [infra_paths] remove unused goma_deps_cache. · 027a5424
      Robert Iannucci authored 
      R=dnj@chromium.org

Bug:
Change-Id: I69d2e75a7a6784a611f6e0128f1ba5617f009af2
Reviewed-on: https://chromium-review.googlesource.com/528320Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      027a5424
    • Ryan Tseng's avatar
      Update gsutil pin for download_from_google_storage.py from 4.15 to 4.26 · ce325ac8
      Ryan Tseng authored 
      This picks up about 2 years worth of changes.

Bug:723733
TEST=Ran gclient sync on src.git checkout, worked.
Change-Id: I7021ac62be560bb3ba7b523f0758d56bceeef12a
Reviewed-on: https://chromium-review.googlesource.com/527262Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
      ce325ac8
    • Aaron Gable's avatar
      Make gerrit 'git cl patch' use hard reset by default · 9387b4f0
      Aaron Gable authored 
      This CL changes the way that "git cl patch" behaves for Gerrit changes.

Previously, git-cl-patch behaved just like it did for Rietveld:
make sure you're on a branch, download the diff, apply it on top
of your branch. However, this causes problems with Gerrit. Namely,
when you upload a change to Gerrit, git-cl has to make sure that all
parents of your local change have previously been uploaded as well,
either as other changes or as commits already landed on the target
branch. But the method for "applying a patch" from Gerrit was to
cherry-pick it, and that changes the commit hash. So the resulting
commit would *not* have been uploaded to Gerrit. Thus, the
following routine didn't work with Gerrit:
$ git checkout -t origin/master -b your-work
$ git cl patch 123456
$ git checkout -tb my-work
$ #hack and commit
$ git cl upload
This would fail during the upload with a message saying that the
contents of 'your-work' hadn't been uploaded.

This CL fixes the situation by replacing the cherry-pick with
a hard reset. This means that the contents of the 'your-work'
branch will be *exactly* what was downloaded from Gerrit. Uploads
based on top of that commit will work just fine.

Finally, in a concession to some people who want 'git cl patch'
to actually apply a patch instead of performing a hard reset, if
the current branch contains local work, then rather than leaving
that work behind with a hard reset, we fall back to the old
cherry-pick behavior with a confirmation dialog and warning that
uploading will be hard.

Bug: 723787
Change-Id: I3ad164f6d3078bff00139d446bb8ce97738a1344
Reviewed-on: https://chromium-review.googlesource.com/527345
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      9387b4f0
    • Aaron Gable's avatar
      Use whole --message argument on patchset upload · 7303dcb9
      Aaron Gable authored 
      The logic for handling --title, --message, and the
commit message of the most recent commit was accidentally
doing this differently from how Rietveld had done them.

Bug: 728391
Change-Id: I70a46ccb470d790103f5d6bb745902595be28eee
Reviewed-on: https://chromium-review.googlesource.com/527339
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      7303dcb9