basic.sh expects "work: None", but "work: " is printed instead, which breaks
presubmit.  This fixes it.

BUG=
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/17763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208799 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org, cmp@chromium.org
BUG=254556

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208782 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/17644004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208574 0039d316-1c4b-4281-b951-d872f2087c98

It appears to be parsed and ignored, seems like a bug to me.

BUG=None
TEST=local/manual.

Review URL: https://chromiumcodereview.appspot.com/17265012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207404 0039d316-1c4b-4281-b951-d872f2087c98

This will speed up main waterfall sync.  We can
remove this hack tomorrow if svn load is still OK.

TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/17468009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207277 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17274009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207253 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/17379008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207048 0039d316-1c4b-4281-b951-d872f2087c98

Look for either a unique prefix or for an approximation of the shortest
Levenshtein distance. So all of these will resolve to 'git cl upload':
  git cl upl
  git cl uplaod

These won't resolve:
  git cl up     # it shares prefix with 'upstream'
  git cl uplao  # not similar enough

Also align help against longest command instead of hard coded '10'. The help
page was distorded.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/17272002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@206820 0039d316-1c4b-4281-b951-d872f2087c98

This pulls r1084 from the chromium on upstream rietveld.

R=jparent@chromium.org, maruel@chromium.org
BUG=247791

Review URL: https://chromiumcodereview.appspot.com/16744006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@206743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248384

Review URL: https://chromiumcodereview.appspot.com/16763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205692 0039d316-1c4b-4281-b951-d872f2087c98

src/base/hash_tables.h has moved to src/base/containers/hash_tables.h in r205241.

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16787005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205662 0039d316-1c4b-4281-b951-d872f2087c98

I have a large rename change and it's impossible to upload because the size of the CC field is above the maximum 2000 characters in Reitveld.

Review URL: https://chromiumcodereview.appspot.com/16366008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205323 0039d316-1c4b-4281-b951-d872f2087c98

If (hypothetically) you pointed your WebKit repo environment variable to
Blink and not WebKit, then the change_re will not find anything in the
log and the script will explode on changes[0] because changes=[].

Fix this by being robust to not being able to parse anything out of the
log in process_git_commits.

R=szager@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16258010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205290 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_support: Call git once per change, to get a diff for all files. Parse this result to generate per-file diffs, which go into a cache that's shared between the AffectedFile instances.

Greatly improves presubmit performance on Blink where there may be rule violations (my test case went from 50s to 5s).

BUG=236206
TEST=new test in presubmit_unittest.py; manual performance test on Mac and Windows after touching hundreds of files in webkit; testing included add/move/edit/delete on both binary and text files.

Review URL: https://chromiumcodereview.appspot.com/15898005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205275 0039d316-1c4b-4281-b951-d872f2087c98

> Default to using --3way when using `git cl patch`.
> 
> Resolving conflicts is much more fun this way.
> 
> BUG=None
> TEST=Ran `git cl patch <issue>` with both clean and unclean patches, also checked behaviour of --reject is preserved.
> R=maruel@chromium.org
> 
> Review URL: https://codereview.chromium.org/16211005

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/15786008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204978 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15864011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204686 0039d316-1c4b-4281-b951-d872f2087c98

Resolving conflicts is much more fun this way.

BUG=None
TEST=Ran `git cl patch <issue>` with both clean and unclean patches, also checked behaviour of --reject is preserved.
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/16211005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=laforge@chromium.org, kerz

Review URL: https://codereview.chromium.org/16557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204668 0039d316-1c4b-4281-b951-d872f2087c98

Suppress alt_urls when a drover.properties file is present (otherwise it breaks branch reverts for Blink, etc...)

TBR=kerz

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204545 0039d316-1c4b-4281-b951-d872f2087c98

                                                                                 
See the bug for how these were built.                                            
                                                                                 
The linux binaries were built by thestig@chromium.org.                           
The windows binary was built by scottmg@chromium.org.                            
The mac binary was built by thakis@chromium.org                                  
                                                                                 
This contains fixes for http://crbug.com/245034 and http://crbug.com/242397      
                                                                                 
BUG=242397,245034,246734
TBR=scottmg



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204049 0039d316-1c4b-4281-b951-d872f2087c98

When a developer runs download_from_google_storage, and they don't have a .boto
file, the tool automatically runs "gsutil config" to create one for them.
Unfortunately, a side consequence is that if a bot runs the script, and it has
a boto file that 403's, then it would run "gsutil config" which moves the .boto
to .boto.bak, and creates an empty .boto file.  This should not be the intended
action.

This CL changes so that "gsutil config" is not called, but instead just fails
with a message telling the dev to run that command.

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/16072023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203824 0039d316-1c4b-4281-b951-d872f2087c98

.search() may return results in unexpected order. Manually sort the entries
otherwise first_day and last_day could be inversed, leading to negative number
of days.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/16003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203792 0039d316-1c4b-4281-b951-d872f2087c98

If ~/.gitconfig contains:
	[diff]
		renames = "true"
then git diff --name-status will produce output that confuses the parsing
in svm.GIT.CaptureStatus and git diff will produce output that confuses the
patch command on trybots.  Passing --no-renames explicitly counteracts this.

Review URL: https://chromiumcodereview.appspot.com/16057018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203778 0039d316-1c4b-4281-b951-d872f2087c98

76 columns is fine for most patches but reverts will eat another
4 spaces in indentation. For the sake of revert clarity this reference
line is reduced to 72 columns.

Review URL: https://chromiumcodereview.appspot.com/16152005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237388

Review URL: https://chromiumcodereview.appspot.com/14583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203384 0039d316-1c4b-4281-b951-d872f2087c98

Adds an extra line to the default text description to help judge whether the
76 character recommended limit is being passed.

Review URL: https://chromiumcodereview.appspot.com/15670012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203314 0039d316-1c4b-4281-b951-d872f2087c98

This is ninja at 4df15104d532ad91b7a9d3c54985180a6c2f2533.

Changes since 1.3.3 include that affect this Windows build:
- fixing '-t msvc' to stop lowercasing paths from /showIncludes output
- fix a crash in tool target suggestions
- error checking on -j.

This version is newer than 1.3.3 but --version will say 1.3.0git. Other
platforms are staying at 1.3.3. All platforms will re-converge at 1.4.0.

R=thakis@chromium.org
BUG=242397

Review URL: https://codereview.chromium.org/16232002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203165 0039d316-1c4b-4281-b951-d872f2087c98

R=digit@chromium.org, maruel@chromium.org
BUG=244602

Review URL: https://chromiumcodereview.appspot.com/16007008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202879 0039d316-1c4b-4281-b951-d872f2087c98

TEST=tests/git_cl_test.py

Review URL: https://chromiumcodereview.appspot.com/15650014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202865 0039d316-1c4b-4281-b951-d872f2087c98

git_cl.py script.  See http://goo.gl/JGg0Z for details.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/14793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202864 0039d316-1c4b-4281-b951-d872f2087c98

Also adds msg to assertions to print current size of data written to stdout.

Review URL: https://chromiumcodereview.appspot.com/16058007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235289
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/15792004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242220

Review URL: https://codereview.chromium.org/15367008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201859 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org
BUG=239665

Review URL: https://chromiumcodereview.appspot.com/15665002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201438 0039d316-1c4b-4281-b951-d872f2087c98

._Capture throws exception on non-zero status, switch to
subprocess2 capture method. Switch magic value to dontswitchurl.

BUG=241907
R=dpranke@chromium.org, maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15325003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201397 0039d316-1c4b-4281-b951-d872f2087c98

As noticed in the TODO, raw_input (used by ask_for_data) works badly
on background threads. On my Windows it doesn't even print the prompt which
makes it hard to interact with it.

Better to just abort and tell the user of gclient how to proceed.

BUG=

Review URL: https://chromiumcodereview.appspot.com/15421005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201295 0039d316-1c4b-4281-b951-d872f2087c98

cflags and ldflags.



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201145 0039d316-1c4b-4281-b951-d872f2087c98

On mac, I ran: 
git checkout v1.3.3 
./bootstrap.py 
CXX=path/to/chromiums/clang++ ./configure --with-gtest=path/to/gtest 
./ninja ninja_test 
./ninja_test # all passed 
strip ninja 

Empty build perf is ~7% slower (https://github.com/martine/ninja/issues/544), 
but this allows us to enable deps mode by default which will make empty builds 
twice as fast. 

Mac binary size grew by ~16kB. 

The linux binaries were built by thestig@chromium.org. 
The windows binary was built by scottmg@chromium.org. 

New stuff since 1.1: 
- NINJA_STATUS now allows %e, for elapsed time. 
- "pool" feature 
- "compdb" tool for writing clang compilation databases 
- faster deps mode (needs to be explicitly enabled in gyp, not done yet) 

BUG=241628
Review URL: https://codereview.chromium.org/15490003



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201143 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/15302014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201094 0039d316-1c4b-4281-b951-d872f2087c98

Regular map is preferred when parallization does
not speed presubmit tests.  It makes stacktraces more
understandable and facilitates debugging.  Only use
parallel pool when tests > 1.

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15385002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200940 0039d316-1c4b-4281-b951-d872f2087c98