Commits · 4ee32ce4cbab9f81f14109a108507bbca3d0e707 · Linshizhi / Chromium_Depot_tools

02 Mar, 2022 3 commits

[ninjalog uploader] Collect more android GN args · 4ee32ce4

Peter Wen authored Mar 02, 2022

Chrome on Android is going to use android_static_analysis to control
how static analysis runs (values can be: on, off, or build_server). This
arg matters a great deal for build performance.

Bug: 1202732
Change-Id: I0f7437452605f59c9bd01ff75aba56274f115a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3427859
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

4ee32ce4

Update gsutil to use gsutil version 5.6, python3 · c0af61c8

Josip Sokcevic authored Mar 02, 2022

R=gavinmak@google.com

Bug: 1184108
Change-Id: I933c07132006b731a97153080ebe86ed756fbdb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497998Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

c0af61c8

Roll recipe dependencies (trivial). · 1c22c511

recipe-roller authored Mar 02, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820831401628335073

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7b42800366a15f34b28e62f6bcb1cddcb2206db0
  7b42800 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9274082f771a to be2264bd5c01

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6cfff0dffecfc1c0fac21c3076a42bbd19a94537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3499872
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c22c511

01 Mar, 2022 2 commits

[bb-wrapper]: Roll led to a new version · a255e406

Suma Kasa authored Mar 01, 2022

Bug: 1294079
Change-Id: I23552a6e5f3bc60a8007df3cc6611fe0bdf45f41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3475651Reviewed-by: Yulan Lin <yulanlin@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Suma Kasa <sumakasa@google.com>

a255e406

Roll recipe dependencies (trivial). · ca9706d1

recipe-roller authored Mar 01, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820930807246912801

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/701c7805dd0669778ce5cd34c195dfeea2a95de6
  701c780 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 11415c119300 to a1616e207f0d

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0fc0a4702748dc0a5eb30941999392f484137c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495641
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ca9706d1

28 Feb, 2022 5 commits

Roll recipe dependencies (trivial). · 2bad9f0b

recipe-roller authored Feb 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820947794305645857

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e13ab64b39f65711496bfcae73c6a7c10c9b977a
  e13ab64 (yiwzhang@google.com)
      cv: populate new reusability field

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I931d948c8a13b3ad4839fdfb514b157555b62034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495874
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2bad9f0b

Roll recipe dependencies (trivial). · a225f71f

recipe-roller authored Feb 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820949050774962417

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/26c1cf8a623d5cf10f3bafeb2820e401c302d005
  26c1cf8 (yiwzhang@google.com)
      update.py: add back cv/api/v0 and common/bq/pb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67d1335b196934006f0d308bef9fde24ab3b1001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495873
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a225f71f

Roll recipe dependencies (trivial). · c9a747c5

recipe-roller authored Feb 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820960375580647601

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/51fe0724fb1565a0449c32e5081d58d6152a0b0d
  51fe072 (yiwzhang@google.com)
      roll go.chromium.org proto to the latest

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2b5bae533440bf5a2f140e1e9639e617dd748f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495862
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c9a747c5

Roll recipe dependencies (trivial). · 708bc660

recipe-roller authored Feb 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8820963522322370369

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/55716175cf920994bbcaea30fc782f3780442409
  5571617 (yiwzhang@google.com)
      fix update.py that imports proto

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia0c5a17df516c0333fe134dc4ce051cea0cc3b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495563
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

708bc660

Reland "Reland "Add support for Gerrit topics in gclient syncs"" · ecda7828

Ravi Mistry authored Feb 28, 2022

This is a reland of fc9a40e3

Hopefully the cause of the 2nd revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3489327

Original change's description:
> Reland "Add support for Gerrit topics in gclient syncs"
>
> This is a reland of 0f13273f
>
> Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835
>
> Original change's description:
> > Add support for Gerrit topics in gclient syncs
> >
> >
> > If the new flag "--download-topics" is specified with a "--patch-ref" then:
> > * Finds the topic of the Gerrit change.
> > * Finds all open changes in the same repo as the Gerrit change.
> > * Cherrypicks all changes locally.
> >
> > This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics).
> >
> >
> > Tested by:
> >
> > * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory.
> >
> > * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout.
> >
> >
> > Bug: chromium:1298922
> > Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@chromium.org>
>
> Bug: chromium:1298922
> Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Ravi Mistry <rmistry@chromium.org>

Bug: chromium:1298922
Change-Id: I21d7251bafff808b1144d6e522fa9f384f4541bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3490488Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

ecda7828

24 Feb, 2022 7 commits

Replace python3 with vpython in bot_update/api.py · 6b28c1dd

Ravi Mistry authored Feb 24, 2022

For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: chromium:1298922
Change-Id: I23eaec3c104c7b52653732b6fd9d58d175d78069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3489327Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

6b28c1dd

Handle no changed content in presubmit support · c1ab7349

Josip Sokcevic authored Feb 24, 2022

git cl presubmit has --all option which marks all files as modified.
However, that doesn't work well with SCM diff. That is, git diff may not
contain affected file. Instead of throwing an exception in such case,
just return no diff.

R=gavinmak@google.com

Fixed: 808346
Change-Id: Ie1d534b8eebc84bc5206eba7db8057829390fbec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3485501
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

c1ab7349

Revert "Reland "Add support for Gerrit topics in gclient syncs"" · 368f980b

Josip Sokcevic authored Feb 24, 2022

This reverts commit fc9a40e3.

Reason for revert: at least one tryjob if failing:
Gerrit Plugins Tester

Original change's description:
> Reland "Add support for Gerrit topics in gclient syncs"
>
> This is a reland of 0f13273f
>
> Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835
>
> Original change's description:
> > Add support for Gerrit topics in gclient syncs
> >
> >
> > If the new flag "--download-topics" is specified with a "--patch-ref" then:
> > * Finds the topic of the Gerrit change.
> > * Finds all open changes in the same repo as the Gerrit change.
> > * Cherrypicks all changes locally.
> >
> > This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics).
> >
> >
> > Tested by:
> >
> > * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory.
> >
> > * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout.
> >
> >
> > Bug: chromium:1298922
> > Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@chromium.org>
>
> Bug: chromium:1298922
> Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Ravi Mistry <rmistry@chromium.org>

Bug: chromium:1298922
Change-Id: I845321941157ab55d026488b7ce59787ba5e57f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3488245
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

368f980b

Reland "Add support for Gerrit topics in gclient syncs" · fc9a40e3

Ravi Mistry authored Feb 24, 2022

This is a reland of 0f13273f

Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835

Original change's description:
> Add support for Gerrit topics in gclient syncs
>
>
> If the new flag "--download-topics" is specified with a "--patch-ref" then:
> * Finds the topic of the Gerrit change.
> * Finds all open changes in the same repo as the Gerrit change.
> * Cherrypicks all changes locally.
>
> This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics).
>
>
> Tested by:
>
> * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory.
>
> * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout.
>
>
> Bug: chromium:1298922
> Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Ravi Mistry <rmistry@chromium.org>

Bug: chromium:1298922
Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

fc9a40e3

Roll recipe dependencies (trivial). · 2c668c86

recipe-roller authored Feb 24, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8821375613269346385

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b81a11283cb14ace0699e8f1dea768b8f5304f7c
  b81a112 (bryner@google.com)
      Bump versions of wheels affected by crbug/1297798.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I864a9747ce5a3abb6c9a4e50c21c390d9c33160e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3486524
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2c668c86

Roll recipe dependencies (trivial). · 92f871a6

recipe-roller authored Feb 24, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8821386937728323985

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7460e9239c140f8d426c9e99401031af3d65fdf1
  7460e92 (chanli@chromium.org)
      [buildbucket module] return the canceled step failure if recipe...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id569e6092484f6a46fdc3a90d70fd8b4b9fb236a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3486517
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

92f871a6

Support multiple VS installations · 36d41cef

Chris Blume authored Feb 24, 2022

Currently, package_from_installed.py assumes only one version of VS is
installed. It takes the path of the first installation.

This could be incorrect in several ways:
- Maybe both 2017 and 2019 (the supported versions) are installed and
  although the user specified using 2019, the 2017 path comes first.
- Maybe 2019 and 2022 are installed, and the 2022 path is used even
  though it isn't supported.

This CL fixes that issue by parsing the vswhere.exe output to confirm
the VS version matches what the user specified, using its corresponding
path.

Change-Id: I2029a4f7126d0a45b5370ad58ab257df55571b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Auto-Submit: Chris Blume <cblume@chromium.org>

36d41cef

23 Feb, 2022 3 commits

Run upload_to_google_storage.py with Python 3 · 99000ea7

David Benjamin authored Feb 23, 2022

Change-Id: I7271280deb09c9675567f3dd255e809da19619b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484977
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

99000ea7

Collect metrics on git_map_branches · 306b03b1

Josip Sokcevic authored Feb 23, 2022

R=calamity@chromium.org

Change-Id: Iee4634462c598685032c8a5ffcfd3b9766726958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3482664
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Christopher Lam <calamity@chromium.org>
Commit-Queue: Christopher Lam <calamity@chromium.org>

306b03b1

Indicate py3 compatibility for update_depot_tools_toggle.py · 64f5f26f

Alexander Schulze authored Feb 23, 2022

This file is used by a few dependent projects. Highlighting py3
compatiblity eases the migration process for those projects.

This CL additionally adds executation permissions to the file and
includes the script in the docs.

Bug: 1298903
Change-Id: I5838fedcef181ee5e3eb84a1fa16b649250460ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3479854
Auto-Submit: Alexander Schulze <alexschulze@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

64f5f26f

22 Feb, 2022 1 commit

Replace python3 with vpython3 in gclient/api.py · 32645dfe

Ravi Mistry authored Feb 22, 2022

For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: chromium:1298922
Change-Id: Id424cec27ca64ac0c2e746d54edf044820915cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

32645dfe

21 Feb, 2022 1 commit

Update to fixed vpython wheels. · 42cf2acb

Brian Ryner authored Feb 21, 2022

The previous version was built against a different MSVC runtime than
the Python interpreter on Windows, which is unsafe on Python 2.7.

Note that this will now use a pure-Python implementation of crcmod
on Windows, since there is no packaged wheel available (only an msi,
which we don't currently support repackaging).

Bug: 1297798
Change-Id: I91e4f58cf2b994280c1620fec86dd8638d8a78ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3474820
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

42cf2acb

20 Feb, 2022 1 commit

Adjust variable names to match style guide · 0cfa90e2

Chris Blume authored Feb 20, 2022

Currently, several non-consts are named as if they are const. The style
guide has a naming convention that fits these more accurately.

This CL changes the names to match the style guide.

Change-Id: Ib3425b76208e853b9049abe0e1be40e179124c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3472135Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Auto-Submit: Chris Blume <cblume@chromium.org>

0cfa90e2

19 Feb, 2022 1 commit

Replace hard-coded '\\' with os.path.sep · d6d7a050

Chris Blume authored Feb 19, 2022

Currently, the Windows-specific path separated is hard-coded in many locations.

This CL replaces several of them with os.path.sep to be less fragile.

Change-Id: Ib8ffca5743254949808a6b67e4915f8f01e044e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3470977
Auto-Submit: Chris Blume <cblume@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

d6d7a050

18 Feb, 2022 6 commits

Remove unused third_party coverage library · f72b1baf

Josip Sokcevic authored Feb 18, 2022

Change-Id: If3928511fa5d9d231f6e828bd50708c066721071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3359092Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

f72b1baf

Revert "New vpython in depot_tools" · 3bcbfcd8

Chenlin Fan authored Feb 18, 2022

This reverts commit d6a3040b.

Reason for revert: crbug/1298289

Original change's description:
> New vpython in depot_tools
>
> This change includes commits:
> ef44f81748a55c3aaf028ccfa2ee11876cee1285 Fix vpython filelock
> 275c4196540e1ca41384031b292ad0b89393a5dc Revert "Fix vpython filelock"
> 8aadd8b60a6d3801f62c7e5cebdfe3dc828a1546 Fix vpython filelock
> 43c99d88a24870240c9ca50d67dcfade40b516cc Use resolved path when searching spec
> ffda9381bc01fd33e3c5a889e2ed374312c64ec6 Don't eval python symbol link on windows
> 30a66930f4037fff949d36c45b12f60a40ec524b Include GOARCH to verify cached environment
> 748dcd23529b6b138424914f1e6e265ed70d377b [vpython] Add period to log
>
> Bug:1279621,1158462,1278132,1279684
> Change-Id: I9f7853609309331a5e45939feef906798e7b3a2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3461263
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Chenlin Fan <fancl@chromium.org>

Bug: 1279621,1158462,1278132,1279684
Change-Id: I31c3ca9985c3596317152412b522c1209a36419b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3474811Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

3bcbfcd8

Correct trailing path separator · b3c6512b

Chris Blume authored Feb 18, 2022

In [1], I landed a change that contained a bug. It meant to trim off a
trailing path separator. Instead of trimming the end, it trimmed
everything but the first char (since the path separator is 1 char long).

This CL fixes that bug.

[1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3451982

Change-Id: Ie4aebfc1042908437bd603da1c20681f19c50f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3473285
Auto-Submit: Chris Blume <cblume@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

b3c6512b

Revert "Add support for Gerrit topics in gclient syncs" · 63343b07

Josip Sokcevic authored Feb 18, 2022

This reverts commit 0f13273f.

Reason for revert: breaks codesearch recipes and autorollers

crbug.com/1298961

Original change's description:
> Add support for Gerrit topics in gclient syncs
>
>
> If the new flag "--download-topics" is specified with a "--patch-ref" then:
> * Finds the topic of the Gerrit change.
> * Finds all open changes in the same repo as the Gerrit change.
> * Cherrypicks all changes locally.
>
> This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics).
>
>
> Tested by:
>
> * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory.
>
> * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout.
>
>
> Bug: chromium:1298922
> Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Ravi Mistry <rmistry@chromium.org>

Bug: chromium:1298922
Bug: chromium:1298961
Change-Id: I88c56cd68372bad09b612de7de1a45f9a0c6c681
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3474793
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

63343b07

Revert "Update diff_deps receipe to py3" · e313ab06

Chidera Olibie authored Feb 18, 2022

This reverts commit 988c0af5.

Reason for revert:
This change breaks our bot: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8821937225081267713/+/u/cleanup_index.lock/stdout.

The reference for the newly added cleanup.py looks incorrect.

Original change's description:
> Update diff_deps receipe to py3
>
> Recipe-Nontrivial-Roll: build
> Bug: 1289280
> Change-Id: Ia87693ab8187acc5fa5cbd76664b999ad65d2809
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3438326
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 1289280
Change-Id: I8d430a29abafafe2501c73b2b20063c2a134024d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3473364
Auto-Submit: Chidera Olibie <colibie@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

e313ab06

Add support for Gerrit topics in gclient syncs · 0f13273f

Ravi Mistry authored Feb 18, 2022


If the new flag "--download-topics" is specified with a "--patch-ref" then:
* Finds the topic of the Gerrit change.
* Finds all open changes in the same repo as the Gerrit change.
* Cherrypicks all changes locally.

This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics).


Tested by:

* Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory.

* Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout.


Bug: chromium:1298922
Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>

0f13273f

17 Feb, 2022 4 commits

Update diff_deps receipe to py3 · 988c0af5

Aravind Vasudevan authored Feb 17, 2022

Recipe-Nontrivial-Roll: build
Bug: 1289280
Change-Id: Ia87693ab8187acc5fa5cbd76664b999ad65d2809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3438326Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

988c0af5

Replace hard-coded Windows SDK path · 1ba41357

Chris Blume authored Feb 17, 2022

Currently, the Windows SDK path is hard-coded. This does not work if the
SDK is installed in a different path or drive.

This CL fetches the actual Windows SDK path and uses it instead.

Change-Id: I31808ba0dbe76f47253fc165ccbd8f027bf396ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3451982Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Auto-Submit: Chris Blume <cblume@chromium.org>

1ba41357

Roll recipe dependencies (trivial). · 234398a1

recipe-roller authored Feb 17, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8822007905293956737

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/39398f79e7ab5fae2323cf3c49b9d4c7a5cdad43
  39398f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 14e69ed24c5f to 582e828c5a8a

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43ccc95113e31055d898e8fa0b041a05f825f1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3471036
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

234398a1

Roll recipe dependencies (trivial). · 9a0d4fe7

recipe-roller authored Feb 17, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8822022375736993361

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2abc02b277331f01e37e47ce3f2f479d819127af
  2abc02b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5cf7456331ac to b32c149b6abb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0f54ac1b2b4a62f824abfbbad52fadafcf2698df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3470196
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9a0d4fe7

16 Feb, 2022 1 commit

Support py3 in post upload presubmit hooks · e293d3dc

Josip Sokcevic authored Feb 16, 2022

Currently, post upload presubmit hooks are exlusively executed with py2,
regardless of USE_PYTHON3 magic variable. This change adds py3 support
in the same fasion as regular presubmit hooks.

R=aravindvasudev@google.com

Fixed: 1297712
Change-Id: Ib464f8563e4135a63fc48692d27c8692fe1f630b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3469285Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

e293d3dc

15 Feb, 2022 5 commits

New vpython in depot_tools · d6a3040b

Chenlin Fan authored Feb 15, 2022

This change includes commits:
ef44f81748a55c3aaf028ccfa2ee11876cee1285 Fix vpython filelock
275c4196540e1ca41384031b292ad0b89393a5dc Revert "Fix vpython filelock"
8aadd8b60a6d3801f62c7e5cebdfe3dc828a1546 Fix vpython filelock
43c99d88a24870240c9ca50d67dcfade40b516cc Use resolved path when searching spec
ffda9381bc01fd33e3c5a889e2ed374312c64ec6 Don't eval python symbol link on windows
30a66930f4037fff949d36c45b12f60a40ec524b Include GOARCH to verify cached environment
748dcd23529b6b138424914f1e6e265ed70d377b [vpython] Add period to log

Bug:1279621,1158462,1278132,1279684
Change-Id: I9f7853609309331a5e45939feef906798e7b3a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3461263Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Chenlin Fan <fancl@chromium.org>

d6a3040b

Add fetch hook for ANGLE. · 9e3b7a97

Jamie Madill authored Feb 15, 2022

Bug: angleproject:7018
Change-Id: I0e685c81a43d247b4f1a0dd93850b30b829ef264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3461421Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9e3b7a97

Bump git version for Windows fix. · 553cc045

Brian Ryner authored Feb 15, 2022

Bug: 1297167
Change-Id: Ifc541f05218b0a696b3e19523664a773f415ce1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3461262
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

553cc045

Roll recipe dependencies (trivial). · f72361d3

recipe-roller authored Feb 15, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8822189725625480049

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/07233a2d117b89ab77ae01f16707c293c2c7f7ec
  07233a2 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e920c6c940f2 to c4791d15e395

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd103618efef6e2dc58680660180791a2874293d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3463215
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f72361d3

Roll out goma client VERSION=242 · 4d789841

Fumitoshi Ukai authored Feb 15, 2022

Bug: b/218220880
Change-Id: I059ca9cbee506d6a087b554f4bc14ea2b956f4bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3462783Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

4d789841