Commits · 4a39f37e488731ba7a748e8e78c8a7deb35d4692 · Linshizhi / Chromium_Depot_tools

22 Apr, 2020 3 commits

Roll recipe dependencies (trivial). · 4a39f37e

recipe-roller authored Apr 22, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/096f05fa40b6864c8d22e6df8e154e43d7c778c6 (jsca@google.com)
Add milo recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c91f04e85e69605beb6df1a5da91e33041f48a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160407Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4a39f37e

Roll recipe dependencies (trivial). · 8bd9179c

recipe-roller authored Apr 22, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/940d2483cca29dba541c42f1bdb6d33745269e97 (yekuang@google.com)
Roll swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia332e0d33da35942374efdd379dd2bd9eba361c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160214Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8bd9179c

Skip sources downloaded by WinDbg when checking toolchain status. · 0e7788d1

Dale Curtis authored Apr 22, 2020

This avoids the toolchain being wiped after using WinDbg.

Bug: None
Change-Id: I989ef7744b46254bab4c5a707724dc38a9b9a548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159998
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

0e7788d1

21 Apr, 2020 2 commits

Roll recipe dependencies (trivial). · 1e113e60

recipe-roller authored Apr 21, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/19949b53d1682935c77c39354dd6b3b0056bdd24 (chanli@chromium.org)
    [Resultdb] Add function `exonerate` in resultdb recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefe2a6f510e5be4c84a6515b0afffdc2b7a559ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159697Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1e113e60

revert git to 2.24.1 · b009c064

Anthony Polito authored Apr 21, 2020

Bug: 1070694, b/154543469
Change-Id: I5099e3bb8c1aa9d3003d82e7dbb545fc75a1f749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157801Reviewed-by: Anthony Polito <apolito@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b009c064

20 Apr, 2020 4 commits

Roll recipe dependencies (trivial). · 062833f3

recipe-roller authored Apr 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/05e3d21945daf81423e55c5eb908d1782c133873 (iannucci@chromium.org)
Add led job.proto and update all luci-go protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I90b91a5b8019dd8c57ff7bdfbb3897f1d5ecd180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157797Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

062833f3

Roll recipe dependencies (trivial). · b9b3385f

recipe-roller authored Apr 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/47e1e46fc93780eb49c1e650c0fb2bae3dcf57e4 (engeg@google.com)
recipe_engine: add current time to execution details

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifbe932d96c8e67a75653e0c908c8004125bb7c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157794Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b9b3385f

Fix printing error on git-rebase failure · 4511b131

Josip Sokcevic authored Apr 20, 2020

R=ehmaldonado@chromium.org

Bug: 1071280
Change-Id: I8b1f00bb7c454297b10d5e047ae35c2686f69fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2155154Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

4511b131

Roll recipe dependencies (trivial). · 4fef6b9e

recipe-roller authored Apr 20, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/31687e34cb0c12d242f4be77826e6f073a573690 (iannucci@chromium.org)
    [recipe_modules/proto] Add new module for manipulating proto data.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifea252adbfc83b3484c3325db5e0eeb3c26a9f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157787Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4fef6b9e

17 Apr, 2020 2 commits

Make fetch compatible with py 3.5 · e2686734

Milad Farazmand authored Apr 17, 2020

Running `fetch v8` with Python 3.5 produces the following error:
TypeError: the JSON object must be str, not 'bytes'

Adding `.decode("utf-8")` makes it compatible with both versions.

Change-Id: Ib0699b61b24f191559c30f1e7ca8d2c919803d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2154108Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e2686734

ReadHttpResponse: Handle 429s with retries and adjust retry count · 888c0fe7

George Engelbrecht authored Apr 17, 2020

We've had reliability issues with gerrit, primarily related to
429 status codes but also DDoS bans. The light DDoS bans can be
very short lived and we extend retries to handle this. Longer
term bans can take up to an hour to lift.

BUG=chromium:1071590
TEST=./gerrit_client_test.py

Change-Id: Iaf68c0d9cc7375aa58367ec0447d54a99f8ebf39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2153089
Commit-Queue: George Engelbrecht <engeg@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

888c0fe7

16 Apr, 2020 3 commits

git cl patch: support short CL URLs. · 8aebb60a

Andrii Shyshkalov authored Apr 16, 2020

Change-Id: I71ae8e94ec0cc5d880c002c7187351ac6ee2c2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2152218
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

8aebb60a

Add cpplint support for space before [[attributes]] · b8265f10

Derek Morris authored Apr 16, 2020

Cpplint.py supports checking for spaces in front of square brackets;
this is a style violation in most cases (with the typical case being
arrays), but there are already situations where this rule is skipped
for the square bracket used for lambda captures. We add another such
exclusion here for the case of c++ attributes.

Change-Id: I2d4f972be29f5427cb8d855787c90dfa5d610e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2151125
Commit-Queue: Derek Morris <demorri@microsoft.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b8265f10

Add timestamp info to presubmit logs for easier debugging. · cca5c49d

Erik Staab authored Apr 16, 2020

Change-Id: I80f53f1130ba1dd17c886b14a5737d30394604f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2152004Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>

cca5c49d

15 Apr, 2020 4 commits

Fix "git freeze" failing on broken symlinks · fc5e1032

Andrew Grieve authored Apr 15, 2020

Fixed by switching "stat()" to "lstat()".

Does not seem to be a python3 vs python2 thing (fails on py2 as well).

Bug: 1071066
Change-Id: I7eea9ed39b43e09ae2f7558bf23c12581f02e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2150507Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>

fc5e1032

Reland "metrics: Use vpython3 instead of sys.executable" · e1a9c8db

Edward Lesmes authored Apr 15, 2020

This is a reland of 310e1e81

Use subprocess2, which will set shell=True when running on Windows.

Original change's description:
> metrics: Use vpython3 instead of sys.executable
>
> Apparently, uploading metrics might happen after sys.executable
> has been deleted.
>
> Bug: 1068263
> Change-Id: Id4ab465bb97d146b688f42fb2002e29372e65555
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2148879
> Commit-Queue: Anthony Polito <apolito@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

Bug: 1068263
Change-Id: I19c915f3e8862ae3248b01e0eccdbdf0bfda7369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2150170Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e1a9c8db

gclient: Set with_branch_heads if asked to sync to refs/branch-heads/* · 8073a502

Edward Lesmes authored Apr 15, 2020

The bug is caused because we already have refs/branch-heads/XXXX locally,
so we don't attempt to fetch it again, even if it has been updated.

This solution is a bit of a hack to make sure that we fetch
refs/branch-heads/*, which is the most common case for this to fail.

Bug: 1070545
Change-Id: Iec7cfff18219794230188e2b9e901c587acd274b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149849
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

8073a502

Revert "metrics: Use vpython3 instead of sys.executable" · 3820520a

Edward Lesmes authored Apr 15, 2020

This reverts commit 310e1e81.

Reason for revert:
"vpython3" doesn't work on Windows without shell

Original change's description:
> metrics: Use vpython3 instead of sys.executable
> 
> Apparently, uploading metrics might happen after sys.executable
> has been deleted.
> 
> Bug: 1068263
> Change-Id: Id4ab465bb97d146b688f42fb2002e29372e65555
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2148879
> Commit-Queue: Anthony Polito <apolito@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I6b9998de0d3afeda142971f889361fb1c8a37a0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1068263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149762Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3820520a

14 Apr, 2020 7 commits

upgrade git to 2.26.1 · 81d17672

Anthony Polito authored Apr 14, 2020

Bug: 1070694
Change-Id: I47def761c61ea62f44aa891f869383b9a0a56d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149755Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

81d17672

Roll recipe dependencies (trivial). · 371d5945

recipe-roller authored Apr 14, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/ca1b8188e76bd1a66d92bc420e674fb1b5ce81fb (yiwzhang@google.com)
    [warning] Implement warning recorder to record execution and import warnings
  https://crrev.com/af5b235945d6de010d29240863a6c1d5910c9047 (yiwzhang@google.com)
    [warning] provide functionality to escape warnings
  https://crrev.com/8d094c42eda98ce18f2f09c95ab3c0c75f9abb07 (yiwzhang@google.com)
    Refactor to use RawResult message instead of Result across the engine

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idf03c53eec502cc5cee37995a1817dadacea455c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149754Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

371d5945

Fix recipe autoroller account. · 52b9929d

Robert Iannucci authored Apr 14, 2020

R=ehmaldonado@chromium.org,apolito@google.com

Change-Id: I804488c86b864d330be8b667c64f58f3541f0197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149851
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>

52b9929d

metrics: Use vpython3 instead of sys.executable · 310e1e81

Edward Lesmes authored Apr 14, 2020

Apparently, uploading metrics might happen after sys.executable
has been deleted.

Bug: 1068263
Change-Id: Id4ab465bb97d146b688f42fb2002e29372e65555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2148879
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

310e1e81

Roll recipe dependencies (nontrivial). · e0950f3c

recipe-roller authored Apr 14, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
  https://crrev.com/fc83ebe9d2ed46c6b7147997a6987e0f42d962f4 (mohrr@google.com)
    [recipe_modules/cipd] Use -max-threads by default

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7cf134b39e333cecc54868416a13248e104ca386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140624
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

e0950f3c

Decode the returned encoded bytes of subprocess.check_all/check_output. · 08f4d59e

Johnny(Jianning) Ding authored Apr 14, 2020

Bug: 1068779
Change-Id: Ie399e134577732b441c37ca2083d72a66bb631c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142745Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Johnny (Jianning) Ding <jnd@chromium.org>

08f4d59e

Replace customzied test failure assertion with ResultReasonRE from engine · b71a96f8

Yiwei Zhang authored Apr 14, 2020

This change is to facilitate the annotation protocol -> luciexe protocol
migration in the future. The failure response structure will be changed
after the migration. Therefore, we only need to change the
implementation detail of ResultReasonRE at that time.

R=iannucci

Change-Id: If5e0005dddcaf6ccdfbcb047e3855763cf4eadc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2146066
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

b71a96f8

13 Apr, 2020 3 commits

Set git low speed detection on bot_update · a01816b0

Josip Sokcevic authored Apr 13, 2020


Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: skia
Change-Id: Iacf276bd53fdca37994b6d6fe1e5db71f844a3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2147833Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

a01816b0

Run spellchecker on depot_tools · 925cedba

Quinten Yearsley authored Apr 13, 2020

This was made by running `codespell` and `scspell`
and then checking the results.

Change-Id: I169fd5b40294f83015075b4a899fbca263821f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2144602
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

925cedba

Roll out new goma client binary VERSION=197 · 4f3aff5f

Fumitoshi Ukai authored Apr 13, 2020

https://chromium.googlesource.com/infra/goma/client/+/897c9f8406700b241acbcedefa1ab02486bdf063

Bug: b/152279383
Change-Id: Ia1800c6a6326ecf530a5c259c4051579d29780c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2147102
Auto-Submit: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

4f3aff5f

09 Apr, 2020 1 commit

Make vadimsh@ an owner of cipd*. · e521cd14

Andrii Shyshkalov authored Apr 09, 2020

R=ehmaldonado, vadimsh

Change-Id: I8376663dfd6227175b3ccc46ea31038fbfa723b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142734Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e521cd14

08 Apr, 2020 3 commits

[lucicfg] Update v1.13.0 -> v1.13.1 · 3c1ff62f

Roberto Carrillo authored Apr 08, 2020

Main change is propagating resultdb integration option from
luci.builder(...) to cr-buildbucket.cfg

R=nodir,vadimsh,tandrii

Bug: 1027762
Change-Id: I6f03632857f45c6cc3c5c108b294bdaf0d560d6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142587Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

3c1ff62f

Add brucedawson@ to own post_build_ninja_summary.py · 3c1e7e77

Peter Wen authored Apr 08, 2020

Bruce created the script and is most qualified to review changes to it.

Bug: None
Change-Id: I238c88ad03db422f9c7f5b2760ff2dd25d431e65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2141224
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

3c1e7e77

More detailed build-step type summary for android · e3a42b25

Peter Wen authored Apr 08, 2020

Increase the number of long times by extension to report from 5 to 10
since java build steps produce a number of different extension types. It
is difficult to distinguish between android vs non-android builds, so
increase this default for all platforms.

Prioritize .jar outputs for java targets and allow up to two levels of
extensions to be recognized.

e.g.
file.interface.jar would have .interface.jar as its full extension.
file.javac.jar would have .javac.jar as its full extension.

Some of these build steps require .jar outputs, which is why these
targets use a secondary extension to differentiate.

Example output: https://crrev.com/c/2142395

Bug: chromium:1067273
Change-Id: Id5780980f60841c3384d91bf96121c6dec3e8bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142163Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>

e3a42b25

07 Apr, 2020 3 commits

depot_tools: Execute commands using Python 2 on Windows when GCLIENT_PY3=0. · c440b23d

Edward Lesmes authored Apr 07, 2020

Change-Id: Ib51acc5671c7b60219f64bcb73a70f85a51779a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140817Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c440b23d

Roll recipe dependencies (trivial). · 48c5c9c5

recipe-roller authored Apr 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/42f6841b9e7d40b310e52425c71ca77dbe2ac1f2 (olivernewman@google.com)
    [analyze] Consider recipe resource files

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieae5583e34dc42c2dde78b2561cfbe62365ec046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140371Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

48c5c9c5

Do not prompt on --dependencies if --force. · 3863fc52

Jose Lopes authored Apr 07, 2020

At the moment, specifying --dependencies to upload all dependent CLs
will always prompt for confirmation if --force was specified. This
means that there is no way to run this command in a batch way or from
another script, and it's also in contradiction to the --force flag
which is meant to answer 'yes' to all prompts.

This uses a pattern that is used several times in the script, which is
to check 'if not force: prompt()'.

Change-Id: I7d85b02b68d958a5b2d3295a04c4ced023d36ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2139700
Auto-Submit: Jose Lopes <jabolopes@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3863fc52

06 Apr, 2020 2 commits

[lucicfg] Update v1.12.7 -> v1.13.0. · 06c0b50c

Vadim Shtayura authored Apr 06, 2020

The most notable change is that invalid escape sequences in strings
cause errors now. This is due to an underlying starlark-go change.

R=tandrii@chromium.org, iannucci@chromium.org

Change-Id: I2fc8aa297000e5bcfd9c5f0cca7af205a8e77e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2137983Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

06c0b50c

Reland "git-cl: Execute clang-format-diff.py using vpython." · 89624cdf

Edward Lesmes authored Apr 06, 2020

This is a reland of 87661afb

Set shell=True on Windows, so that vpython.bat can be executed.

Original change's description:
> git-cl: Execute clang-format-diff.py using vpython.
>
> When running git-cl using vpython3, sys.executable is python3.
> Execute clang-format-diff.py using vpython instead, since it has
> not been migrated already.
>
> Bug: 1066187
> Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1066187
Change-Id: Ia482f13d0f30d625f2f6db3cb4202b7f3f95707b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2135330Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

89624cdf

02 Apr, 2020 3 commits

Use "call" in gclient.bat to restore title · 19d4809e

Bruce Dawson authored Apr 02, 2020

The title of command prompt windows indicates what command is running.
However it is easy to confuse Windows so that it doesn't clear the
status when a program termintes. Apparently a tail from one batch file
to another is sufficient to do this. This change uses "call" to run
python to avoid this minor glitch, making is so that I can tell when
gclient has completed merely by glancing at the command prompt status
bar.

Change-Id: Ibd310362b8dd78589abc443be1841f0937c791fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2133303Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

19d4809e

repo: update to 2.5 launcher · 4ecdd22b

Mike Frysinger authored Apr 02, 2020

Bug: None
Test: `repo sync` still works
Change-Id: I472e5f8753f96f1ad45c9782e4ac30b71a620ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2120252Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

4ecdd22b

Revert "Reland "git-cl: Execute clang-format-diff.py using vpython."" · cd454025

Peter Kasting authored Apr 02, 2020

This reverts commit 87661afb.

Reason for revert: Still get:
OSError: Execution failed with error: [Error 2] The system cannot find the file specified.

Original change's description:
> Reland "git-cl: Execute clang-format-diff.py using vpython."
> 
> This is a reland of beec6607
> 
> Append the clang-format directory to the front of PATH instead of
> overwriting it.
> This allows vpython to be invoked.
> 
> Original change's description:
> > git-cl: Execute clang-format-diff.py using vpython.
> >
> > When running git-cl using vpython3, sys.executable is python3.
> > Execute clang-format-diff.py using vpython instead, since it has
> > not been migrated already.
> >
> > Bug: 1066187
> > Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926
> > Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 
> Bug: 1066187
> Change-Id: I8b65549ef47587cef8492f8f76a037eb85a981fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132972
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I22566c829a83991e3749a039d0bd0ba7d8a56812
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066187
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2133588Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

cd454025