Commits · 3b055d329e60963cb8a7de7b4baec2202fe3eb60 · Linshizhi / Chromium_Depot_tools

07 Dec, 2020 2 commits

repo: use str(Path) for Python 3.5 a little longer · 3b055d32

Mike Frysinger authored Dec 07, 2020

Give people one more month before we make 3.6 a hard requirement.

Change-Id: Ieb471b917c5ef5b9cb20b321305c4c13af675109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575635Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

3b055d32

Roll recipe dependencies (trivial). · 55e9ddf2

recipe-roller authored Dec 07, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f0848ccd2435b55de15b86a4163ccb55a8a18d77
  f0848cc (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77248a2d12f1e3cb2840932572202a2fbc381f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576580Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

55e9ddf2

05 Dec, 2020 1 commit

Roll recipe dependencies (trivial). · e602c60a

recipe-roller authored Dec 05, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/4077ceeac827409f2a2953cd01aec6d29601decc
4077cee (qyearsley@chromium.org)
Add a mapping of name to analyzer in tricium recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie7dc982f2db75d82e66d3cd03c3d4ec0dfac8ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576035Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e602c60a

04 Dec, 2020 6 commits

[depot_tools] Use logging.warning · e6a62339

Gavin Mak authored Dec 04, 2020

logging.warn is deprecated and should be replaced with logging.warning.

Bug:1097402
Change-Id: I55ce007bec47608eeafcf3cd9ac2b90f60073115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575621Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>

e6a62339

[depot_tools] Fix CMDlol · 18f45d28

Gavin Mak authored Dec 04, 2020

Hidden ascii art in git_cl.py needs to be decoded to utf-8 to print correctly.

Bug:1106660
Change-Id: Ie41490c789534ea6cb589bbc96aa06cd251943f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575620Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

18f45d28

Roll recipe dependencies (trivial). · fab6700b

recipe-roller authored Dec 04, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/424f90b51844a2c554b2e1ff3d444f72594f89c6
424f90b (qyearsley@chromium.org)
Edit comments in tricium recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If4f54a989f40fd9025156938ddef1041a80fad6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575618Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fab6700b

Roll recipe dependencies (trivial). · b2838210

recipe-roller authored Dec 04, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6420c4e9667bd30af20f3f548459d02209a05733
6420c4e (yiwzhang@google.com)
Log all keys in the input properties that maps to an int value

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c18f4a5db2d4be543611af08efea9df34e2f675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575616Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b2838210

Roll recipe dependencies (trivial). · 079a95bc

recipe-roller authored Dec 04, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/577e2b38988979079e6c62821d7b9cba73022fde
  577e2b3 (tikuta@chromium.org)
      [cas] update client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic4a3cb54e1e8623a2f4ffa182ed9b9ba090b533d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2573582Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

079a95bc

[git-cl] Use owners client when processing --[tb]r-owners. · 968b1fe7

Edward Lesmes authored Dec 04, 2020

Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

968b1fe7

03 Dec, 2020 5 commits

Support CMake generated build files · b2c18f2f

Vitaly Buka authored Dec 03, 2020

Chromium does not use CMake, however ninja with Goma is used by LLVM
team.

Change-Id: I38349d0574048b22b32365e45c587e604e045442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572805Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>

b2c18f2f

[owners] Fix SuggestOwners when there is only one owner. · ca45aff3

Edward Lesmes authored Dec 03, 2020

If there are less than two owners for the given paths,
current implementation will get stuck in infinite loop.

Change it to return any possible owner.

Change-Id: I75f18e0a00057c58d227dac23dc8572f1fba23f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572802
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

ca45aff3

Roll recipe dependencies (trivial). · 91cf42a0

recipe-roller authored Dec 03, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dee64b81058a22b423ad1e356fcb38ff747ddf3d
dee64b8 (qyearsley@chromium.org)
tricium: Remove indent in JSON string used for output property

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1046c027e1d60330b797d5a2ab733d2994e98765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572647Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

91cf42a0

[presubmit] Add option to ignore TBR on PRESUBMIT.py checks. · 1ec57124

Edward Lesmes authored Dec 03, 2020

Change-Id: Ibd1a5fa67aca0c273e8289d0726afeaeb88754d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2568908
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

1ec57124

Roll recipe dependencies (trivial). · 4640dfbf

recipe-roller authored Dec 03, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/9182b0102469ca22ffe1b7b5bd32ef355601a421
9182b01 (yiwzhang@google.com)
Raise GreenletExit exception if a step is launched during shutd...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e1db55eba3afdeadbc3c01caeca4cbed394d629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2569770Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4640dfbf

02 Dec, 2020 3 commits

Roll recipe dependencies (trivial). · 70828422

recipe-roller authored Dec 02, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/85e6c33d009255b81cec365e6260d41a549d6171
85e6c33 (qyearsley@chromium.org)
Update recipe doc workflow.md

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I71f7ddc8a7c388c5bb13c2e614c0021c8f0fc863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2570093Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

70828422

repo: avoid fstrings for Python 3.5 a little longer · d1655710

Mike Frysinger authored Dec 02, 2020

Give people one more month before we make 3.6 a hard requirement.

Change-Id: I696bf3f0edbe64d6294dd626fc9ff16c9e44fd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2570017Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

d1655710

[git-cl][owners] Use new API to suggest batch owners. · 8a791e7c

Edward Lesmes authored Dec 02, 2020

Change-Id: I2e2b0aff583e6d9b36261acbef87221e29fe7923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2565145Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

8a791e7c

01 Dec, 2020 5 commits

repo: only warn if update_depot_tools does not exist · 80cea4f5

Mike Frysinger authored Dec 01, 2020

It looks like some bots don't have this for whatever reason.

Bug: 1148984
Change-Id: I7ff826e0a0df78e3be9e1f84698b69574c75f71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2567384Reviewed-by: Sean McAllister <smcallis@google.com>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

80cea4f5

Add remote-disabled support for reclient in autoninja. · 684460d2

Michael Savigny authored Dec 01, 2020

In addition to setting GOMA_DISABLED, this CL also sets the
RBE_remote_disabled environment variable to autoninja.

Bug: 1149386
Change-Id: I9aa8be005a9cd473b7371eadcab83d6068e0e070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2565550Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>

684460d2

Roll recipe dependencies (trivial). · f1176059

recipe-roller authored Dec 01, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ec5ee98a6e1f7efe4c4069e7e60f849db2046080
ec5ee98 (yiwzhang@google.com)
Set the build to Cancelled Status when recipe was interrupted

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I51b953584902dffd0c9cb08c477f912b9cfb94ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2567368Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f1176059

Roll recipe dependencies (trivial). · 6c54473c

recipe-roller authored Dec 01, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e052ab8a109530acf15ce7cea440ad9a3f6f2f38
  e052ab8 (olivernewman@google.com)
      [json] Indent mock json data

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I872e10486d33093684c3d400054f341d1685612f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2567360Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6c54473c

Roll recipe dependencies (trivial). · 6d2a0fef

recipe-roller authored Dec 01, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/576a243a4c291e0659adaead31e77043e6dcbf14
  576a243 (tikuta@chromium.org)
      [swarming] do not fail if there is no output in analyze

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe4ee19c8d86d15bb4fa08d592a1bcc4dcd675c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2566413Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6d2a0fef

30 Nov, 2020 3 commits

Reduce git cl split oversplitting. · 1af7968d

Sigurdur Asgeirsson authored Nov 30, 2020

Without this change, git cl split will create a separate CL for every
file that has per-file owners rules. This is almost always the wrong
thing to do. With this change, it will at least aggregate all such files
to their parent directory. This may under-split, but is perhaps nearer
the mark.

Change-Id: Iea7997b36d053713fa00f1261ea032e09d9c2818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2555729
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

1af7968d

[dirmd] Bump to 8d8dfbbee8184bf5f1c90c875e80d0dd58659f03 · f819411f

Edward Lesmes authored Nov 30, 2020

To pick https://chromium-review.googlesource.com/c/infra/infra/+/2521159

Change-Id: Icff019c71c87a3e1e288c4cc1c5ebace7a372b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2564645
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

f819411f

Reland "repo: auto-update depot_tools when used" · eb386eb3

Mike Frysinger authored Nov 30, 2020

This is a reland of 19512276.
It includes an update to .gitattributes for recipes.

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

eb386eb3

26 Nov, 2020 2 commits

Revert "repo: auto-update depot_tools when used" · dc7b108d

Andrii Shyshkalov authored Nov 26, 2020

This reverts commit 19512276.

Reason for revert: broke ART bots.
Bug: 1153114

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

TBR=vapier@chromium.org,ehmaldonado@chromium.org,mmortensen@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,mmortensen@chromium.org

Change-Id: Ic0ac9155e3acde87966f518213a5a8440e167295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560955Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

dc7b108d

Roll out new goma client binary VERSION=209 · e62621d2

Yoshisato Yanagisawa authored Nov 26, 2020

Bug: b/173566348
Change-Id: I175386edb044197af00ee78f78003576d176873e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561706Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

e62621d2

25 Nov, 2020 5 commits

Roll recipe dependencies (trivial). · b9a5e83e

recipe-roller authored Nov 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fd7a6b318a4b22b708cf15784814e4f236005ff4
fd7a6b3 (qyearsley@chromium.org)
Expand and edit the recipe user guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48f7e55bd133813d7777f09f1840314532a3ac53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560670Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b9a5e83e

repo: auto-update depot_tools when used · 19512276

Mike Frysinger authored Nov 25, 2020

Since gclient automatically syncs this checkout when used,
have repo do the same for CrOS users.

Bug: 1148984
Test: ran and saw it auto-update when used externally
Test: ran and saw it not auto-update when used inside of a repo checkout
Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

19512276

Roll recipe dependencies (trivial). · 36f2a962

recipe-roller authored Nov 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/212297d9077c109c05255ce5d23120840c6f398a
  212297d (olivernewman@google.com)
      [file] Add include_log param to write_json() and read methods

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I53c72e02a4a04392c43e2d0a8609c177df01d7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560668Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

36f2a962

git cl comments: shorten long URLs if possible. · a3762a90

Andrii Shyshkalov authored Nov 25, 2020

R=ehmaldonado

Before:
  https://chromium-review.googlesource.com/c/2552792/3/cv/internal/gerrit/gerritfake/fake.go#321
After:
  https://crrev.com/c/2552792/3/cv/internal/gerrit/gerritfake/fake.go#321
Change-Id: Ie6044e2743c4359bc30c98d8915edd9119d4a386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556837
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

a3762a90

gerrit_client: validate --param options · 8820ab85

Mike Frysinger authored Nov 25, 2020

Passing an invalid --param option in leads to a crash lower down in
the gerrit modules which can be hard to trace back to the original
error: the user forgot the "key" in the "key=value".

Change-Id: I6fe5fab0fad15cf8d25173e0f1c8ea130efc44ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2558651Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

8820ab85

24 Nov, 2020 4 commits

[owners] Add SuggestOwners to OwnersClient. · 295dd187

Edward Lesmes authored Nov 24, 2020

Gerrit API doesn't provide the score for
an owner of a path, so we can't use the
same algorithm when suggesting owners.

This change introduces a new algorithm to
select the smallest set of at least 2
owners that can approve the change.

Change-Id: If620073bdf63633f171c1480e345dbaf75e9f575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556479Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

295dd187

[owners] Sort owners by distance · 64e80769

Edward Lesmes authored Nov 24, 2020

Change-Id: Id10af7bb2fa821c369952402853fae5c847b2f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556478
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

64e80769

[owners] Add tests for GetFilesApprovalStatus · 4c5dd5d8

Edward Lesmes authored Nov 24, 2020

Change-Id: I28b061ceb44c032e2c9eb7da22750a7c25f50bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556477
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

4c5dd5d8

Roll recipe dependencies (trivial). · b35dd76c

recipe-roller authored Nov 24, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6d51a052a45b041e4163a01f0b6f9035f4d07b2a
  6d51a05 (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3639a6a6b96cb121888fbb00512eb956ac245ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2557437Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b35dd76c

23 Nov, 2020 1 commit

[tryserver] Report affected files via property · 260eb0f6

Nodir Turakulov authored Nov 23, 2020

To enable aggregate analysis on changed files in BigQuery, conditionally
report them via an output property.

This CL causes a non-trivial roll only because of the sorting.

Recipe-Nontrivial-Roll: build
Bug: 1151655
Change-Id: Ie7a6c622196143c1aef07af9a9a356fb4202ea56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2553349Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

260eb0f6

20 Nov, 2020 3 commits

Replace non-inclusive terms · 9c0dc302

Josip Sokcevic authored Nov 20, 2020

Bug: 1118410, 1118413, 1118422, 1118424, 1118426
Bug: 1118428, 1118430, 1118434, 1118438, 1118442
Bug: 1118453, 1118454
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build
Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

9c0dc302

Improve the readability on variable name added in crrev/c/2528670 · 26ced490

Xinan Lin authored Nov 20, 2020

Bug: 1146487
Change-Id: I60476ac60ede4810f63403791386128508631db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551386
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Xinan Lin <linxinan@chromium.org>

26ced490

Roll recipe dependencies (trivial). · 330b6055

recipe-roller authored Nov 20, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5f437dc5800881abe0f78cf3b7c976817586a3ef
  5f437dc (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I556968d2dd7c8600ba2ad8453a049549b64e6a10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551499Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

330b6055