- 26 Mar, 2019 1 commit
-
-
Raphael Kubo da Costa authored
connect(2) says stream sockets may only succeed to connect once. This means if the call to sock.connect() fails it will continue failing for the entirety of the wait loop, and we will fail to wait for a port to bind even when it eventually becomes available. Make sure we create a new socket every time we are about to try to connect to it. Change-Id: I16d7dbea3590c5bf7f7240bdefcc5ec0bcd1edb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1528291 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
- 04 Oct, 2018 1 commit
-
-
Edward Lemur authored
Bug: 882611 Change-Id: I72646544a164f557ea7d53e0ce0f16d663618a98 Reviewed-on: https://chromium-review.googlesource.com/c/1255446Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 19 Sep, 2018 1 commit
-
-
Edward Lemur authored
This is a reland of 67ef3f67 We no longer call cipd unconditionally. Original change's description: > gclient: delete unversioned directory before adding cipd dep for the same path > > Bug: 882611 > Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 > Reviewed-on: https://chromium-review.googlesource.com/1228655 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Bug: 882611 Change-Id: I683bfc62bd1eebfec0853583f96f3981c2c6bdf2 Reviewed-on: https://chromium-review.googlesource.com/1232891Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 18 Sep, 2018 2 commits
-
-
Andrii Shyshkalov authored
This reverts commit 67ef3f67. Reason for revert: might have broken GCE/ccompute fleet. Original change's description: > gclient: delete unversioned directory before adding cipd dep for the same path > > Bug: 882611 > Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 > Reviewed-on: https://chromium-review.googlesource.com/1228655 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: Ia2172b1b0d236357edf93dacf57f3bf7d80d5968 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882611 Reviewed-on: https://chromium-review.googlesource.com/1231699Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Edward Lemur authored
Bug: 882611 Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 Reviewed-on: https://chromium-review.googlesource.com/1228655 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 10 Sep, 2018 1 commit
-
-
Corentin Wallez authored
When a recursive dependency has use_relative_paths it also makes sense to have the hooks working directory by the dependency's directory. Otherwise if a hook uses one of the relative dependencies it is impossible to know which path prefix to use. However we cannot change the behavior of hooks with use_relative_paths because it would break existing projects that use_relative_paths but hardcoded the prefix for hooks. Instead we add a second boolean, use_relative_hooks that triggers the behavior. Adds tests for the new behavior and a test for existing interactio between hooks and recursedeps. BUG=chromium:875245 Change-Id: Ie4c526baa425ff887b3be54e0feca7c597ededec Reviewed-on: https://chromium-review.googlesource.com/1213327 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 12 Jul, 2018 2 commits
-
-
John Budorick authored
This reverts commit d328b47e. Reason for revert: suspect this caused https://bugs.chromium.org/p/chromium/issues/detail?id=863211 Original change's description: > gclient: Add support for the branch:revision format. > > Bug: 850812, 853032 > Change-Id: I597acbde2b3c229813b7eba8fcba52d5877130b2 > Reviewed-on: https://chromium-review.googlesource.com/1119235 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: I1e4c00b83a2840cc5a87621469da866dad58a20c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850812, 853032 Reviewed-on: https://chromium-review.googlesource.com/1135893Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
Bug: 850812, 853032 Change-Id: I597acbde2b3c229813b7eba8fcba52d5877130b2 Reviewed-on: https://chromium-review.googlesource.com/1119235 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 11 Jul, 2018 1 commit
-
-
Edward Lemur authored
When a git mirror is configured, it fetches only refs/heads/*, and possibly branch-heads and tags, but not refs/changes. When gclient attempts to sync refs/changes/* from a mirror, it fails, since the mirror has no such objects. See for example [1], where the DEPS entry for builtools was modified to sync to a CL, but all the bots failed to sync to it. This change modifies gclient to always fetch refs/changes/* directly from the repo, even when a mirror is configured. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1119098/6 Bug: 858894 Change-Id: I71bb313e4325a81b2985db1d00c70a8844dc7c22 Reviewed-on: https://chromium-review.googlesource.com/1119525 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 28 Jun, 2018 1 commit
-
-
John Budorick authored
crrev.com/c/1097623 broke the official bots because the cipd variable escaping present in the normal DEPS file wasn't present in the flattened DEPS file. Change-Id: Iaae8b95a9d8c5ce0ed80071169e731a24e98b4c4 Reviewed-on: https://chromium-review.googlesource.com/1112935 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 26 Jun, 2018 1 commit
-
-
Edward Lemur authored
Report the dependencies that were not synced, due to their, or their parent's condition evaluating to False. Bug: 853010 Change-Id: I375703a1b91e3c3e31e444b0df1c95ecae17b6ba Reviewed-on: https://chromium-review.googlesource.com/1111113Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 14 Jun, 2018 2 commits
-
-
Andrii Shyshkalov authored
This reverts commit c9121141. Reason for revert: broke patch application on infra/config https://crbug.com/853032 Original change's description: > gclient_scm: Use cherry-picking instead of rebasing. > > We have a problem when in this situation, we checkout |patch| and rebase it on > top of |base|, thus including an |extra commit| that we shouldn't. > > o master > | > . o patch > |/ > o extra commit > | > o base (what gclient synced src at) > > This does merge-base between |patch| and |master|, and cherry-picks only the > changes belonging to the patch. > > Bug: 850812 > Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e > Reviewed-on: https://chromium-review.googlesource.com/1098228 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,ehmaldonado@chromium.org Change-Id: Ib3feeee2f44f5441713383f1dbf08db16fae4717 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850812, 853032 Reviewed-on: https://chromium-review.googlesource.com/1101977Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Edward Lemur authored
We have a problem when in this situation, we checkout |patch| and rebase it on top of |base|, thus including an |extra commit| that we shouldn't. o master | . o patch |/ o extra commit | o base (what gclient synced src at) This does merge-base between |patch| and |master|, and cherry-picks only the changes belonging to the patch. Bug: 850812 Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e Reviewed-on: https://chromium-review.googlesource.com/1098228 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 07 Jun, 2018 1 commit
-
-
Edward Lemur authored
Bug: 849374 Change-Id: I5654ed65843c6dae6b7dbee10a40aa35e16803dc Reviewed-on: https://chromium-review.googlesource.com/1087390 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 11 May, 2018 1 commit
-
-
Edward Lemur authored
This is a reland of e877b177 Original change's description: > gclient: Get rid of parsed_url. > > There is no reason I can see to set parsed_url so late. > Also, the tests are misleading, since relative URLs don't behave the way > the tests led you to believe. > > Bug: 839925 > Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 > Reviewed-on: https://chromium-review.googlesource.com/1047797 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=agable@chromium.org Bug: 839925 Change-Id: I9200ec5fbe7289022e9754f0c78676dc931fcaeb Reviewed-on: https://chromium-review.googlesource.com/1054567 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org>
-
- 10 May, 2018 2 commits
-
-
John Budorick authored
Suspected of breaking the world. This reverts commit e877b177. TBR=ehmaldonado@chromium.org,tandrii@chromium.org Bug: 841936 Change-Id: Iad2b55a2235d8d0b1a3d7681cbd577f795cb89dd Reviewed-on: https://chromium-review.googlesource.com/1054440Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
There is no reason I can see to set parsed_url so late. Also, the tests are misleading, since relative URLs don't behave the way the tests led you to believe. Bug: 839925 Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 Reviewed-on: https://chromium-review.googlesource.com/1047797 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
- 03 May, 2018 1 commit
-
-
Michael Moss authored
Previously, 'gclient sync' would process "gn_args" settings in any recursed DEPS files, potentially producing multiple output files or conflicting output files, but 'gclient flatten' would only ever include one set of "gn_args" settings in the flattened output, and only if they occurred in the top-level DEPS file. This makes 'gclient sync' and 'gclient flatten' more consistent by restricting them both to a single instance of those setting, and requiring those setting to be defined either in the top-level DEPS file, or in a recursedeps file specificed by the new 'gclient_gn_args_from' setting. R=dpranke@google.com, ehmaldonado@google.com Bug: 825063 Change-Id: If90d952e47367c50b36daade16a26b29aec0c9db Reviewed-on: https://chromium-review.googlesource.com/1039870Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
- 08 Apr, 2018 1 commit
-
-
Michael Moss authored
This fixes an issue where cumulative conditions would fail to evaluate if the recursed DEP (or custom_var overrides) didn't happen to redeclare all the variables used by the parent conditions. TBR=dpranke@google.com, ehmaldonado@google.com Bug: 825063 Change-Id: Icb53f04928f914dfacc2c3035d01be103d9f8247 Reviewed-on: https://chromium-review.googlesource.com/1000836 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 31 Mar, 2018 1 commit
-
-
Michael Moss authored
This is useful for processing purely "local" DEPS files, with a command-line like: gclient revinfo --output-json /tmp/out \ --spec 'solutions=[{"name": ".", "deps_file": "myDEPS", "url": None}]' This is specifically to fix the "revinfo --output-json" case, but it also cleans up some errors in the 'flattening' test cases. Note that None values already work when using 'revinfo' with stdout output, it's just the json output that complains. BUG=825063 Change-Id: If5f69ba51cb9d0aa0f2b48a2f9b4ed8706b4c738 Reviewed-on: https://chromium-review.googlesource.com/989022 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 22 Mar, 2018 1 commit
-
-
Edward Lesmes authored
Mimics bot_update's functionality to apply gerrit refs in gclient via --gerrit-ref flags. When the patch fails to apply, gclient sync will return exit code 2. The idea is to move this logic from bot_update to gclient sync to deal when patches for projects like ANGLE are tried on Chromium bots. This way the patch is applied before recursively parsing and syncing ANGLE’s DEPS.chromium file, which doesn't currently happen. Bug: 643346 Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18 Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 20 Feb, 2018 1 commit
-
-
John Budorick authored
Bug: 813460 Change-Id: Ie52a20dcdf5cb60ab47b787dcfa05aa8a712a727 Reviewed-on: https://chromium-review.googlesource.com/926709Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 06 Feb, 2018 1 commit
-
-
Michael Moss authored
BUG=783607 R=agable@google.com, dpranke@google.com Change-Id: I6989203a9e560930cc53254c566275a30d3bead3 Reviewed-on: https://chromium-review.googlesource.com/902168Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
- 12 Oct, 2017 1 commit
-
-
Dirk Pranke authored
Previously, gclient would attempt to write an args file after a dependency was checked out, but before any sub-dependencies had been checked out. If the args file path pointed at something inside a sub-dependency, this wouldn't work, because the directory might not yet exist. This most obviously happened for buildspec clobber builds. The fix is to wait until after the sub-dependencies have been checked out to write the file. R=phajdan.jr@chromium.org, mmoss@chromium.org BUG=773933 Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23 Reviewed-on: https://chromium-review.googlesource.com/714644Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 02 Oct, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I195f5f798d9869f385437db4e0bc5f4c5d4853ae Reviewed-on: https://chromium-review.googlesource.com/687496 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 661382 Change-Id: I0e74273a5e00b4f3cf1d5c22ce0944dc2fa6f31e Reviewed-on: https://chromium-review.googlesource.com/692934Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 26 Sep, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This helps make sure they have proper types (e.g. True instead of "True" for booleans). Also see https://chromium-review.googlesource.com/c/chromium/src/+/681854 for context. Bug: 756688, 570091 Change-Id: I1e4d26df724e8e94cc3daba361191856f80a1b2c Reviewed-on: https://chromium-review.googlesource.com/681705Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 07 Sep, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 624178 Change-Id: I7ffbf58441e8762630c3beec642108bcc671aae6 Reviewed-on: https://chromium-review.googlesource.com/647848Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 18 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
We need to pass OS info to recursively called _flatten_dep. Regular deps entries in OS-specific DEPS file recursed into need to be marked as OS-specific in the flattened file. Bug: 570091 Change-Id: If3055b84143d8a52d10d8753113893b5054b4d07 Reviewed-on: https://chromium-review.googlesource.com/621046Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 17 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I773b74b042233efa2a525f5f47e920468b7fea4a Reviewed-on: https://chromium-review.googlesource.com/618930Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 10 Aug, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This is the same change as in https://chromium-review.googlesource.com/c/586594 applied to _DepsOsToLines. Bug: 570091 Change-Id: I06a4dc3a9b6dbb001a15b1d7b88fef12cf6c6aaa Reviewed-on: https://chromium-review.googlesource.com/609980Reviewed-by:
Emma Söderberg <emso@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I8e67d617c2738459634aabbffd22135ee5d27cc4 Reviewed-on: https://chromium-review.googlesource.com/609065Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 09 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This finally makes the code structure seem right as well: there's just one method (_flatten_dep), with a simpler control flow. Also added a regression test. Bug: 570091 Change-Id: I22ac7a3af0429a7ffd874b4b1715c0f6c72e0006 Reviewed-on: https://chromium-review.googlesource.com/608241Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 03 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Nice side-effect of this change is simplifying the code. Also added regression test coverage. Bug: 570091 Change-Id: I470e9efc319632f997b02d210483988c17a7d3c8 Reviewed-on: https://chromium-review.googlesource.com/600369Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 27 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This is an exact reland of https://chromium-review.googlesource.com/583617 . One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091, 748486 Change-Id: Id47e3771b7163149a4cd427b84f84ece52772f34 Reviewed-on: https://chromium-review.googlesource.com/586594Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
William Hesse <whesse@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 25 Jul, 2017 2 commits
-
-
Paweł Hajdan Jr authored
This reverts commit e79ddeaa. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=748486 Original change's description: > gclient flatten: preserve variable placeholders > > One of the main use cases is making it clear which revision hashes > need to be changed together. The way it's usually done is one variable > referenced several times. With this CL, we preserve the references > from original DEPS, as opposed to evaluating them and losing some info. > > This CL actually makes Var() emit a variable placeholder > instead of its value, and adds support for these placeholders > to gclient. > > One of possible next steps might be to deprecate Var(). > > Bug: 570091 > Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a > Reviewed-on: https://chromium-review.googlesource.com/583617 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: If9c52ebfa78aba8041ce797ff842d09952d0e2ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091, 748486 Reviewed-on: https://chromium-review.googlesource.com/584907Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
One of the main use cases is making it clear which revision hashes need to be changed together. The way it's usually done is one variable referenced several times. With this CL, we preserve the references from original DEPS, as opposed to evaluating them and losing some info. This CL actually makes Var() emit a variable placeholder instead of its value, and adds support for these placeholders to gclient. One of possible next steps might be to deprecate Var(). Bug: 570091 Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a Reviewed-on: https://chromium-review.googlesource.com/583617 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
- 24 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Added a regression test. Simplified some logic - if we don't add os-specific deps and hooks to |dependencies|, we don't need to keep separate original values. Bug: 570091 Change-Id: I5bdd0b6a66df6b3a2b99d0ad9c6e54ee7114f09b Reviewed-on: https://chromium-review.googlesource.com/581687 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org>
-
- 06 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I4fac33ca683ff2011fa7307d5175592f3d9e258e Reviewed-on: https://chromium-review.googlesource.com/560171Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 03 Jul, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I96417d462efb3b0476ee17d42ac5f19d8c4f99c3 Reviewed-on: https://chromium-review.googlesource.com/558352Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-