1. 26 Mar, 2019 1 commit
  2. 04 Oct, 2018 1 commit
  3. 19 Sep, 2018 1 commit
  4. 18 Sep, 2018 2 commits
  5. 10 Sep, 2018 1 commit
    • Corentin Wallez's avatar
      gclient: add use_relative_hooks · a68660d0
      Corentin Wallez authored
      When a recursive dependency has use_relative_paths it also makes sense
      to have the hooks working directory by the dependency's directory.
      Otherwise if a hook uses one of the relative dependencies it is impossible
      to know which path prefix to use.
      
      However we cannot change the behavior of hooks with use_relative_paths
      because it would break existing projects that use_relative_paths but
      hardcoded the prefix for hooks. Instead we add a second boolean,
      use_relative_hooks that triggers the behavior.
      
      Adds tests for the new behavior and a test for existing interactio
      between hooks and recursedeps.
      
      BUG=chromium:875245
      
      Change-Id: Ie4c526baa425ff887b3be54e0feca7c597ededec
      Reviewed-on: https://chromium-review.googlesource.com/1213327
      Commit-Queue: Corentin Wallez <cwallez@chromium.org>
      Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
      a68660d0
  6. 12 Jul, 2018 2 commits
  7. 11 Jul, 2018 1 commit
  8. 28 Jun, 2018 1 commit
  9. 26 Jun, 2018 1 commit
  10. 14 Jun, 2018 2 commits
    • Andrii Shyshkalov's avatar
      Revert "gclient_scm: Use cherry-picking instead of rebasing." · 690d8d43
      Andrii Shyshkalov authored
      This reverts commit c9121141.
      
      Reason for revert: broke patch application on infra/config https://crbug.com/853032
      
      Original change's description:
      > gclient_scm: Use cherry-picking instead of rebasing.
      > 
      > We have a problem when in this situation, we checkout |patch| and rebase it on
      > top of |base|, thus including an |extra commit| that we shouldn't.
      > 
      > o master
      > |
      > . o patch
      > |/
      > o extra commit
      > |
      > o base (what gclient synced src at)
      > 
      > This does merge-base between |patch| and |master|, and cherry-picks only the
      > changes belonging to the patch.
      > 
      > Bug: 850812
      > Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
      > Reviewed-on: https://chromium-review.googlesource.com/1098228
      > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      > Reviewed-by: Aaron Gable <agable@chromium.org>
      
      TBR=agable@chromium.org,ehmaldonado@chromium.org
      
      Change-Id: Ib3feeee2f44f5441713383f1dbf08db16fae4717
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 850812, 853032
      Reviewed-on: https://chromium-review.googlesource.com/1101977Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
      690d8d43
    • Edward Lemur's avatar
      gclient_scm: Use cherry-picking instead of rebasing. · c9121141
      Edward Lemur authored
      We have a problem when in this situation, we checkout |patch| and rebase it on
      top of |base|, thus including an |extra commit| that we shouldn't.
      
      o master
      |
      . o patch
      |/
      o extra commit
      |
      o base (what gclient synced src at)
      
      This does merge-base between |patch| and |master|, and cherry-picks only the
      changes belonging to the patch.
      
      Bug: 850812
      Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
      Reviewed-on: https://chromium-review.googlesource.com/1098228
      Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      c9121141
  11. 07 Jun, 2018 1 commit
  12. 11 May, 2018 1 commit
  13. 10 May, 2018 2 commits
  14. 03 May, 2018 1 commit
  15. 08 Apr, 2018 1 commit
  16. 31 Mar, 2018 1 commit
  17. 22 Mar, 2018 1 commit
    • Edward Lesmes's avatar
      gclient sync: Add support to apply gerrit refs. · c621b21a
      Edward Lesmes authored
      Mimics bot_update's functionality to apply gerrit refs in gclient
      via --gerrit-ref flags.
      When the patch fails to apply, gclient sync will return exit code 2.
      
      The idea is to move this logic from bot_update to gclient sync to
      deal when patches for projects like ANGLE are tried on Chromium bots.
      This way the patch is applied before recursively parsing and syncing
      ANGLE’s DEPS.chromium file, which doesn't currently happen.
      
      Bug: 643346
      
      Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18
      Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      c621b21a
  18. 20 Feb, 2018 1 commit
  19. 06 Feb, 2018 1 commit
  20. 12 Oct, 2017 1 commit
    • Dirk Pranke's avatar
      Do not write gclient_gn_args_file too early. · 9f20d020
      Dirk Pranke authored
      Previously, gclient would attempt to write an args file after
      a dependency was checked out, but before any sub-dependencies
      had been checked out. If the args file path pointed at something
      inside a sub-dependency, this wouldn't work, because the directory
      might not yet exist. This most obviously happened for buildspec
      clobber builds.
      
      The fix is to wait until after the sub-dependencies have been
      checked out to write the file.
      
      R=phajdan.jr@chromium.org, mmoss@chromium.org
      BUG=773933
      
      Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23
      Reviewed-on: https://chromium-review.googlesource.com/714644Reviewed-by: 's avatarPaweł Hajdan Jr. <phajdan.jr@chromium.org>
      Commit-Queue: Dirk Pranke <dpranke@chromium.org>
      9f20d020
  21. 02 Oct, 2017 2 commits
  22. 26 Sep, 2017 1 commit
  23. 07 Sep, 2017 1 commit
  24. 18 Aug, 2017 1 commit
  25. 17 Aug, 2017 1 commit
  26. 10 Aug, 2017 2 commits
  27. 09 Aug, 2017 1 commit
  28. 03 Aug, 2017 1 commit
  29. 27 Jul, 2017 1 commit
  30. 25 Jul, 2017 2 commits
    • Paweł Hajdan Jr's avatar
      Revert "gclient flatten: preserve variable placeholders" · 393ba066
      Paweł Hajdan Jr authored
      This reverts commit e79ddeaa.
      
      Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=748486
      
      Original change's description:
      > gclient flatten: preserve variable placeholders
      > 
      > One of the main use cases is making it clear which revision hashes
      > need to be changed together. The way it's usually done is one variable
      > referenced several times. With this CL, we preserve the references
      > from original DEPS, as opposed to evaluating them and losing some info.
      > 
      > This CL actually makes Var() emit a variable placeholder
      > instead of its value, and adds support for these placeholders
      > to gclient.
      > 
      > One of possible next steps might be to deprecate Var().
      > 
      > Bug: 570091
      > Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a
      > Reviewed-on: https://chromium-review.googlesource.com/583617
      > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
      
      TBR=phajdan.jr@chromium.org,dpranke@chromium.org
      
      Change-Id: If9c52ebfa78aba8041ce797ff842d09952d0e2ce
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 570091, 748486
      Reviewed-on: https://chromium-review.googlesource.com/584907Reviewed-by: 's avatarPaweł Hajdan Jr. <phajdan.jr@chromium.org>
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      393ba066
    • Paweł Hajdan, Jr's avatar
      gclient flatten: preserve variable placeholders · e79ddeaa
      Paweł Hajdan, Jr authored
      One of the main use cases is making it clear which revision hashes
      need to be changed together. The way it's usually done is one variable
      referenced several times. With this CL, we preserve the references
      from original DEPS, as opposed to evaluating them and losing some info.
      
      This CL actually makes Var() emit a variable placeholder
      instead of its value, and adds support for these placeholders
      to gclient.
      
      One of possible next steps might be to deprecate Var().
      
      Bug: 570091
      Change-Id: I9b13a691b5203cc284c33a59438720e31c9ebf7a
      Reviewed-on: https://chromium-review.googlesource.com/583617
      Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
      Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
      e79ddeaa
  31. 24 Jul, 2017 1 commit
  32. 06 Jul, 2017 1 commit
  33. 03 Jul, 2017 1 commit