Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 30 Jan, 2020 1 commit
  3. 24 Jan, 2020 1 commit
  5. 17 Jan, 2020 2 commits
  7. 15 Jan, 2020 1 commit
    • Raul Tambre's avatar
      subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75
      Raul Tambre authored 
      Example error during "git cl upload":
Traceback (most recent call last):
  File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
    returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
  File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
    p = subprocess.Popen(cmd, **kwargs)
  File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

Bug: 984182
Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
      e9730d75
  9. 14 Jan, 2020 1 commit
  11. 13 Jan, 2020 3 commits
  13. 10 Jan, 2020 4 commits
  15. 08 Jan, 2020 2 commits
  17. 06 Jan, 2020 3 commits
  19. 19 Dec, 2019 1 commit
  21. 10 Dec, 2019 1 commit
  23. 06 Dec, 2019 1 commit
  25. 04 Dec, 2019 2 commits
  27. 02 Dec, 2019 2 commits
  29. 26 Nov, 2019 1 commit
  31. 25 Nov, 2019 2 commits
  33. 21 Nov, 2019 3 commits
  35. 19 Nov, 2019 1 commit
  37. 15 Nov, 2019 3 commits
  39. 14 Nov, 2019 1 commit
  41. 12 Nov, 2019 1 commit
  43. 11 Nov, 2019 1 commit
  45. 05 Nov, 2019 1 commit
    • danakj's avatar
      Allow the bot_update api to not fetch tags from the git server. · c41f72cf
      danakj authored 
      There are 3 layers modified, starting from the bottom up:

1. git_cache.py populate

Now takes a --no-fetch-tags option. If specified, the cache will not
fetch updated tags from the server by passing --no-tags to git fetch.
This prevents the server from sending all the tag refs. In chromium
this prevents significant time bottlenecks dealing with 10k+ tags.

2. bot_update.py

bot_update has to deal with multiple git repos, it has the root repo
that is checked out through git-cache, as well as repos synched via
DEPS and gclient.

The script now takes a --no_fetch_tags option. If specified,
the git-cache populate call will include --no-fetch-tags. Otherwise, it
won't. So this controls (for chromium) if fetches to the src.git server
are passed --no-tags.

3. bot_update/api.py

This is the entry point for recipes and also has to deal with multiple
git repos. The behaviour at this point is not changed from the default.
A |no_fetch_tags| parameter is added to ensure_checkout() that defaults
to False.


This CL is a refactor with no intended behavior change.

The next step will be to change the chromium build repo to pass True
for ensure_checkout(no_fetch_tags) on chromium trybots.

This represents solution #2 in
https://docs.google.com/document/d/1hDIunJjjfpmr50y3YnZ4o3aq1NZF4gJa1TS0p7AIL64/edit#

Bug: 1019824
Change-Id: I935430603299daa9e301a95a5184c0ce486fd912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894352Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Reviewed-by: 's avatarErik Chen <erikchen@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
      c41f72cf
  47. 04 Nov, 2019 1 commit