• Raul Tambre's avatar
    subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75
    Raul Tambre authored
    Example error during "git cl upload":
    Traceback (most recent call last):
      File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
        returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
      File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
        p = subprocess.Popen(cmd, **kwargs)
      File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
        super(Popen, self).__init__(args, **kwargs)
      File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
        errread, errwrite)
      File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
        startupinfo)
    TypeError: environment can only contain strings
    
    Bug: 984182
    Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
    Commit-Queue: Raul Tambre <raul@tambre.ee>
    Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
    Auto-Submit: Raul Tambre <raul@tambre.ee>
    e9730d75
Name
Last commit
Last update
..
gstools Loading commit data...
OWNERS Loading commit data...
auth_test.py Loading commit data...
bot_update_coverage_test.py Loading commit data...
cipd_bootstrap_test.py Loading commit data...
detect_host_arch_test.py Loading commit data...
download_from_google_storage_unittest.py Loading commit data...
fix_encoding_test.py Loading commit data...
gclient_eval_unittest.py Loading commit data...
gclient_paths_test.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
gerrit_util_test.py Loading commit data...
git_cache_test.py Loading commit data...
git_cl_creds_check_report.txt Loading commit data...
git_cl_test.py Loading commit data...
git_common_test.py Loading commit data...
git_dates_test.py Loading commit data...
git_drover_test.py Loading commit data...
git_footers_test.py Loading commit data...
git_hyper_blame_test.py Loading commit data...
git_map_test.py Loading commit data...
git_number_test.py Loading commit data...
git_rebase_update_test.py Loading commit data...
gsutil_test.py Loading commit data...
metrics_test.py Loading commit data...
ninjalog_uploader_test.py Loading commit data...
owners_finder_test.py Loading commit data...
owners_unittest.py Loading commit data...
presubmit_unittest.py Loading commit data...
recipes_test.py Loading commit data...
roll_dep_test.py Loading commit data...
scm_unittest.py Loading commit data...
subcommand_test.py Loading commit data...
subprocess2_test.py Loading commit data...
upload_to_google_storage_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...