Commits · 280474c2a98564f77ea1a738360b269f5a9b1d0f · Linshizhi / Chromium_Depot_tools

10 Apr, 2019 1 commit

Roll recipe dependencies (trivial). · 280474c2

recipe-roller authored Apr 10, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6c8922f408b3a4f103be5659fa941b2bbe1befb2 Implement copy operations for sentinel. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I15761d9bb442ccccb22b2ec5fcba49ac46743220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1562351Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

280474c2

09 Apr, 2019 1 commit

Roll recipe dependencies (trivial). · 224e075b

recipe-roller authored Apr 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9cbb703d2234f3627a95f2fef0d75ae8e5850f75 [buildbucket] Use bb tool (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifd143d68ce862c188338caa38443350cf2e6e35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1559273Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

224e075b

08 Apr, 2019 1 commit

Fix UTF-8 output in gclient_utils.CheckCallAndFilter · 1fb04630

Raul Tambre authored Apr 08, 2019

Hooks for Electron output UTF-8 characters.
Example error for when "✔" is output:
  File "/home/markus/depot_tools/metrics.py", line 266, in print_notice_and_exit
    yield
  File "/home/markus/depot_tools/gclient.py", line 3112, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/markus/depot_tools/gclient.py", line 3098, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/markus/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/markus/depot_tools/gclient.py", line 2677, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/markus/depot_tools/gclient.py", line 1746, in RunOnDeps
    self.RunHooksRecursively(self._options, pm)
  File "/home/markus/depot_tools/gclient.py", line 1052, in RunHooksRecursively
    hook.run()
  File "/home/markus/depot_tools/gclient.py", line 245, in run
    cmd, cwd=self.effective_cwd, always=self._verbose)
  File "/home/markus/depot_tools/gclient_utils.py", line 344, in CheckCallAndFilterAndHeader
    return CheckCallAndFilter(args, **kwargs)
  File "/home/markus/depot_tools/gclient_utils.py", line 576, in CheckCallAndFilter
    stdout.write(in_byte.decode())
  File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xe2 in position 0: unexpected end of data

This issue was introduced in CL:1524583.

Bug: 942522
Change-Id: I3c4355b925b34398c800d142f942531a829e0297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541334
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>

1fb04630

05 Apr, 2019 4 commits

Revert "[bot_update] Default to refs/heads/master" · 0b62ed79

John Budorick authored Apr 05, 2019

This reverts commit 9198ef8e.

Reason for revert: Spec revert: appears to be causing large number of chromium CQ failures on patch application.

Original change's description:
> [bot_update] Default to refs/heads/master
> 
> When revision is not specified, currently HEAD is checked out.
> Change the default to refs/heads/master
> 
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 940214
> Change-Id: I8be59095d90447ea898d5247a6433f0734f5e63b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554862
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,jbudorick@chromium.org

Change-Id: Icafd817d8f044a4347342bd85dc97d193329a704
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 940214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1555514Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

0b62ed79

[bot_update] Default to refs/heads/master · 9198ef8e

Nodir Turakulov authored Apr 05, 2019

When revision is not specified, currently HEAD is checked out.
Change the default to refs/heads/master

Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 940214
Change-Id: I8be59095d90447ea898d5247a6433f0734f5e63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554862
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

9198ef8e

Roll recipe dependencies (trivial). · 837c8e52

recipe-roller authored Apr 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/51acda8019760f9d510d3b3343a934c0fddcd7d0 [buildbucket] Add is_critical help function (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I44b88829652dce778801a1fb9fa6abd46dd27b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554981Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

837c8e52

Roll recipe dependencies (trivial). · 549bde19

recipe-roller authored Apr 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4885460fce04564eccdc6d03503934ec32fcc0c9 Exit early if required binaries aren't found on PATH (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9f8be975844a6a1edecf7f2a4dccf01c8e1f83a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554019Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

549bde19

04 Apr, 2019 2 commits

Add gclient recipe_modules config for emscripten_releases LUCI project · dbc721d6

Derek Schuff authored Apr 04, 2019

Bug: https://bugs.chromium.org/p/v8/issues/detail?id=8936
Change-Id: Ia21ccbbffc6ad3614b9b73a6aefbb2a041f96a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1554013
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

dbc721d6

Roll vpython to git_revision:2973c0809cdc7122b7123e42b163a54d4983503f. · 9f74913e

John Budorick authored Apr 04, 2019

Bug: 947242
Change-Id: I459f6fc814918f9f0e7eedfc534132a64a3aa7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549221
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

9f74913e

03 Apr, 2019 3 commits

Reland "git cl status: differentiate "dry-run" from generic "commit"." · b8268cad

Andrii Shyshkalov authored Apr 03, 2019

This is a reland of 3c830222 with a fix.
Previous CL relied on summary data of CQ votes provided by Gerrit,
which apparently isn't always present in the way I expected.
This resulted in "git cl status" returning "lgtm" instead of "commit"
on Skia recipe roll CLs, which resulted in recipe roller abandoning CLs,
and creating new ones (there might be a bug in recipe roller, too).

The fix is to iterate over all votes on CQ label and finding the highest
score, and then deciding on the state.

Original change's description:
> git cl status: differentiate "dry-run" from generic "commit".
>
> CQ vote       now       before
>   +2       "commit"    "commit"
>   +1       "dry-run"   "commit"
>
> R=ehmaldonado
>
> Tested: manual "git cl status" run locally.
> Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: If9af5a2bf8f21d203b7a62740a27916eca0838ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549640
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

b8268cad

Add angle_root custom var to ANGLE gclient config. · 25eb154c

Jamie Madill authored Apr 03, 2019

This should allow for any recipe that uses the ANGLE repo to run
gclient sync with the right folder structure. Currently gclient sync
will check out third_party directories to the wrong folder.

Bug: angleproject:3288
Change-Id: Ia97592fdc0c9f3ec70c2d4a05d9934a6bc996507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1551019Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

25eb154c

[bb] Deploy bb · 865445eb

Nodir Turakulov authored Apr 03, 2019

Add bb to depot_tools

Bug: 946422
Change-Id: I7f1e5463b7bb1170124c94066b660a1b972884bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1550200
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

865445eb

02 Apr, 2019 7 commits

[lucicfg] Bump lucicfg version v1.5.12 -> v1.6.0. · 52f1494c

Vadim Shtayura authored Apr 02, 2019

Changes:
2019-04-02 vadimsh@chromium.org [lucicfg] Rename 'recipe = ...' field into 'executable = ...'.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of CQ configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Accept non-standard text protos as input of semantic-diff.
2019-04-02 vadimsh@chromium.org [lucicfg] Remove header IDs from normalized Milo configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of Milo configs.
2019-04-02 vadimsh@chromium.org [lucicfg] Implement semantic diff of Scheduler configs.

TBR=tandrii@chromium.org

Change-Id: I1ace2edb3a2b686d069dbfb3d753ecc2540f01fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549945Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

52f1494c

gclient_scm: Simplify fetching refs. · 9a5e3bd8

Edward Lemur authored Apr 02, 2019

Bug: 874501, 942229
Change-Id: Ie9896e8a289e32a1b468ed5fa51c95a81970bdf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544802
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

9a5e3bd8

Add ANGLE revision to gclient config. · 422c432d

Jamie Madill authored Apr 02, 2019

Bug: angleproject:3339
Change-Id: I1508937b5a367ed732231996c1b24588be5df9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549645
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

422c432d

[bot_update] Set output commit of the build · fdd25811

Nodir Turakulov authored Apr 02, 2019

Add set_output_commit param to bot_update.ensure_checkout, false by default.
If true, call api.buildbucket.set_output_gitiles_commit to set the output commit
of the build. This generally supersedes got_revision and got_revision_cp.

Bug: 940214
Change-Id: I5ffc790a6b12c8bf4a56469b3ecc567141c0d735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548256Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

fdd25811

Revert "git cl status: differentiate "dry-run" from generic "commit"." · c1e4405d

Andrii Shyshkalov authored Apr 02, 2019

This reverts commit 3c830222.

Reason for revert: broke recipe roller.

Original change's description:
> git cl status: differentiate "dry-run" from generic "commit".
> 
> CQ vote       now       before
>   +2       "commit"    "commit"
>   +1       "dry-run"   "commit"
> 
> R=ehmaldonado
> 
> Tested: manual "git cl status" run locally.
> Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I1c7597e52f860c9b03c9f9505bda274bed32fc2a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1549639Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

c1e4405d

roll_dep: update blacklist with new recipe roller. · e30d0513

Andrii Shyshkalov authored Apr 02, 2019

R=maruel

Change-Id: Iebe989314c9dffa5b433641c4f099806291350f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548718
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

e30d0513

git cl status: differentiate "dry-run" from generic "commit". · 3c830222

Andrii Shyshkalov authored Apr 02, 2019

CQ vote       now       before
  +2       "commit"    "commit"
  +1       "dry-run"   "commit"

R=ehmaldonado

Tested: manual "git cl status" run locally.
Change-Id: I342a3ac0830a67bf0e722c737ef00460a0df4b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1548287
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

3c830222

29 Mar, 2019 7 commits

Roll recipe dependencies (trivial). · 8d3ba463

recipe-roller authored Mar 29, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8f658073e9df9d182ce6bb39cf2406e1a5ade7dd [buildbucket] Require commit ref (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d4623423a7332ba8d2c3afb053f9358b627645d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544867Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8d3ba463

Roll recipe dependencies (trivial). · f6e36097

recipe-roller authored Mar 29, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6af8640f4269b14122fa7eb4339a248c871855a1 [buildbucket] Add "critical" parameter (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie60c5f7ad484b52a191b187a70f35754a1996cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546385Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f6e36097

[lucicfg] Bump lucicfg version v1.5.6 -> v1.5.12. · 047b0231

Vadim Shtayura authored Mar 29, 2019

Changes:
2019-03-29 vadimsh@chromium.org [lucicfg] Add native support for luci-notify email templates.
2019-03-29 vadimsh@chromium.org [lucicfg] Move normalization code into a separate package, clean it up.
2019-03-28 vadimsh@chromium.org [lucicfg] Use full file path when matching against tracked_files patterns.
2019-03-28 vadimsh@chromium.org [lucicfg] Add lucicfg.emit(...) function.
2019-03-28 vadimsh@chromium.org [lucicfg] Fix a confusing error when using None as dimension value.
2019-03-28 vadimsh@chromium.org [lucicfg] Catch up to recent-ish config proto changes.
2019-03-25 vadimsh@chromium.org [lucicfg] Fix bug in luci.notifier(...).
2019-03-22 vadimsh@chromium.org [lucicfg] Add lucicfg.check_version(...).
2019-03-22 vadimsh@chromium.org [lucicfg] Add luci-notify.cfg support.

TBR=tandrii@chromium.org

Change-Id: Ia3a8261adccc531949ee59004098052b7f084d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546379Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

047b0231

Roll recipe dependencies (trivial). · ff79e7ea

recipe-roller authored Mar 29, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/db94883c139d0588a78098babdd45750a9145fb4 Add better validataion for engine_step.TriggerSpec. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I512fe7fa01b13a70e91def42c4138a8d6cadbfc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1546209Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ff79e7ea

Throw error for unicode URLs in .gclient · d19589ff

Raul Tambre authored Mar 29, 2019

This is no longer supported to make the move to Python 3 easier.
Only some very old/weird user configurations may have this, so this provides a clear actionable error message.

Bug: 942522
Change-Id: I88106089c53d84b19c4f77b7e60fe251082122d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1539957Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>

d19589ff

Roll recipe dependencies (trivial). · e2d41fe9

recipe-roller authored Mar 29, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/94845e3a38c887497c7e843cd715e55bcdfc494f Add better validataion for engine_step.EnvAffix (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida0620389056c22933931209a39a5906e237592d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1545279Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e2d41fe9

Roll recipe dependencies (trivial). · 803c8692

recipe-roller authored Mar 29, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e1bd7abedaddbd8513adbce310eb11777f2a3084 [fetch] Mark commits which touch .gitattributes as "interesting". (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icd89dd9d171ba83f75e2ed7399f83d07d09ece51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1545273Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

803c8692

28 Mar, 2019 6 commits

gclient: Support syncing deps to refs/{branch-heads,tags}:revision. · bdbe07f2

Edward Lemur authored Mar 28, 2019

Arbitrary refs (i.e. syncing to refs/arbitrary/stuff:revision) is not
guaranteed to work.

Bug: 874501, 942229
Change-Id: If08f0d9ae257e3d9f486d3ea6b310c8d94d3b918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1542588Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Karen Qian <karenqian@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

bdbe07f2

Roll recipe dependencies (trivial). · f36fc435

recipe-roller authored Mar 28, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/48f7d09ba6cca243c582f8e6eb80bd10a0ff161c Add the ability to use lambdas as post-processing hooks. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id96d5d8155a869815634f1a90aab79674ca39a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544743Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f36fc435

Roll recipe dependencies (trivial). · d3d7e208

recipe-roller authored Mar 28, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c53035c7c222ad781a4e941cda966d43cea464bb [recipes.py] Do a git-clean after asserting the current revision. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6259150061c95e6506a611ab5c2568665eda45c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544335Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d3d7e208

Roll recipe dependencies (trivial). · 53fd4dc1

recipe-roller authored Mar 28, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/16c546d0ec115133051c875e5121eab17c54bb45 Update the ignores for checkers to include the steps dictionary. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I695a2082ca1d2caf6b6e4d5c69ed3c1910b63df6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544333Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

53fd4dc1

Roll recipe dependencies (trivial). · 4960c0da

recipe-roller authored Mar 28, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c8d755745eb947ba80699604b6e747a6a3047916 Fix incorrect comment. (garymm@google.com)
  https://crrev.com/4b03702efa1413999e5ecd2e3f80a032936667ba Fix docstring for post_process.PropertiesDoNotContain (erikchen@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I28cae4767d8d880abf05098b90f0acab35338793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1544329Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4960c0da

Make git-nav-upstream use the upstream branch name · e989bb2b

Leszek Swirski authored Mar 28, 2019

The previous git-nav-upstream fix used the current branch name, and
stored the upstream move relative to that branch (in the reflog), e.g
nav-upstream from branch foo to origin/master would should foo@{u}.
This unfortunately breaks if the branch is then deleted, so now we
calculate the upstream branch before checking it out, by passing
"@{u}" rather than HEAD to rev-parse.

Change-Id: I14a2eb8493d63e8386e988fd68b8a3125f19ce2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1536070
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

e989bb2b

27 Mar, 2019 3 commits

Roll recipe dependencies (trivial). · 51c0f388

recipe-roller authored Mar 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5c579aefde72744956934c8805273cd43f53cd1d Move StepConfig and friends to their own module, engine_step. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3568d6356b823e3fab0cfa55f587126ce1ccf361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541971Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

51c0f388

Roll recipe dependencies (nontrivial). · ffac5b50

recipe-roller authored Mar 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/80e1d4b24dded35128a888c2de959ccd0dd8d140 Remove step exit code from test expectations. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I80cb55f6c4f2e3352accff09a15d8eceaa2c525c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541737
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

ffac5b50

Roll recipe dependencies (trivial). · c74cce1e

recipe-roller authored Mar 27, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b37679d2f44240b461114360ae38e0d974f44119 Add more post process expectation annotations. (erikchen@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa435304164715af4509df796354dff9979aaa96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1540504Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c74cce1e

26 Mar, 2019 4 commits

Roll recipe dependencies (trivial). · 5d732177

recipe-roller authored Mar 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a4f9a8b3ac3195aab9c10e1dfa15a46edc4fb190 Convert newline characters in step_text to html breaks. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I307832c44d5f82f46c5443d333fba41cd207fd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1539733Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5d732177

Improve gclient Python 3 compatibility · b946b238

Raul Tambre authored Mar 26, 2019

This enables gclient sync and gclient runhooks to run, barring hook script failures.
git cl upload also now works.

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 942522
Change-Id: I2ac587b5f803ba7f5bb5e412337ce049f4b1a741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524583
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

b946b238

fake_repos: Create a new socket for every connection attempt while waiting for a port · b45f6428

Raphael Kubo da Costa authored Mar 26, 2019

connect(2) says stream sockets may only succeed to connect once. This means
if the call to sock.connect() fails it will continue failing for the
entirety of the wait loop, and we will fail to wait for a port to bind even
when it eventually becomes available.

Make sure we create a new socket every time we are about to try to connect
to it.

Change-Id: I16d7dbea3590c5bf7f7240bdefcc5ec0bcd1edb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1528291
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

b45f6428

[led] Update led. · e17d1ed6

Robert Iannucci authored Mar 26, 2019

e4631c9c5 [kitchen] Merge *_logdog*.go files
d40f4d024 [kitchen] Remove git bootstrap of recipes.
e05b2c063 [led] Default led tasks to experimental mode.
d20372830 [led] Automatically add user tag to led tasks.

R=nodir@chromium.org, tandrii@chromium.org

Change-Id: I0b96fee28b88ef32aaaa1fca00aedc06b07266d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1539106
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

e17d1ed6

25 Mar, 2019 1 commit

Make git cl issue handle bad arguments more gracefully. · 5a368d4d

Lei Zhang authored Mar 25, 2019

Running "git cl issue -r invalid_input" will now produce an error
message and continue, instead of crashing with a stacktrace.

Change-Id: I17626a513df904a1a3ff725ec7a17e8541db6bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1538978Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

5a368d4d