- 27 Apr, 2020 5 commits
-
-
Takuto Ikuta authored
This reverts commit 8533236d. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086/4#message-dcd4603d5914c681d0e1ad498e7bb9b59576a24d Original change's description: > git_cl: add --parallel for yapf > > see > https://github.com/google/yapf#usage > > Bug: 1073708 > Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073708 Change-Id: Ib8245dca57a11a386e78089630df61ff773b1789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168971Reviewed-by:
Aaron Gable <agable@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Edward Lesmes authored
The support for Dart in canned_checks.CheckPatchFormatted can be removed. It was used in Chromium, when Chromium included a Dart SDK in its checkout. Dart was removed from Chromium years ago, and none of the current Dart repositories use this in their presubmit. Current repositories using Dart and depot_tools are dart.googlesource.com/sdk and Flutter engine. The SDK source tree has extensive custom code written for format checking in the presubmit, and Flutter engine has none. So adapting the exiting code to work with a new SDK location, or searching the path for any Dart SDK (which would be too fragile) would not be useful for these projects. The support code was introduced in: https://codereview.chromium.org/933383002 Bug: 1075502 Change-Id: I1ceed1ed6c1b4ff05071b0db1c52016f03c47c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2168851Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
R=apolito@google.com, ehmaldonado@chromium.org Bug: 1074355 Change-Id: Id2d5c8ca6f27fefb0fe8d769ae2e50dbaaddadbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167221Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/a1f700042dd072e39d521f74c71bea4f488282eb (yiwzhang@google.com) [warning] add user guide for warning feature in recipe engine More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia1c601b76b74c87f1543c965c2474a8b469fec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2167224Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/d305b98624bda32f20b4b4a25499f3e8464a3868 (olivernewman@google.com) [swarming] Add `verbose` argument to collect() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3c44602b3cd09aaeaa93fb4b2572d6562959d1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166819Reviewed-by:
-
- 24 Apr, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/1362e821b88409d2bde0c95b65813f9f5daf701a (iannucci@chromium.org) [pywin32] Remove pywin32 dependency completely. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib3a65fb390502e380df7d15ab3bd0dc254571f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2166148Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/3a620b0ada4e8b3aa6c436828d94cdaf0eef3086 (olivernewman@google.com) [swarming] Pass -verbose to collect More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifac46fbe076199cf5569c69a95936d03ee0d4173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2165419Reviewed-by:
-
- 23 Apr, 2020 11 commits
-
-
Josip Sokcevic authored
Use ISO8601 time format standard to avoid localized result and need to encode. R=ehmaldonado@chromium.org Bug: 1074002 Change-Id: I95c2ddd55a9661351f2b45601f7bba24c2951c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163401Reviewed-by:
-
Fletcher Woodruff authored
There is a cpplint include check that ensures that all includes have a directory name preceding them. However, if all source lives in the root of a repository, there is no point in having a directory. Because this check lives under 'build/include', it's impossible to filter without filtering other useful checks. Move it to 'build/include_directory' so it can be more easily filtered. BUG=chromium:1073191 TEST=cros lint on a file with 'filter=-build/include_directory' in CPPLINT.cfg Change-Id: Ie15fb2398a6d0297ef96219e67076ea262abf853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159690Reviewed-by: -
Takuto Ikuta authored
see https://github.com/google/yapf#usage Bug: 1073708 Change-Id: I09a327e44bfcf5cf9a59c4e8d470a8886fc9f44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163086 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
see https://github.com/google/yapf#usage Bug: 1073708 Change-Id: I3824bbecc6c52d6b7f82aaa05e5108a8619124d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162227Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/fed4eae33606a63ad477a80c895e965bb929f69e (yiwzhang@google.com) [luciexe] Fix the issue where build status is not properly updated More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9b32a1dae9a51bb9b68078f1dc893abedef7f806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163198Reviewed-by:
-
Josip Sokcevic authored
Reverted commit 4511b131 had a bug where squash_ret.success = True and empty_rebase = False. In that case, stdout and stderr would already be string and trying to decode would fail. Bug: 1071280 Change-Id: Iadcc526147ebb98aa7a91a7daa64ef44066e83b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163387 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Bruce Dawson authored
Slashes and backslashes are interchangeable on Windows in many contexts. But not all. In particular, if you add a path to a dictionary and then try looking it up with an equivalent path that has different slashes then - not surprisingly - the lookup will fail. Therefore it is important to always use slashes when populating _paths_to_owners. This is now done, and documented. Additionally, while fnmatch.fnmatch handles comparing slash separated paths to backslash separated paths, fnmatch.translate does not. This is arguably a bug in fnmatch.translate, or at least something that should be documented. This bug is worked around by having _fnmatch sanitize file names to always use slashes, and asserting that the patterns do not contain backslashes. With these changes this command: git cl owners --ignore-current --show-all chrome/browser/BUILD.gn now correctly gives the same results as this command on Windows: git cl owners --ignore-current --show-all chrome\browser\BUILD.gn The modified test fails without the other changes, passes with them. Bug: 1009104 Change-Id: I416c7131281f00e352c1d2b85c30fcc463417fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1915410 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/ac4b520aa1f7a8cec925349bc7cf6c3a2d0fb78c (olivernewman@google.com) [swarming] Add eager argument to collect() More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ida26f1bd4a50d28e95bd989b15cb19de6fc40828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2163186Reviewed-by:
-
Wez authored
This reverts commit 4511b131. Reason for revert: Broke git_rebase_update.py under Python3, which does not support calling decode() on string objects. Original change's description: > Fix printing error on git-rebase failure > > R=ehmaldonado@chromium.org > > Bug: 1071280 > Change-Id: I8b1f00bb7c454297b10d5e047ae35c2686f69fb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2155154 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071280, 1073768 Change-Id: I58c1b24ba2aef255068c81be25475b2abbbf4fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161111Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/3559ca4d7586d19e6e3d548a5708b32d64a3c08a (mseaborn@google.com) [swarming] Sort dictionary keys when constructing swarming request More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibe9775200beaaa743fc7bc03bb88032ce3f490f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2162145Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/36f4d31f57f0ab3d5e6925a724dced97cc3eeac2 (mseaborn@google.com) [file][json] Sort dictionary keys when writing JSON data More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I27f2d22bf8f032256adcbed9f60b10c5c3320ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161902Reviewed-by:
-
- 22 Apr, 2020 7 commits
-
-
Josip Sokcevic authored
Users can still set GCLIENT_PY3=0 to use Python 2. R=ehmaldonado@chromium.org Change-Id: Ic7657a091bfe3b9c426ab36063b106aadf2d1c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161266 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Allen Bauer authored
Change-Id: I30284634b2c5bdf1d155fe2f8d6f72538c9e2f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161634 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/9c7dd835e208fa6268d7c06f0ba15823b257b4bb (iannucci@chromium.org) [vpython] Bump version of pywin32 to 227. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0afd28e145f05ecae5c87332e4807fe7bbc7e0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161270Reviewed-by:
-
Robert Iannucci authored
Having it in %PATH% means that powershell users will accidentally run 'cipd.ps1' when they should be running 'cipd.bat'; This would cause them to get requests for input parameters (like the backend URL) which they have no idea how to supply. R=agable@chromium.org, nodir@chromium.org, vadimsh@google.com Bug: 1073529 Change-Id: I62a3bd9e00229a2047293dba1ba480d28f77bf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2161645Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/096f05fa40b6864c8d22e6df8e154e43d7c778c6 (jsca@google.com) Add milo recipe module. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4c91f04e85e69605beb6df1a5da91e33041f48a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160407Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/940d2483cca29dba541c42f1bdb6d33745269e97 (yekuang@google.com) Roll swarming client version More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia332e0d33da35942374efdd379dd2bd9eba361c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2160214Reviewed-by:
-
Dale Curtis authored
This avoids the toolchain being wiped after using WinDbg. Bug: None Change-Id: I989ef7744b46254bab4c5a707724dc38a9b9a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159998 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org>
-
- 21 Apr, 2020 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/19949b53d1682935c77c39354dd6b3b0056bdd24 (chanli@chromium.org) [Resultdb] Add function `exonerate` in resultdb recipe module More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iefe2a6f510e5be4c84a6515b0afffdc2b7a559ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2159697Reviewed-by:
-
Anthony Polito authored
Bug: 1070694, b/154543469 Change-Id: I5099e3bb8c1aa9d3003d82e7dbb545fc75a1f749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157801Reviewed-by:
-
- 20 Apr, 2020 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/05e3d21945daf81423e55c5eb908d1782c133873 (iannucci@chromium.org) Add led job.proto and update all luci-go protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I90b91a5b8019dd8c57ff7bdfbb3897f1d5ecd180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157797Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/47e1e46fc93780eb49c1e650c0fb2bae3dcf57e4 (engeg@google.com) recipe_engine: add current time to execution details More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifbe932d96c8e67a75653e0c908c8004125bb7c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157794Reviewed-by:
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Bug: 1071280 Change-Id: I8b1f00bb7c454297b10d5e047ae35c2686f69fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2155154Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/31687e34cb0c12d242f4be77826e6f073a573690 (iannucci@chromium.org) [recipe_modules/proto] Add new module for manipulating proto data. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifea252adbfc83b3484c3325db5e0eeb3c26a9f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2157787Reviewed-by:
-
- 17 Apr, 2020 2 commits
-
-
Milad Farazmand authored
Running `fetch v8` with Python 3.5 produces the following error: TypeError: the JSON object must be str, not 'bytes' Adding `.decode("utf-8")` makes it compatible with both versions. Change-Id: Ib0699b61b24f191559c30f1e7ca8d2c919803d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2154108Reviewed-by: -
George Engelbrecht authored
We've had reliability issues with gerrit, primarily related to 429 status codes but also DDoS bans. The light DDoS bans can be very short lived and we extend retries to handle this. Longer term bans can take up to an hour to lift. BUG=chromium:1071590 TEST=./gerrit_client_test.py Change-Id: Iaf68c0d9cc7375aa58367ec0447d54a99f8ebf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2153089 Commit-Queue: George Engelbrecht <engeg@google.com> Reviewed-by:
Mike Frysinger <vapier@chromium.org>
-
- 16 Apr, 2020 3 commits
-
-
Andrii Shyshkalov authored
Change-Id: I71ae8e94ec0cc5d880c002c7187351ac6ee2c2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2152218 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
-
Derek Morris authored
Cpplint.py supports checking for spaces in front of square brackets; this is a style violation in most cases (with the typical case being arrays), but there are already situations where this rule is skipped for the square bracket used for lambda captures. We add another such exclusion here for the case of c++ attributes. Change-Id: I2d4f972be29f5427cb8d855787c90dfa5d610e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2151125 Commit-Queue: Derek Morris <demorri@microsoft.com> Reviewed-by:
-
Erik Staab authored
Change-Id: I80f53f1130ba1dd17c886b14a5737d30394604f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2152004Reviewed-by:
-
- 15 Apr, 2020 4 commits
-
-
Andrew Grieve authored
Fixed by switching "stat()" to "lstat()". Does not seem to be a python3 vs python2 thing (fails on py2 as well). Bug: 1071066 Change-Id: I7eea9ed39b43e09ae2f7558bf23c12581f02e4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2150507Reviewed-by:
-
Edward Lesmes authored
This is a reland of 310e1e81 Use subprocess2, which will set shell=True when running on Windows. Original change's description: > metrics: Use vpython3 instead of sys.executable > > Apparently, uploading metrics might happen after sys.executable > has been deleted. > > Bug: 1068263 > Change-Id: Id4ab465bb97d146b688f42fb2002e29372e65555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2148879 > Commit-Queue: Anthony Polito <apolito@google.com> > Reviewed-by: Anthony Polito <apolito@google.com> Bug: 1068263 Change-Id: I19c915f3e8862ae3248b01e0eccdbdf0bfda7369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2150170Reviewed-by:
-
Edward Lesmes authored
The bug is caused because we already have refs/branch-heads/XXXX locally, so we don't attempt to fetch it again, even if it has been updated. This solution is a bit of a hack to make sure that we fetch refs/branch-heads/*, which is the most common case for this to fail. Bug: 1070545 Change-Id: Iec7cfff18219794230188e2b9e901c587acd274b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149849 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lesmes authored
This reverts commit 310e1e81. Reason for revert: "vpython3" doesn't work on Windows without shell Original change's description: > metrics: Use vpython3 instead of sys.executable > > Apparently, uploading metrics might happen after sys.executable > has been deleted. > > Bug: 1068263 > Change-Id: Id4ab465bb97d146b688f42fb2002e29372e65555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2148879 > Commit-Queue: Anthony Polito <apolito@google.com> > Reviewed-by: Anthony Polito <apolito@google.com> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: I6b9998de0d3afeda142971f889361fb1c8a37a0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2149762Reviewed-by:
-
