Commits · 22e7a27c297e437aebb589eed636628403cbbe21 · Linshizhi / Chromium_Depot_tools

08 Feb, 2017 2 commits

roll-dep: Add command used to make the roll in the CL description. · 22e7a27c

Marc-Antoine Ruel authored Feb 08, 2017

That's marketing 101. :)

R=sergeyberezin@chromium.org
BUG=

Change-Id: Ibbc1cd18650b7b601c27662fcb40ea7b15b40fc7
Reviewed-on: https://chromium-review.googlesource.com/439006Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

22e7a27c

Manual roll of raw_io output -> output_text refactor · 0551f867

Stephen Martinis authored Feb 08, 2017

BUG=686280,664352
TBR=iannucci

Change-Id: Ibd1feadffc440ea01790abe2bc73fc6a69092f54
Reviewed-on: https://chromium-review.googlesource.com/437821Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

0551f867

07 Feb, 2017 2 commits

Add presubmit_support.EnsureCQIncludeTrybotsAreAdded. · 1678a364

Kenneth Russell authored Feb 07, 2017

The PostUploadHooks in the Chromium repository which add
CQ_INCLUDE_TRYBOTS entries to the issue description will be rewritten
in terms of this primitive, which will compose properly if multiple
sub-directories attempt to modify it.

BUG=688765

Change-Id: Icf72edb872f29af1e082038e96bc547504edfd07
Reviewed-on: https://chromium-review.googlesource.com/438925Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

1678a364

Remove svn support from tryserver module · 52a23b35

Stephen Martinis authored Feb 06, 2017

Change-Id: Ic6109dff73f6726c1b50d107dc0996d1a0d0fcf4
Reviewed-on: https://chromium-review.googlesource.com/437637
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

52a23b35

06 Feb, 2017 3 commits

Fix typo in exclude file name · 328b00f9

Marc-Antoine Ruel authored Feb 04, 2017

R=agable@chromium.org
BUG=

Change-Id: I744627d99454ddc71184b9251cf8a4a309f31b71
Reviewed-on: https://chromium-review.googlesource.com/437663Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

328b00f9

git cl for Gerrit: add support for local git cache checkouts. · e9c78ffc

Andrii Shyshkalov authored Feb 06, 2017

R=machenbach@chromium.org
BUG=689035

Change-Id: Ib7a56c52501a5d0dd6638a99bde3d376bd27bfb6
Reviewed-on: https://chromium-review.googlesource.com/438347Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e9c78ffc

roll cipd client · c907608a

Nodir Turakulov authored Feb 06, 2017

Roll CIPD client in CIPD recipe module to version
git_revision:0f49ce7d793b80877633ed640c89547ece130abb

BUG=688918

Change-Id: Id4dbdc89a5b6b7d151996acb5ac6be4df7f4a5f0
Reviewed-on: https://chromium-review.googlesource.com/437993
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Emma Söderberg <emso@chromium.org>

c907608a

03 Feb, 2017 5 commits

Roll recipe dependencies (trivial). · 85adaa34

recipe-roller authored Feb 03, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5d4666c5340082e7bfad85ee01d47ebbc48aeab6 [path] Improve abs_to_path to include resource paths. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2677753002

85adaa34

[cipd module] small cleanups in preparation for cipd 1.5. · a92e37a4

Robert Iannucci authored Feb 03, 2017

Also bumps cipd client version to ac753ee37abd753a9a511210d3df362d003211f0.

BUG=

Change-Id: I5bb005eb603fd7106d8cf6125dc2cda3c6e1ac94
Reviewed-on: https://chromium-review.googlesource.com/436904
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

a92e37a4

Roll recipe dependencies (trivial). · bf10708b

recipe-roller authored Feb 03, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/1c4786ae10b3b4f17c2893cea345725c4a8cd135 [step|docs] Improve the nest docstring a bit. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2673583004

bf10708b

Roll recipe dependencies (trivial). · 9d691d64

recipe-roller authored Feb 03, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/77da9cfa8ca5cdf3d01c1ef30425d17af1f99592 [recipe_engine] Fix unnecessary plurality (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2672843004

9d691d64

Roll recipe dependencies (trivial). · f8fcfd8e

recipe-roller authored Feb 03, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/37a1da981d744246d14a2c2e6fac554703ea4b1b [recipe_engine] Fix a couple path-related bugs. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2675613003

f8fcfd8e

02 Feb, 2017 2 commits

git-cl: don't prompt after cleaning patchset title · eb3af715

Aaron Gable authored Feb 02, 2017

BUG=688099

Change-Id: Ic505ab6553b1a9f1e6ab51377bb6519d805a847e
Reviewed-on: https://chromium-review.googlesource.com/436406Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

eb3af715

Roll recipe dependencies (trivial). · 2a6c76ea

recipe-roller authored Feb 02, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a7a17ae6545a9ff04b71b3655ff4d08a0de32926 [recipe_modules/path] add abs_to_path. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2674593002

2a6c76ea

01 Feb, 2017 1 commit

Roll recipe dependencies (trivial). · ae2e55b7

recipe-roller authored Feb 01, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0e4d4e97edb04696b0b1452522eb26f1dc633e8e step: expose methods to read values from context (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2667863006

ae2e55b7

31 Jan, 2017 2 commits

Roll recipe dependencies (trivial). · 6db8ac71

recipe-roller authored Jan 31, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4fb4d4bdfda85253b842648abf8588749c68a5eb Fix multi-repo workflow overrides and add tests (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2666123002

6db8ac71

Andrii Shyshkalov authored Jan 31, 2017

R=machenbach@chromium.org
BUG=685318

Change-Id: I61192392eec98ad6b9a32ef933f2d22cf2aedd0e
Reviewed-on: https://chromium-review.googlesource.com/435318
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

71b8e66f

30 Jan, 2017 1 commit

Roll recipe dependencies (trivial). · 9d32e4c1

recipe-roller authored Jan 30, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/30a672d26b45289947783932d8062fc70dfb1611 Make it possible to override more than one package (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2664843003

9d32e4c1

29 Jan, 2017 1 commit

Follow up on Gerrit git cl status: do not treat CQ comment as reviewer reply. · 7afd1646

Andrii Shyshkalov authored Jan 29, 2017

TBR=sergiyb@chromium.org,agable@chromium.org
BUG=

Change-Id: I37f02556f254fbdc78ab30e990a7cc6d05120038
Reviewed-on: https://chromium-review.googlesource.com/434477Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

7afd1646

27 Jan, 2017 3 commits

Gerrit git cl status: do not treat CQ comment as reviewer reply. · 33e88a4e

Andrii Shyshkalov authored Jan 27, 2017

R=sergiyb@chromium.org,agable@chromium.org
BUG=

Change-Id: I7684923c19fe7441cdd52b7707c28f01c95a4ba4
Reviewed-on: https://chromium-review.googlesource.com/433699
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

33e88a4e

Roll recipe dependencies (trivial). · fe637498

recipe-roller authored Jan 27, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b120624b72ec851b0d9f2accccf58e525555be25 step: make all args to __call__ explicit (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2656133003

fe637498

Roll recipe dependencies (trivial). · a732e984

recipe-roller authored Jan 27, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/bbcf1dc6436d1f89ffd35fe3354b9ee7701e272a Whitelisting python's copy module for recipes. (robertocn@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2660583002

a732e984

26 Jan, 2017 5 commits

git cl try: reduce number of RPCs to Gerrit from 3 to 1. · eadad92e

Andrii Shyshkalov authored Jan 26, 2017

R=agable@chromium.org
BUG=681704

Change-Id: I3c0ab781e0357e0855d50157c5653df57f68ac9a
Reviewed-on: https://chromium-review.googlesource.com/432336Reviewed-by: Aaron Gable <agable@chromium.org>

eadad92e

git cl: reduce number of Gerrit RPCs in status check. · 8039be7c

Andrii Shyshkalov authored Jan 26, 2017

Also fixes git cl description <url> by propagating codereview host information
in all cases.

BUG=681704
R=agable@chromium.org

Change-Id: Ia79c10b19d72b5a8797a1428ad8a79c8f4480901
Reviewed-on: https://chromium-review.googlesource.com/431036Reviewed-by: Aaron Gable <agable@chromium.org>

8039be7c

git cl: refactor tests to account for Gerrit GetChangeDetail RPCs. · 8fc0c1d8

Andrii Shyshkalov authored Jan 26, 2017

BUG=681704

Change-Id: I7c8fd09f3c19b9facf876ebeef853e5d77b72a9c
Reviewed-on: https://chromium-review.googlesource.com/432316Reviewed-by: Aaron Gable <agable@chromium.org>

8fc0c1d8

Fix git cl upload --dependencies for Gerrit. · 1090fd5b

Andrii Shyshkalov authored Jan 26, 2017

BUG=640299
R=rmistry@chromium.org,agable@chromium.org

Change-Id: Iac987758065c57a4a08ce98f838fc0c30a8c1a02
Reviewed-on: https://chromium-review.googlesource.com/432676
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

1090fd5b

Fix git-crrev-parse returning reverted commits instead of original commits · 056bef20

Jeff Carpenter authored Jan 25, 2017

Also delete extraneous whitespace

BUG=685326

Change-Id: If7f68346fd27edf9a5dca315cfcfbca0decc2da6
Reviewed-on: https://chromium-review.googlesource.com/433158Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

056bef20

25 Jan, 2017 9 commits

Remove stip@ from OWNERS. · 8adfedcf

Mike Stipicevic authored Jan 25, 2017

Change-Id: Id841c4720996ca3568cec8a5721469c34f00cf77
Reviewed-on: https://chromium-review.googlesource.com/431803
Commit-Queue: Mike Stipicevic <stip@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

8adfedcf

Roll recipe dependencies (trivial). · 5c34046d

recipe-roller authored Jan 25, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/401a93b1055698158b3fb50a98aebb51e830ac44 [expect_tests] Add show_missing flag to coverage.report. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2655953002

5c34046d

Python style fixes + unused imports removal in git cl and friends. · 18975328

Andrii Shyshkalov authored Jan 25, 2017

R=sergiyb@chromium.org
BUG=

Change-Id: I9b886100557bf6efa9be07d40175f7bb919f5294
Reviewed-on: https://chromium-review.googlesource.com/432456Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

18975328

Improve debuggability of git cl tests. · 18df0cdf

Andrii Shyshkalov authored Jan 25, 2017

Change-Id: If14776d86a687a6edf5917f2a63ff984b812ecb8
Reviewed-on: https://chromium-review.googlesource.com/432376Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

18df0cdf

git cl: _RietveldChangelistImpl should always have non-None auth_config. · 98cef570

Andrii Shyshkalov authored Jan 25, 2017

TBR=phajdan.jr@chromium.org,sdefresne@chromium.org

Change-Id: I95cc6e61d044fd983c613fa7eeb21c8b77d7cee0
Reviewed-on: https://chromium-review.googlesource.com/432356Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

98cef570

git cl: remove code related to pending refs and gnumbd. · f3a20aed

Andrii Shyshkalov authored Jan 24, 2017

Refactor _GitNumbererState to two functions and remove no longer
useful tests.

BUG=644915
R=agable@chromium.org

Change-Id: If5e3e3b141aee192211f6af130b01f20f9afdbfe
Reviewed-on: https://chromium-review.googlesource.com/431976Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

f3a20aed

For Gerrit: use CURRENT_COMMIT option to get description, not gitiles. · 9c3a464b

Andrii Shyshkalov authored Jan 24, 2017

R=sergiyb@chromium.org
BUG=681704

Change-Id: I48804955d8e5e579eae6e60fccac304aaaa9230e
Reviewed-on: https://chromium-review.googlesource.com/430625Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

9c3a464b

Add cl description backup to gerrit upload. · f732cd5c

Christopher Lam authored Jan 24, 2017

BUG=684261

Change-Id: I2716864526fcedf44e561be8512843e12810e3a9
Reviewed-on: https://chromium-review.googlesource.com/431459Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

f732cd5c

Roll recipe dependencies (trivial). · cd091367

recipe-roller authored Jan 25, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/aae62c656032cf63284aecac5e974676064d8896 path module: fix tmp / cache dir creation (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2656753002

cd091367

24 Jan, 2017 4 commits

Put git cl format JS formatting behind a flag. · c5ba692d

Christopher Lam authored Jan 24, 2017

This CL moves JS formatting behind the --js flag for git cl format
due to issue with LayoutTests. It also adds an option to check
javascript for the presubmit canned formatting check.

BUG=567770

Change-Id: I9c080b1136f6ffef9fb1b08d3bfc97ce5b3185dc
Reviewed-on: https://chromium-review.googlesource.com/430526Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Christopher Lam <calamity@chromium.org>

c5ba692d

[git rebase-update] Handle error when chdir'ing to original workdir. · c87e36aa

Robert Iannucci authored Jan 24, 2017

BUG=

Change-Id: I1dc7f20eea3f4b1be9179aa6d77bdee08ab8a04f
Reviewed-on: https://chromium-review.googlesource.com/431576Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

c87e36aa

git cl status: re-use existing ChangeList object. · d0e1d9d9

Andrii Shyshkalov authored Jan 24, 2017

This way we avoid extra RPC to codereview site.

R=sergiyb@chromium.org
BUG=681704

Change-Id: I81f9ac1b8fe4cfaa95458a5669735168185c47e5
Reviewed-on: https://chromium-review.googlesource.com/430639
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

d0e1d9d9

Gerrit git cl: cache change detail to save on RPC calls. · 258e0a65

Andrii Shyshkalov authored Jan 24, 2017

R=sergiyb@chromium.org
BUG=681704

Change-Id: I5c320f7e6442a92ae0574e2ca6481a082e82568a
Reviewed-on: https://chromium-review.googlesource.com/430795
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

258e0a65