R=brucedawson@chromium.org

Review URL: https://codereview.chromium.org/1636833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298394 0039d316-1c4b-4281-b951-d872f2087c98

Without this, we'd cause unnecessary toolchain redownloads if vctip.exe
crashed.

R=brucedawson@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1639623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298393 0039d316-1c4b-4281-b951-d872f2087c98

This allows Pylint to analyze code that relies on C extensions (like numpy).
https://bitbucket.org/logilab/pylint/issues/58#comment-14920640


BUG=

Review URL: https://codereview.chromium.org/1639493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298392 0039d316-1c4b-4281-b951-d872f2087c98

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1617163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298381 0039d316-1c4b-4281-b951-d872f2087c98

Currently apply_issue fail if the content of a newly added file is
missing (because of the 900ko threshold in upload.py). But this doesn't
apply to the large file that get modified (instead of being added). This
is wrong because apply_issue will indicates a success without really
applying the patch.

It looks like the patch content is set to "None" in this cases (the string
value, not the empty value None).

Review URL: https://codereview.chromium.org/1612323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1614663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=580556

Review URL: https://codereview.chromium.org/1619383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298359 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1616423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298357 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1615073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298343 0039d316-1c4b-4281-b951-d872f2087c98

In change crrev.com/1504983002 the include\ucrt path from
the Windows 10 SDK was added to the include search path,
but this is not a legal thing to do on VS 2013. This change
makes the ucrt path VS 2015 specific.

Testing shows that this makes no difference to the VS 2015
package.

BUG=440500

Review URL: https://codereview.chromium.org/1609933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298330 0039d316-1c4b-4281-b951-d872f2087c98

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385

Review URL: https://codereview.chromium.org/1604423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298326 0039d316-1c4b-4281-b951-d872f2087c98

'git cl format' became very slow (7
seconds) after the Blink merge. 'git cl upload' is also slow when
the presubmit requires formatting checks.

This CL speeds up 'git cl format' by reducing the number of calls to
'git diff' and by removing the glob parameter. The glob
parameter adds a couple of seconds as it scans the entire
repository.

Before: 'git cl format' takes 7 seconds
After: 'git cl format' takes 1.25 seconds

BUG=577647

Review URL: https://codereview.chromium.org/1585923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298323 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1611603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298321 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1599463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298287 0039d316-1c4b-4281-b951-d872f2087c98

The VS 2015 tools require the Windows 10 Universal C Runtime, either
installed in C:\Windows or in every directory containing tools, or
dynamically linked executables created with VS 2015. Installing to
C:\Windows seems less error prone.

This is only applicable for Google developers and build machines that
don't have VS 2015 installed.

This updates the packaging script so that it packages the three
installers, and no longer packages the installed files (which vary
between operating systems anyway).

The installer is updated to check for the existence of one of the
Universal C Runtime files. If it isn't found then it detects the
version of Windows in order to select and run the correct installer.

I manually confirmed that, for instance, the installers for Windows 7
and Windows 2008 R2, were identical despite coming from different
download URLs.

If the installation fails because gclient runhooks is run non-elevated
then the developer will have to do a one-time manual install of the
update. A message will be printed indicating this.

BUG=440500

Review URL: https://codereview.chromium.org/1588673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298286 0039d316-1c4b-4281-b951-d872f2087c98

R=bauerb@chromium.org,andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1590473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=522909,565952

Review URL: https://codereview.chromium.org/1587893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298261 0039d316-1c4b-4281-b951-d872f2087c98

Add a setting to squash Gerrit uploads by default, and a --no-squash command line option to override it.

BUG=nope

Review URL: https://codereview.chromium.org/1584703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298260 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1583933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298257 0039d316-1c4b-4281-b951-d872f2087c98

This allows "git cl try" to just work for projects without any PRESUBMIT
but with cq.cfg in default location (infra/config/cq.cfg). This also
ships all presubmit bots, since these usually fail LGTM checks anyway.

BUG=522909

Review URL: https://codereview.chromium.org/1579423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298251 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1578953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298205 0039d316-1c4b-4281-b951-d872f2087c98

The checks are not reliable for Rvalue references, and only are
allowing default/deleted constructors. They are based on the google3
internal rules which do not exactly match our own c++11 rules, and
may diverge more over time.

Email thread that led to this change here: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/9TZvt8vyeEM

R=agable@chromium.org

Review URL: https://codereview.chromium.org/1573663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298202 0039d316-1c4b-4281-b951-d872f2087c98

Now that we're using real override/final and not also using
virtual on the same methods, this transitional blacklist
can go away.

R=agable, dcheng

Review URL: https://codereview.chromium.org/1564403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298201 0039d316-1c4b-4281-b951-d872f2087c98

Through a comedy of wrapper scripts, the ^ is being swallowed, which
causes the `git config` invocation to match all lines which HAVE
"remote" in them, instead of matching lines which BEGIN with remote.

R=maruel@chromium.org, pkasting@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1566343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298185 0039d316-1c4b-4281-b951-d872f2087c98

I coded these incorrectly in a previous change and hit them when
building a VS package.

Review URL: https://codereview.chromium.org/1567863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298156 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1565973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298147 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1567563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298136 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1553303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298120 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1554093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298116 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1555973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298113 0039d316-1c4b-4281-b951-d872f2087c98

R=dpranke@chromium.org,tandrii@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1545913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298097 0039d316-1c4b-4281-b951-d872f2087c98

If the stderr buffer used in git diff became full
before stdout was completely consumed, git cl upload
would deadlock.

This also sets GIT_PAGER to be perfectly sure no pager
is triggered by the git commands run. I haven't
seen that as a problem but it's a reasonable (and
common) precaution.

BUG=558726

Review URL: https://codereview.chromium.org/1544813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298090 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1544623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298088 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1533133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298077 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1534353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298073 0039d316-1c4b-4281-b951-d872f2087c98

R=tandrii@chromium.org
BUG=564557

Review URL: https://codereview.chromium.org/1534813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/1533853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298052 0039d316-1c4b-4281-b951-d872f2087c98

R=tandrii@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1532563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298047 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1532513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298037 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=luqui@chromium.org

Review URL: https://codereview.chromium.org/1529023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298031 0039d316-1c4b-4281-b951-d872f2087c98