- 17 Aug, 2018 1 commit
-
-
John Budorick authored
Bug: 865882 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Change-Id: I4a04c4c28c7dc63ad282f54604c300bbfe654f11 Reviewed-on: https://chromium-review.googlesource.com/1157687 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 27 Jul, 2018 1 commit
-
-
John Budorick authored
This doesn't expose --patch_ref in the bot_update recipe_module yet, though. Bug: 865882 Change-Id: I26abe59d2f6a8a3dd3945cce0bf13b238a7fffd3 Reviewed-on: https://chromium-review.googlesource.com/1151105 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 25 Jun, 2018 1 commit
-
-
Andrii Shyshkalov authored
Originally-Reviewed-on: https://chromium-review.googlesource.com/1111107 Led-test: https://ci.chromium.org/swarming/task/3e51ed0e31211710?server=chromium-swarm.appspot.com TBR=hinoka, iannucci Bug: 855137 Change-Id: I157ef6b9ee2a7ce45e4a474853ae769a82cc4c99 Reviewed-on: https://chromium-review.googlesource.com/1114234 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 22 Jun, 2018 4 commits
-
-
Andrii Shyshkalov authored
This reverts commit c48318a3. Reason for revert: likely broke ChromeOS Original change's description: > bot_update: Don't force solutions to be unmanaged. > > gclient should be the one syncing the solutions to the appropriate > revisions. > > Bug: 850812, 853032 > Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29 > Reviewed-on: https://chromium-review.googlesource.com/1102833 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=hinoka@chromium.org,agable@chromium.org,ehmaldonado@chromium.org Change-Id: I7e110108a9687d703ea8be39cc83e0888f7813c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850812, 853032, 855700 Reviewed-on: https://chromium-review.googlesource.com/1111925Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 568b7a89. Reason for revert: temporary revert to revert previous CL. Original change's description: > Wipe out shallow checkout support from bot_update. > > Bug: 855137 > Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c > Reviewed-on: https://chromium-review.googlesource.com/1111107 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,tandrii@chromium.org Change-Id: Iede67717be448be9bdd7c5dd4895fbab9fd65c66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855137, 855700 Reviewed-on: https://chromium-review.googlesource.com/1111924Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Bug: 855137 Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c Reviewed-on: https://chromium-review.googlesource.com/1111107 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
Edward Lemur authored
gclient should be the one syncing the solutions to the appropriate revisions. Bug: 850812, 853032 Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29 Reviewed-on: https://chromium-review.googlesource.com/1102833Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 10 May, 2018 1 commit
-
-
Edward Lemur authored
It fails when both the revision and the url are None. Bug: 841936 Change-Id: Idef45a015624a92226d4ccd38ed5b978bf786993 Reviewed-on: https://chromium-review.googlesource.com/1053996 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
- 27 Mar, 2018 1 commit
-
-
Edward Lesmes authored
Is easier to configure experimental bots this way. Bug: 643346 Change-Id: Idb6d3a68b02949dce71dbcba38e8ef756c467830 Reviewed-on: https://chromium-review.googlesource.com/981515 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 26 Mar, 2018 1 commit
-
-
Edward Lesmes authored
This adds a --enable-gclient-experiment flags that tells bot_update.py to skip applying the patch, and instead forward the flags to gclient. Bug: 643346 Change-Id: Ia4275a126e6adba54dfcc894d224c50c166db90e Reviewed-on: https://chromium-review.googlesource.com/962938 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 14 Mar, 2018 1 commit
-
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Change-Id: I518335e7b8fdce316b5566caccd3c4c7c2ae741a Reviewed-on: https://chromium-review.googlesource.com/960161 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 12 Mar, 2018 2 commits
-
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Change-Id: Ic4c2dc7a50d389f18f3e0c1de332cb1a0ab376a9 Reviewed-on: https://chromium-review.googlesource.com/957834 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Robert Iannucci authored
This method hasn't been supported for a long time now (and besides, its only for Rietveld). R=agable@chromium.org, tandrii@chromium.org Recipe-Manual-Change: infra Change-Id: Ie6e63834dca67962db29f2cb407950ed85db55a7 Reviewed-on: https://chromium-review.googlesource.com/957832Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 08 Feb, 2018 1 commit
-
-
Tom Anderson authored
Also, some lines went over 80chars, so I ran 'yapf --style chromium' which formatted some unrelated things. BUG=905285 R=dpranke Change-Id: Iee5f46d88a6e9782612cc4f9e5a2cb72d62ab6af Reviewed-on: https://chromium-review.googlesource.com/907736 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 01 Nov, 2017 2 commits
-
-
Ryan Tseng authored
This relands commit 47b67c42. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
Ryan Tseng authored
This reverts commit 47b67c42. Reason for revert: Bug in bot_update.py resource, breaks recipe roller. Original change's description: > Reland "bot_update recipe: Upload source manifest" > > This reverts commit c3d1208d. > > Also: > * Instead of replacing "manifest", just add a new "source_manifest" > to the output JSON. This allow transition without breakage. > * Change the test api so test for recipe output changes. > > The plan is to land this first, switch all downstream to "source_manifest", > and then remove the original "manifest" key. > > Bug: 772529,776299 > Change-Id: Iffb75f18046f8e4c058afe077872d4257b9dd754 > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: release_scripts > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: skiabuildbot > Recipe-Nontrivial-Roll: build > Reviewed-on: https://chromium-review.googlesource.com/731378 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org Change-Id: I7a4ee904075e8b75b8a47f9ef0cd8a633af85a9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772529, 776299 Reviewed-on: https://chromium-review.googlesource.com/748312Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
- 31 Oct, 2017 1 commit
-
-
Ryan Tseng authored
This reverts commit c3d1208d. Also: * Instead of replacing "manifest", just add a new "source_manifest" to the output JSON. This allow transition without breakage. * Change the test api so test for recipe output changes. The plan is to land this first, switch all downstream to "source_manifest", and then remove the original "manifest" key. Bug: 772529,776299 Change-Id: Iffb75f18046f8e4c058afe077872d4257b9dd754 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/731378Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
- 19 Oct, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit 037f9b80. Reason for revert: The structural change to manifest breaks the recipe tester: https://cs.chromium.org/chromium/infra/recipes/recipes/recipe_roll_tryjob.py?q=recipe_roll_tryjob.py&sq=package:chromium&dr&l=149 https://crbug.com/776299 Original change's description: > bot_update recipe: Upload source manifest > > Bug: 772529 > Change-Id: I3f833740ddfbc71be42b140c99dcd4bbfeed54fe > Reviewed-on: https://chromium-review.googlesource.com/706071 > Commit-Queue: Ryan Tseng <hinoka@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org Change-Id: Iba9653d73b7f117ca2f94619ae5da900cd0c8c98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772529,776299 Reviewed-on: https://chromium-review.googlesource.com/728059Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
Ryan Tseng authored
Bug: 772529 Change-Id: I3f833740ddfbc71be42b140c99dcd4bbfeed54fe Reviewed-on: https://chromium-review.googlesource.com/706071 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 11 Oct, 2017 1 commit
-
-
Vadim Shtayura authored
This reverts commit c3eb3fa3. Reason for revert: lots of "runhooks" failure everywhere Example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/92720 Original change's description: > git_cache: Remove locks > > These aren't in use, and the original problem they were > meant to solve has been solved at the gclient.py layer > using resource locking: > https://codereview.chromium.org/2049583003 > > Bug: 773008 > Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a > Reviewed-on: https://chromium-review.googlesource.com/707728 > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org,phajdan.jr@chromium.org Change-Id: I31d5fef94f39f3a9f97b9e59121073b1f433d11e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773008 Reviewed-on: https://chromium-review.googlesource.com/711054Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 10 Oct, 2017 1 commit
-
-
Ryan Tseng authored
These aren't in use, and the original problem they were meant to solve has been solved at the gclient.py layer using resource locking: https://codereview.chromium.org/2049583003 Bug: 773008 Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a Reviewed-on: https://chromium-review.googlesource.com/707728Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
- 08 Jun, 2017 1 commit
-
-
Dan Jacques authored
Currently, "bot_update" relies on a BuildBot cleanup mechanism and, to a lesser extent, the standard BuildBot directory layout. Both of these are problematic when projecting it into other circumstances, notably "remote_run" and LUCI. Have "bot_update" handle its own cleanup. It will now choose a cleanup directory within the hierarchy of its checkout, and explicitly purge it prior to execution if it exists. This enforces its expected behavior in all circumstances and removes its expectations of the greater checkout layout. Export "cleanup_dir" via "infra_paths" to point to "build.dead" when running on BuildBot builds. Otherwise, it is a default directory which, on Kitchen, is ephemeral by design. BUG=chromium:725631 TEST=expectations Change-Id: I664434c542a25aaa7ff3eac216208a2425730fde Reviewed-on: https://chromium-review.googlesource.com/528057 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 31 May, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Some recipes interacting with older revisions (e.g. bisect) will need this. Bug: 570091 Change-Id: I38e5ffa2db1a9bfae3667f015f00977c32ebe51e Reviewed-on: https://chromium-review.googlesource.com/519407 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 24 Mar, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
This will help remove confusion when depot_tools' recipes.py ends up in PATH. BUG=699120 Change-Id: Id4c21b0cc6bb022ea2c21145abe76bebb0a8d9c1 Reviewed-on: https://chromium-review.googlesource.com/458430 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
- 17 Feb, 2017 1 commit
-
-
Ryan Tseng authored
Gclient sometimes ignores "unmanaged": "False" in the gclient solution if --revision <anything> is passed. This forces gclient to always treat solutions deps as unmanaged. BUG=693296 Change-Id: I91d5f4c9377fab0fde23cf15d1475779978820fa Reviewed-on: https://chromium-review.googlesource.com/444098 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 14 Feb, 2017 1 commit
-
-
Ryan Tseng authored
BUG=692140,664880 Change-Id: I3ddd899f1841930e601a906d658c5c78e2d76673 Reviewed-on: https://chromium-review.googlesource.com/442707Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
- 13 Feb, 2017 1 commit
-
-
Ryan Tseng authored
BUG=664880 Change-Id: Ic3d4da4595acb509c9dae682dbd696900f435436 Reviewed-on: https://chromium-review.googlesource.com/442025Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 10 Nov, 2016 1 commit
-
-
dnj authored
Currently, 'bot_update' uses the 'gclient' that is on the system path. Now, it will use the 'gclient.py' that is in the same 'depot_tools' checkout as the 'bot_update' recipe module. Also don't ignore "git_cache" move errors. BUG=664254,663990,663440 TEST=None Review-Url: https://codereview.chromium.org/2492963002
-
- 31 Oct, 2016 1 commit
-
-
katthomas authored
Sometimes Windows has trouble deleting files. This can cause problems when lockfiles are left in .git directories. R=agable@google.com BUG=659178 Review-Url: https://codereview.chromium.org/2454463002
-
- 11 Oct, 2016 1 commit
-
-
katthomas authored
Hypothesis: Sometimes bot update fails because windows fails to delete a lockfile associated with a git process. Test: If this happens, let's delete that lockfile and try again. BUG=651602 Review-Url: https://codereview.chromium.org/2382653005
-
- 21 Sep, 2016 1 commit
-
-
hinoka authored
Reland of https://codereview.chromium.org/2294413002/ after a rebase fix. BUG=642150 Review-Url: https://codereview.chromium.org/2353833002
-
- 20 Sep, 2016 1 commit
-
-
hinoka authored
Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (patchset #7 id:120001 of https://codereview.chromium.org/2294413002/ ) Reason for revert: Pointing to the wrong file :( Original issue's description: > bot_update: add --auth-refresh-token-json passthrough for apply_issue > > BUG=642150 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f898f25b64a3ec4f5c003f7554e7 TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642150 Review-Url: https://codereview.chromium.org/2350363003
-
- 19 Sep, 2016 1 commit
-
-
hinoka authored
BUG=642150 Review-Url: https://codereview.chromium.org/2294413002
-
- 09 Sep, 2016 2 commits
-
-
iannucci authored
R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org BUG=643885 Review-Url: https://codereview.chromium.org/2328883002
-
agable authored
This is a reland of 082267a6 which was reverted in 4dcad385 BUG=472386 Review-Url: https://codereview.chromium.org/2325513002
-
- 08 Sep, 2016 1 commit
-
-
hinoka authored
BUG= Review-Url: https://codereview.chromium.org/2316393002
-
- 17 Feb, 2016 1 commit
-
-
https://codereview.chromium.org/1686273002/hinoka@google.com authored
Reason for revert: Separating change into smaller changes. Original issue's description: > Bot update cleanup > > * Remove activation check > * Remove messages > * Remove deps2git > * Remove build_internal pointer by: > ** Moving chrome svn url into bot_update.py (This isn't secret anyways.) > ** Move patch.exe into depot_tools (No reason this should've been internal...) > ** Default everything to active, so no need for checks anyways. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298809 TBR=martiniss@chromium.org,eseidel@chromium.org,estaab@chromium.org,iannucci@chromium.org,hinoka@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review URL: https://codereview.chromium.org/1706893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298826 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Feb, 2016 1 commit
-
-
hinoka@chromium.org authored
* Remove activation check * Remove messages * Remove deps2git * Remove build_internal pointer by: ** Moving chrome svn url into bot_update.py (This isn't secret anyways.) ** Move patch.exe into depot_tools (No reason this should've been internal...) ** Default everything to active, so no need for checks anyways. BUG= Review URL: https://codereview.chromium.org/1686273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298809 0039d316-1c4b-4281-b951-d872f2087c98
-