Commits · 0bcd1d343059104a979ceb68abe139cd48bc7a06 · Linshizhi / Chromium_Depot_tools

26 Apr, 2011 2 commits

Make subprocess2.check_call() compliant with subprocess.check_call(). · 0bcd1d34

maruel@chromium.org authored Apr 26, 2011

Rename check_call to check_call_out. It's a quite specific need when stderr is
needed or when the user doesn't want the default arguments of check_output.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6882127

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83023 0039d316-1c4b-4281-b951-d872f2087c98

0bcd1d34

Fix when entry is None. · 6f323bba

maruel@chromium.org authored Apr 26, 2011

When the tree is not versionned, svn can return <info></info>.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6899052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83020 0039d316-1c4b-4281-b951-d872f2087c98

6f323bba

23 Apr, 2011 2 commits

Fix constructor arguments to OSError. · ff3e4a87

maruel@chromium.org authored Apr 23, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6897034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82763 0039d316-1c4b-4281-b951-d872f2087c98

ff3e4a87

Optimize presubmit checks for win32 where determining the diff · e06cb4e5

nick@chromium.org authored Apr 23, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82607
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82653
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82762 0039d316-1c4b-4281-b951-d872f2087c98

e06cb4e5

22 Apr, 2011 3 commits

:Revert r82607 (reportedly takes forever on long changes) · 7b45069a
nick@chromium.org authored Apr 22, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82653 0039d316-1c4b-4281-b951-d872f2087c98
```
7b45069a

Optimize presubmit checks for win32 where determining the diff · 9c765d7a

nick@chromium.org authored Apr 22, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82607 0039d316-1c4b-4281-b951-d872f2087c98

9c765d7a

Add post_process argument to Checkout.apply_patch(). · 8a1396cd

maruel@chromium.org authored Apr 22, 2011

This enables doing late modifications like updating the copyright notice or fixing line endings.

Also silence the checkout operations a bit more when VOID=subprocess2.VOID.

Add corresponding unit tests.

Review URL: http://codereview.chromium.org/6891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82587 0039d316-1c4b-4281-b951-d872f2087c98

8a1396cd

21 Apr, 2011 5 commits

Revert 82559. · cfbdd987

nick@chromium.org authored Apr 21, 2011

Review URL: http://codereview.chromium.org/6896004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82568 0039d316-1c4b-4281-b951-d872f2087c98

cfbdd987

Optimize presubmit checks for win32 where determining the diff · baa40e63

nick@chromium.org authored Apr 21, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82559 0039d316-1c4b-4281-b951-d872f2087c98

baa40e63

Update upload.py to r705. · 1c5518ea

maruel@chromium.org authored Apr 21, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6889002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82495 0039d316-1c4b-4281-b951-d872f2087c98

1c5518ea

Move commit-queue/checkout into depot_tools so it can be reused by the try server. · dfaecd2b

maruel@chromium.org authored Apr 21, 2011

BUG=
TEST=

Review URL: http://codereview.chromium.org/6877055

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82414 0039d316-1c4b-4281-b951-d872f2087c98

dfaecd2b

Unicode input is also accepted for stdin. · 39f645ff

maruel@chromium.org authored Apr 21, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6878069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82410 0039d316-1c4b-4281-b951-d872f2087c98

39f645ff

20 Apr, 2011 2 commits

Improve patch handling and tests. · c4b5e76d

maruel@chromium.org authored Apr 20, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6877038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82406 0039d316-1c4b-4281-b951-d872f2087c98

c4b5e76d

Pass relative paths to GIT.CaptureStatus · 512f1ef7

bauerb@chromium.org authored Apr 20, 2011

BUG=79953
TEST=see bug

Review URL: http://codereview.chromium.org/6883085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82290 0039d316-1c4b-4281-b951-d872f2087c98

512f1ef7

19 Apr, 2011 1 commit

Only show "Depot Tools has been updated" messages when the tools are actually · 736aefea

mark@chromium.org authored Apr 19, 2011

updated; show the real last-change revision and not the current HEAD revision.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6881049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82124 0039d316-1c4b-4281-b951-d872f2087c98

736aefea

18 Apr, 2011 5 commits

Make subprocess2.call() returned values to be the same as subprocess.call(). · 1f063db1

maruel@chromium.org authored Apr 18, 2011

Renamed the previous subprocess2.call() to subprocess2.communicate().

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6877005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81976 0039d316-1c4b-4281-b951-d872f2087c98

1f063db1

Fix drover regression introduced in r80453. · e3db8556

maruel@chromium.org authored Apr 18, 2011

getSVNInfo() is expected to fail in some use case. Make this behavior explicit.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6881008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81970 0039d316-1c4b-4281-b951-d872f2087c98

e3db8556

Make RunHooks a method on ChangeList. · 6fb99c6f

bauerb@chromium.org authored Apr 18, 2011

BUG=none
TEST=watchlists work again.

Review URL: http://codereview.chromium.org/6871015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81950 0039d316-1c4b-4281-b951-d872f2087c98

6fb99c6f

Inhibit python subprocess from generating .pyc files anymore. · ea7c855b

maruel@chromium.org authored Apr 18, 2011

This would case a failure when:
- a .py file is moved
- *.pyc is in svn:ignore, causing the .pyc to not be deleted.
- the new .py modifies its API.
- another .py imports the old .py and uses the new API.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6854022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81942 0039d316-1c4b-4281-b951-d872f2087c98

ea7c855b

Use a marker instead of a string so it can be distingished when used as stdin. · 0d5ef24c

maruel@chromium.org authored Apr 18, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6840053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81941 0039d316-1c4b-4281-b951-d872f2087c98

0d5ef24c

14 Apr, 2011 2 commits

Remove remaining cygwin check in wrapper scripts. · 3bc36d13

maruel@chromium.org authored Apr 14, 2011

Looks like we had forgot gcl.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6838028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81654 0039d316-1c4b-4281-b951-d872f2087c98

3bc36d13

Fix rietveld_url parameter, remove default argument and realign code. · 6493ed19

maruel@chromium.org authored Apr 14, 2011

TBR=dpranke@chromium.org
BUG=
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81579 0039d316-1c4b-4281-b951-d872f2087c98

6493ed19

12 Apr, 2011 6 commits

Add author to Change object. Don't set it yet. · 58407af8

maruel@chromium.org authored Apr 12, 2011

It's mostly to be used with the commit queue.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6820076

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81326 0039d316-1c4b-4281-b951-d872f2087c98

58407af8

update_depot_tools: Workaound svn symlink issue. · 6fe66e19

scottbyer@chromium.org authored Apr 12, 2011

svn info doesn't like it when handed a symlink - you get an 'is not a working copy' error message. Unfortunately, the Mac uses BSD readlink, and doesn't have -f, so the subshell CD/PWD idiom must be used.

BUG=none
TEST=Create a symlink to depot_tools, put it early in your path, and do update_depot_tools. You should not get any 'not a working copy' error messages.
Review URL: http://codereview.chromium.org/6838001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81323 0039d316-1c4b-4281-b951-d872f2087c98

6fe66e19

Use class-level variable instead of instance members for Change object. · c193875b

maruel@chromium.org authored Apr 12, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6821083

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81322 0039d316-1c4b-4281-b951-d872f2087c98

c193875b

Add script to apply a patch from rietveld. · 61e0b691

maruel@chromium.org authored Apr 12, 2011

At the moment it just fetches the patch. It's still useful to debug rietveld
issues.

Improve resiliency to invalid patches.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6825085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81305 0039d316-1c4b-4281-b951-d872f2087c98

61e0b691

Defaults stdin to VOID for capture and check_output() · 4a982271

maruel@chromium.org authored Apr 12, 2011

Since no output is user visible anyway, causing a hang with no clue about what
to type in.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6823091

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81302 0039d316-1c4b-4281-b951-d872f2087c98

4a982271

Add --verbose flag when input_api.verbose is set. · 6c7723e7

maruel@chromium.org authored Apr 12, 2011

It could result in failed tests so I'll revert if it ever becomes problematic.
It ran fine with my limited testing.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6813114

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81279 0039d316-1c4b-4281-b951-d872f2087c98

6c7723e7

09 Apr, 2011 2 commits

First stab at using Rietveld wrapper object in both gcl.py and git-cl. · cab38e99

maruel@chromium.org authored Apr 09, 2011

Exposes InputApi.rietveld and deprecate host_url.

This is useful since it places authentication at a single place.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6825008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98

cab38e99

Add support to put a patchset into a subdirectory. · cd619402

maruel@chromium.org authored Apr 09, 2011

Add better code to handle diff header, especially add more patch verification
code.

Add a lot of tests.

Add mangling of \ to /.

R=dpranke@chromium.org
BUG=78561
TEST=

Review URL: http://codereview.chromium.org/6802021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81017 0039d316-1c4b-4281-b951-d872f2087c98

cd619402

07 Apr, 2011 5 commits

Add verbose support throught presubmit checks · 899e1c1a

maruel@chromium.org authored Apr 07, 2011

Add propagation of verbose flag from git cl to presubmit_support

Rename NotImplementedException to standard NotImplementError.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6810012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80798 0039d316-1c4b-4281-b951-d872f2087c98

899e1c1a

Fix case where wc_info is not present. · ade9c595

maruel@chromium.org authored Apr 07, 2011

Reapply r80770 "Switch from xml.dom.minidom to xml.etree".

TBR=dpranke@chromium.org
BUG=
TEST=

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98

ade9c595

Set returncode to subprocess2.TIMED_OUT instead of -9 when a process times out. · 1d9f6294

maruel@chromium.org authored Apr 07, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6806009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80775 0039d316-1c4b-4281-b951-d872f2087c98

1d9f6294

Revert r80770 "Switch from xml.dom.minidom to xml.etree" · d25fb8f6

maruel@chromium.org authored Apr 07, 2011

Throws exceptions on mac.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6811020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98

d25fb8f6

Switch from xml.dom.minidom to xml.etree · 949d1a6a

maruel@chromium.org authored Apr 07, 2011

The reason of this change (beside deleting 30 lines) is to fix pylint on Mac.
For an unknown reason, it was dying here trying to process the minidom import.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6799021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98

949d1a6a

06 Apr, 2011 5 commits

Don't store rietveld.extracc in git config. · ae6df358

bauerb@chromium.org authored Apr 06, 2011

BUG=none
TEST=no more git config spam!

Review URL: http://codereview.chromium.org/6805007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80646 0039d316-1c4b-4281-b951-d872f2087c98

ae6df358

Make more tests pass on Windows. · c98c0c52

maruel@chromium.org authored Apr 06, 2011

Also fix a few issues found along the way.

Tests had regressed a lot. Add a lot of tweaks to make most test pass.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80618 0039d316-1c4b-4281-b951-d872f2087c98

c98c0c52

Convert PRESUBMIT.py to use check_output() instead of Popen(). · ccbb781a

maruel@chromium.org authored Apr 06, 2011

Fix execution on windows.

Remove more code.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6792054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80617 0039d316-1c4b-4281-b951-d872f2087c98

ccbb781a

Use check_call() instead of Popen() for canned checks. · 0e766050

maruel@chromium.org authored Apr 06, 2011

This removes a significant amount of code.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6693100

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80616 0039d316-1c4b-4281-b951-d872f2087c98

0e766050

Use subprocess2 so check_call() can be use consistently in presubmit checks. · 84f4fe37

maruel@chromium.org authored Apr 06, 2011

Do s/Popen+communicate/check_call/ replacement in a later change in case it
breaks something.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6794057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80615 0039d316-1c4b-4281-b951-d872f2087c98

84f4fe37