- 03 Dec, 2018 1 commit
-
-
Takuto Ikuta authored
This is windows version of https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1345255 Changed to use call to invoke python because python is bat file. Bug: 900161 Change-Id: I0332306387614153be7ae6dbde05fb2bc93559b1 Reviewed-on: https://chromium-review.googlesource.com/c/1355641 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org>
-
- 01 Dec, 2018 1 commit
-
-
Edward Lemur authored
Bug: 770408 Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273 Reviewed-on: https://chromium-review.googlesource.com/c/1354384 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 30 Nov, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99 Use reason instead of reason_message. (jchinlee@chromium.org) R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3321c89b8fd9ace846de08149990cda5084ee78b Reviewed-on: https://chromium-review.googlesource.com/c/1357323 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org>
-
Edward Lemur authored
Bug: 845642 Change-Id: I552b2da4abbac7ca7f6f3961d2b1c5002fb26f47 Reviewed-on: https://chromium-review.googlesource.com/c/1351509Reviewed-by:
Andy Perelson <ajp@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2caa3255a823c92842e4725693d35d13783fb81e python: add infra_failing_step utility method. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If77b80bfe76a2b5c77a3ab10501412adac6e586b Reviewed-on: https://chromium-review.googlesource.com/c/1357259 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
erikchen authored
The function can be called by chromium_test to set a property 'do_not_retry' which will be propagated into buildbucket output. Change-Id: I32d8ea925b7cb98d9b25d24226686e116c17801c Bug: 910193 Reviewed-on: https://chromium-review.googlesource.com/c/1351542 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/793d8faa696f62fa2c774b8c854bbf4d64dff24e Separate InfraFailure behavior from StepFailure behavior. (jchinlee@chromium.org) R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I396fcab3dbfcbf365d32483cf08f510805da303c Reviewed-on: https://chromium-review.googlesource.com/c/1355801Reviewed-by:
-
- 29 Nov, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab [Testing] Add comprehensive UI test recipe. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib52d510e2a48c86f6220781178e34c8bcb52c2bd Reviewed-on: https://chromium-review.googlesource.com/c/1355779 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This CL introduces ninjalog_uploader to autoninja for posix environment. This is to collect build statistics from googler to find user side build performance bottleneck. ninjalog_uploader_wrapper is used to notify user and manage small config of upload script. Bug: 900161 Change-Id: I48ac8cd1d52f64e8fdafaec43636d2d79ef9040d Reviewed-on: https://chromium-review.googlesource.com/c/1345255Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
- 26 Nov, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/690ad21d32ae0a94512bc9ac4a6b8fcca96d67f8 Update my legal name (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2e6c43f4586b9b899e929147f5ddf4972c99c9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1351513Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/caf2224c87491b931d6c4441b2119e0287a99347 [isolated] Expose an isolated server getter (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic43cd809209944dc9cea23d87c4cbfdc7006d30e Reviewed-on: https://chromium-review.googlesource.com/c/1351510Reviewed-by:
-
Edward Lemur authored
Use gclient setdep/getdep instead of evaluating the contents of the DEPS file, so we don't have to deal with builtin_variables. Bug: 906114 Change-Id: I2082d4a3feb84d15c251b7d99056fd4c6f925453 Reviewed-on: https://chromium-review.googlesource.com/c/1347450Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 23 Nov, 2018 1 commit
-
-
Aiden Benner authored
Adding the diff.noprefix flag to .gitconfig broke python formatting because git diffs were being parsed with regex that relied on the default git diff prefixs. This CL fix's this issue by always specifying prefix flags for git diffs when formatting python. Bug:846432 Change-Id: Ifde305da9574e6b46455a0237703b7364fac77e4 Reviewed-on: https://chromium-review.googlesource.com/c/1349809Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
-
- 22 Nov, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/20068b80c82fb44c9e871f18ee82e1c032c000af [recipe_modules/archive] Update archive to zip entire root by default. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I64c75b109a0b890efdb32db54b398e1688ad6067 Reviewed-on: https://chromium-review.googlesource.com/c/1347451 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
- 21 Nov, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4118c738aa691c9c2b69f8b69359a9ba4fece9d7 [buildbucket] Document gitiles_commit (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3f01fc3963baa3041328c3aa400dee3e6938f111 Reviewed-on: https://chromium-review.googlesource.com/c/1347449Reviewed-by:
-
Robert Iannucci authored
Now with correct error handling. R=nodir@chromium.org, vadimsh@chromium.org Bug: 869227 Change-Id: I961fd80209c9d9988e9d03016b7c0bd253c6cdfb Reviewed-on: https://chromium-review.googlesource.com/c/1347249 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I949cefd102ecc80b161d082ec40b7e059f596781 Reviewed-on: https://chromium-review.googlesource.com/c/1345050Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c Reviewed-on: https://chromium-review.googlesource.com/c/1344642 Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
On my machine, saves 0.16s of time while loading git cl: from 0.32s to 0.16s. R=ajp, ehmaldonado Change-Id: I0febca43f11514da3e3f7be7e2c0184fb9e17409 Reviewed-on: https://chromium-review.googlesource.com/c/1344641Reviewed-by:
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09 Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by:
-
- 20 Nov, 2018 6 commits
-
-
Vadim Shtayura authored
This reverts commit f4913068. Reason for revert: panics, see b/119830955 Original change's description: > [vpython] Roll to pick up user differentiation of cached envs. > > R=vadimsh@chromium.org > > Bug: 869227 > Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f > Reviewed-on: https://chromium-review.googlesource.com/c/1344638 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Auto-Submit: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org Change-Id: Ie77d559dc1787ec1b8a19076238b7018d39dd0b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869227 Reviewed-on: https://chromium-review.googlesource.com/c/1344639Reviewed-by:
-
Robert Iannucci authored
R=vadimsh@chromium.org Bug: 869227 Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f Reviewed-on: https://chromium-review.googlesource.com/c/1344638 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
John Budorick authored
This reverts commit 3f40c42b. Reason for revert: ast.literal_eval(False) doesn't work? Original change's description: > Don't fetch flash when fetching android_internal. > > Bug: 856278 > Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/1342730 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> TBR=ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Iffb655701830984e47a2b8e7629f0ed87886a401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856278 Reviewed-on: https://chromium-review.googlesource.com/c/1344637Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Aiden Benner authored
Enables python formatting in git cl format by default for all files that have a .style.yapf file in a parent directory up to the repository root. If no .style.yapf file is found the --python flag still needs to be set explicitly for python formatting to be enabled. Also adds a --no-python to explicitly disable python formatting on any file even if a .style.yapf file is found. This allows default formatting to be enabled on a per project/directory basis by adding a .style.yapf file. Bug:846432 Change-Id: I40d899ec1a3e0dfca445e04b91befab113416175 Reviewed-on: https://chromium-review.googlesource.com/c/1316415 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1342730Reviewed-by:
-
Aiden Benner authored
git cl format --python currently breaks on windows because FindExecutable('yapf') returns .../depot_tools/yapf (a py file) instead of .../depot_tools/yapf.bat. Also yapf.bat tries to run the yapf py file without vpython which breaks the yapf dependency. This CL fixes these two issues. Bug:846432 Change-Id: I551a4c1e6367074fa76767851bd34feb2dcfb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/1341236Reviewed-by:Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com>
-
- 19 Nov, 2018 3 commits
-
-
Eric Foo authored
Bug:868202 Change-Id: Ic480356aa4b385e97eb3e47a6f1a439aeb82720a Reviewed-on: https://chromium-review.googlesource.com/c/1341227 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org>
-
Edward Lesmes authored
Bug: 906114 Change-Id: Ib8614086f7c456c04d27f33c73809671ed073bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1341862Reviewed-by:
Eric Boren <borenet@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
This is a reland of 5705acab If a gclient config is not found, then built-in variables wont be supported. Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> Bug: 906114 Change-Id: I72f30d10b5f0180fd5c616a42393f5b12055ce8e Reviewed-on: https://chromium-review.googlesource.com/c/1341039Reviewed-by:
-
- 16 Nov, 2018 5 commits
-
-
Bruce Dawson authored
These changes ensure that the packaged Windows SDK bits support targeting ARM64 Windows. This change must not land until crrev.com/c/1339101 lands, since it is needed to the varying number of vs_runtime_dll_dirs. Bug: 893460 Change-Id: Ie32563067c6fb6078acfaccd6d3d572d1dd44888 Reviewed-on: https://chromium-review.googlesource.com/c/1330185 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This reverts commit 5705acab. Reason for revert: breaks internal bots, e.g. see http://shortn/_KDb4blyDVz Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=borenet@chromium.org,ehmaldonado@chromium.org Change-Id: I233ae7feae296fb4cd04b9b36d7f53d1114df5ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906114 Reviewed-on: https://chromium-review.googlesource.com/c/1340506Reviewed-by:
-
Johannes Henkel authored
This will facilitate a more standalone development process. We don't have a DEPS file there yet, but I'm planning to add a simple one, which for starters will have gunit. I'll model this mostly after breakpad. I've tested this fetch config and it appears to work great: $ mkdir testfetch $ cd testfetch $ fetch inspector_protocol After this there's an src directory in testfetch which has our sources. Change-Id: I482d65b3d8e50e9e5a98c4affc7b487a5bd6df53 Reviewed-on: https://chromium-review.googlesource.com/c/1340502 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Robert Iannucci authored
Fixes issue with bogus secret bytes being included when running `led get-build`. The server would return "<REDACTED>".encode("base64"), and led would pass this along to the task, which would fail to decode it as a proto. R=nodir@chromium.org, vadimsh@chromium.org Change-Id: Ie8b33a2dc1f05ddb163465d72ea461f9e6833363 Reviewed-on: https://chromium-review.googlesource.com/c/1340504 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: -
Eric Boren authored
Bug: 906114 Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f Reviewed-on: https://chromium-review.googlesource.com/c/1340461Reviewed-by:
-
- 15 Nov, 2018 5 commits
-
-
Robert Iannucci authored
R=vadimsh@chromium.org Change-Id: Ibd55035fe62ae710cdce448ec489bf7af06925fd Reviewed-on: https://chromium-review.googlesource.com/c/1337522 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Edward Lemur authored
Use "personally identifiable information" instead of "PII" on metrics.README.md. Tbr: tandrii@chromium.org Bug: None Change-Id: I5294ab3ddfbc9e6705085a68751a477073cea052 Reviewed-on: https://chromium-review.googlesource.com/c/1337515Reviewed-by:
Alan Bram <flyboy@chromium.org> Reviewed-by:
-
Yoshisato Yanagisawa authored
Change-Id: Ic7ca117435de34400fdd117741d0b321339f8cfd Reviewed-on: https://chromium-review.googlesource.com/c/1325250 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
Yoshisato Yanagisawa authored
On Windows, without quote, whole return value would be treated as a command, and the execution would fail. On Linux and Mac, without quote, if depot_tools is settled under directories with ' ', command execution would fail because paths are separated in a wrong way. To make such a return value work on Linux and Mac, the shell script started to use eval. Bug: 902930 Change-Id: I9bb74585294af565988c0b844b6b113a5c685530 Reviewed-on: https://chromium-review.googlesource.com/c/1325249Reviewed-by:
-
Yoshisato Yanagisawa authored
Since ninja uses getopt_long to parse the argument, we need to suppose -j100 and -tclean. Please see ReadFlags function in: https://github.com/ninja-build/ninja/blob/master/src/ninja.cc Change-Id: If61f05e66be546a591549f6f153cce994c972309 Reviewed-on: https://chromium-review.googlesource.com/c/1335428Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 12 Nov, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3ec591502d7760fb3d2d64b63d51e6993b5beca6 [doc/user_guide] Add a bit more about recipes.py (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibf90ca4157cbe0eee09bdc54eef09855b05b2557 Reviewed-on: https://chromium-review.googlesource.com/c/1332567Reviewed-by:
-
