- 14 Mar, 2014 2 commits
-
-
rvargas@chromium.org authored
2006-2009/10 was a valid copyright date format before 2011 (when we decided to use only one year, not a range). The current directive with copyright is in fact to not change old copyright dates, so there is no plan to go back and "fix" old files. As such, the presubmit checks should not be complaining about old files. BUG=none Review URL: https://codereview.chromium.org/200643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257181 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=352029 Review URL: https://codereview.chromium.org/199723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256972 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2014 6 commits
-
-
phajdan.jr@chromium.org authored
Note that other waterfalls are not guaranteed to support triggering via HTTP or SVN. That's why this hardcodes tryserver.chromium. BUG=334892 Review URL: https://codereview.chromium.org/197553009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256947 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/199553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256925 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/181043018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256778 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
Also fix missing copyright notices. R=agable@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/196433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256777 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
Review URL: https://codereview.chromium.org/196943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256776 0039d316-1c4b-4281-b951-d872f2087c98
-
stip@chromium.org authored
depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo. If broken dev_appserver.py instances are left around, they will conflict with master ports. BUG=351926 Review URL: https://codereview.chromium.org/197073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256721 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Mar, 2014 4 commits
-
-
agable@chromium.org authored
The commit queue uses checkout.GitCheckout to manage the local git repository. It resets it to a clean state, commits patches locally, and pushes those changes to the golden-source-of-truth repo. This CL fixes the prepare() method to use the new git-cache tool, and in the process makes it more consistent, more readable, and more correct. It also makes minor changes to other methods to bring them in line with the git-cache approach. R=iannucci@chromium.org, rmistry@chromium.org BUG=261619 Review URL: https://codereview.chromium.org/175873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256681 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
git_cache rewrites all urls to https://netloc/path when setting them as remote urls. This doesn't work when the remote is actually local on disk, and the "url" is a /path/to/repo. This seems like an unlikely case, but it is leveraged by testing, and it doesn't hurt to support it, so now we do. R=iannucci@chromium.org BUG=261619 Review URL: https://codereview.chromium.org/196493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256386 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
git-map: Show your local repo's history in a pseudo-graphical format from the command line. git-map-branches: Show the topology of all of your branches, and their upstream relationships. git-nav-upstream: Navigate (checkout) to the upstream branch of the current branch. git-nav-downstream: Navigate (checkout) to a downstream branch of the current branch. If there's more than one downstream branch, then present a menu to select which one you want. R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org BUG= Review URL: https://codereview.chromium.org/184113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256384 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
This is an emergency patch to avoid picking up the upcoming 2.9-rc0 version of gerrit, which requires java 7 and will break the chromeos bots. BUG=346369 R=davidjames@chromium.org Review URL: https://codereview.chromium.org/196063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256378 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Mar, 2014 3 commits
-
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/194753007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256292 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/134223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256289 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
This introduces python_git_runner.sh, and makes git-cl, git-cache, git-number, and git-try use it. R=agable@chromium.org, szager@chromium.org BUG=261738 Review URL: https://codereview.chromium.org/188383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256131 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Mar, 2014 4 commits
-
-
scottmg@chromium.org authored
- Don't try to wrap download_from_google_storage --config, instead just request that the user runs it manually. (This is annoying either way but making it magically run makes it less clear what's going on, and so harder to debug when something goes wrong, per linked bug). - Check that SHA1s are passed as expected on the command line in case the script is run directly, rather than from gyp_chromium. R=scherkus@chromium.org BUG=349596 Review URL: https://codereview.chromium.org/189093017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256049 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Revert of Another attempt: gclient: delete mismatching checkouts (https://codereview.chromium.org/183283003/) Reason for revert: Broke `gclient sync` for me, failing with: Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again. For someone else, it broke it with: % gclient sync ________ unmanaged solution; skipping src Error: Command svn info --xml returned non-zero exit status 1 in /Users/pawliger/chromium/src/. <?xml version="1.0" encoding="UTF-8"?> <info> svn: E155007: '/Users/pawliger/chromium/src' is not a working copy Original issue's description: > Another attempt: gclient: delete mismatching checkouts > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255930 TBR=iannucci@chromium.org,szager@chromium.org,maruel@chromium.org,mmoss@chromium.org,borenet@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/192323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256005 0039d316-1c4b-4281-b951-d872f2087c98
-
plundblad@chromium.org authored
R=maruel@chromium.org BUG=none Review URL: https://codereview.chromium.org/192293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255960 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/183283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255930 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Mar, 2014 3 commits
-
-
scottmg@chromium.org authored
The gs:// download path is much faster. Move anyone who could have access to gs://chrome-wintoolchain/ over to that for less pain. The downside is that we have to prompt them to run download_from_google_storage --config which people are going to complain about, but I think this is a better experience overall. R=iannucci@chromium.org,hinoka@chromium.org BUG=349964 Review URL: https://codereview.chromium.org/191373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255696 0039d316-1c4b-4281-b951-d872f2087c98
-
wittman@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/180533012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255667 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
To allow toolchain script to run successfully on x86 hosts. R=phajdan.jr@chromium.org TBR=iannucci@chromium.org BUG=349824 Review URL: https://codereview.chromium.org/189563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255641 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Mar, 2014 1 commit
-
-
scottmg@chromium.org authored
Follow up to https://codereview.chromium.org/185423004/ The unzip is always Pro, and without setting this the data.json will be getting the Express settings and so gyp will generate the wrong project. TBR=iannucci@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/188673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255378 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Mar, 2014 3 commits
-
-
hinoka@google.com authored
There is an issue where: 1. Lock for asdf.git acquires, which creates asdf.lock 2. asdf.git is cloned into tmp_asdf.git 3. Buildbot crashes, because timeouts 4. neither asdf.lock or tmp_asdf.git/config.lock gets cleaned out on the next unlock. This aims to fix this issue by aggressively unlocking everything it can find that vaguely resembles a lock. BUG=339171 Review URL: https://codereview.chromium.org/187283005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255138 0039d316-1c4b-4281-b951-d872f2087c98
-
mdempsky@chromium.org authored
Review URL: https://codereview.chromium.org/188013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255125 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
TBR=maruel@chromium.org R=scottmg@chromium.org Review URL: https://codereview.chromium.org/184103027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254932 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Mar, 2014 1 commit
-
-
alokp@chromium.org authored
Must change current working directory to the presubmit file's directory to follow the contract of the presubmit scripts. BUG=348691 Review URL: https://codereview.chromium.org/181063021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254618 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Mar, 2014 1 commit
-
-
primiano@chromium.org authored
The depot_tools and nacl recipes aren't setting up git-svn properly. There is no git-svn branch in the git mirror for depot-tools and nacl, just master. As a consequence "fetch depot-tools" ends up recreating all the objects from svn taking much more time than it should. BUG= Review URL: https://codereview.chromium.org/183743010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254506 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Mar, 2014 1 commit
-
-
scottmg@chromium.org authored
I tried a git-ish tree/blob model, but way too slow for a ton of files. This maps easily on to the current way the tree is mapped, saves temp space on bots (because the full isos aren't downloaded), and is a lot faster too. It means we can pull old revisions too now. TBR=iannucci@chromium.org BUG=348350 Review URL: https://codereview.chromium.org/185423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254421 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Mar, 2014 1 commit
-
-
machenbach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/178223016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254321 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Feb, 2014 4 commits
-
-
hinoka@google.com authored
We don't want to run it in the DEPS directory, which is apperently what the default behavior is. BUG=339171 Review URL: https://codereview.chromium.org/184793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254266 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
Instead of having custom logic for dealing with cache directories, use git_cache.py to populate caches. Also fixes a bug in git_cache.py where it was looking for lockfiles in cwd rather than the cache dir. Other changes: * _Run now returns output. * Always print to stdout in CheckCallAndFilterOutput, even if it gets a carriage return. This is done because git progress report are carriage returns and not newlines and we don't want everything on the same line and not strip out the CRs. * Removed members changed tests, its not very useful to know a new import is added. BUG=339171 Review URL: https://codereview.chromium.org/180243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254248 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
It's not true (anymore?) that the number of SCM jobs for gclient sync equals the number of cores, thus the new text is less specific. BUG=none Review URL: https://codereview.chromium.org/184733007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254242 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
TBR=pkasting@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/178193008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254042 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Feb, 2014 3 commits
-
-
hinoka@chromium.org authored
For some reason "--tags" wasn't working on some versions of git (pre-1.9) BUG=339171 Review URL: https://codereview.chromium.org/183813004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253929 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
R=hinoka@chromium.org BUG=339171 Review URL: https://codereview.chromium.org/183643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253887 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
git sometimes blocks asking for a password. On a random machine that didn't know anything about google/chromium, it failed immediately with "fatal: could not read Username for 'https://chrome-internal.googlesource.com': No such file or directory" but on my real machine w/o _netrc it blocks and wants this: Username for 'https://chrome-internal.googlesource.com': Password for 'https://chrome-internal.googlesource.com': There's no --non-interactive unfortunately, it's supposed to magically decide if it's connected to a tty and behave appropriately. It does not, perhaps because of being wrapped in depot_tools .bat files, perhaps an msysgit-port bug, perhaps being called from python. Anyway https://github.com/bower/bower/issues/1009 had a magic incantation that works for this case: 'true' is available in the msys distribution. R=iannucci@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/182553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253844 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2014 3 commits
-
-
szager@chromium.org authored
This reverts commit 6ff54485. 'fetch --nohooks chromium' is broken with this change. BUG= Review URL: https://codereview.chromium.org/177003023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253640 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/164053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253616 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Shell PATH was growing quite long in some cases. R=gab@chromium.org, iannucci@chromium.org, johnw@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/180303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253347 0039d316-1c4b-4281-b951-d872f2087c98
-