Move Googlers to gs:// based toolchain pull

The gs:// download path is much faster. Move anyone who could have
access to gs://chrome-wintoolchain/ over to that for less pain.

The downside is that we have to prompt them to run
download_from_google_storage --config which people are going to
complain about, but I think this is a better experience overall.

R=iannucci@chromium.org,hinoka@chromium.org
BUG=349964

Review URL: https://codereview.chromium.org/191373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255696 0039d316-1c4b-4281-b951-d872f2087c98

win_toolchain/get_toolchain_if_necessary.py

@@ -38,6 +38,8 @@ import time
 
 
 BASEDIR = os.path.dirname(os.path.abspath(__file__))
+sys.path.append(os.path.join(BASEDIR, '..'))
+import download_from_google_storage
 
 
 GetFileAttributes = ctypes.windll.kernel32.GetFileAttributesW
@@ -131,6 +133,47 @@ def HaveSrcInternalAccess():
         shell=True, stdin=nul, stdout=nul, stderr=nul) == 0
 
 
+def LooksLikeGoogler():
+  """Checks for a USERDOMAIN environment variable of 'GOOGLE', which
+  probably implies the current user is a Googler."""
+  return os.environ.get('USERDOMAIN').upper() == 'GOOGLE'
+
+
+def CanAccessToolchainBucket():
+  """Checks whether the user has access to gs://chrome-wintoolchain/."""
+  gsutil = download_from_google_storage.Gsutil(
+      download_from_google_storage.GSUTIL_DEFAULT_PATH, boto_path=None)
+  code, _, _ = gsutil.check_call('ls', 'gs://chrome-wintoolchain/')
+  return code == 0
+
+
+def ConfigureGsAccess():
+  """Starts the authentication flow for gs://, and confirms that it's
+  accessible after completion, or retries indefinitely.
+  """
+  while not CanAccessToolchainBucket():
+    print 'Access to gs://chrome-wintoolchain/ not configured.'
+    print '-----------------------------------------------------------------'
+    print
+    print 'You appear to be a Googler.'
+    print
+    print 'I\'m sorry for the hassle, but you need to do a one-time manual'
+    print 'authentication. Instructions will open in a new window. This is'
+    print 'a run of "gsutil config".'
+    print
+    print 'NOTE: Just press Enter when asked for a "project-id".'
+    print
+    print '-----------------------------------------------------------------'
+    print
+    sys.stdout.flush()
+    # gclient's buffering makes this hang if we're run from inside gclient
+    # as is typical. So, spawn a new window for the config prompt. :(
+    subprocess.check_call(
+        ['start', '/wait', 'cmd', '/c',
+         'download_from_google_storage', '--config'],
+        shell=True)
+
+
 def DelayBeforeRemoving(target_dir):
   """A grace period before deleting the out of date toolchain directory."""
   if (os.path.isdir(target_dir) and
@@ -167,12 +210,17 @@ def main():
   # based on timestamps to make that case fast.
   current_hash = CalculateHash(target_dir)
   if current_hash not in desired_hashes:
-    should_get_pro = (os.path.isfile(os.path.join(BASEDIR, '.vspro')) or
-                      HaveSrcInternalAccess())
+    should_use_gs = False
+    if (CanAccessToolchainBucket() or
+        HaveSrcInternalAccess() or
+        LooksLikeGoogler()):
+      should_use_gs = True
+      ConfigureGsAccess()
     print('Windows toolchain out of date or doesn\'t exist, updating (%s)...' %
-          ('Pro' if should_get_pro else 'Express'))
+          ('Pro' if should_use_gs else 'Express'))
     print('  current_hash: %s' % current_hash)
     print('  desired_hashes: %s' % ', '.join(desired_hashes))
+    sys.stdout.flush()
     DelayBeforeRemoving(target_dir)
     # This stays resident and will make the rmdir below fail.
     with open(os.devnull, 'wb') as nul:
@@ -184,7 +232,9 @@ def main():
             'toolchain2013.py',
             '--targetdir', target_dir,
             '--sha1', desired_hashes[0]]
-    if not should_get_pro:
+    if should_use_gs:
+      args.append('--use-gs')
+    else:
       args.append('--express')
     subprocess.check_call(args)
     current_hash = CalculateHash(target_dir)

win_toolchain/toolchain2013.py

@@ -106,9 +106,7 @@ def DeleteAllTempDirs():
 def GetMainIsoUrl(pro):
   """Gets the main .iso URL.
 
-  If |pro| is False, downloads the Express edition. If |CHROME_HEADLESS| is
-  set in the environment, then we assume we're on an internal bot, and download
-  from internal google storage instead.
+  If |pro| is False, downloads the Express edition.
   """
   prefix = 'http://download.microsoft.com/download/'
   if pro:
@@ -256,6 +254,8 @@ def GetSourceImages(local_dir, pro):
   of the 7.1 WDK which is the latest publically accessible source for ATL. When
   |pro| this is not necessary (and CHROME_HEADLESS always implies Pro).
   """
+  if pro and not local_dir:
+    sys.exit('Non-Express must be used with --local')
   url = GetMainIsoUrl(pro)
   if local_dir:
     wdk_path = (os.path.join(local_dir, os.path.basename(WDK_ISO_URL))
@@ -448,8 +448,8 @@ def main():
                     help='use VS Express instead of Pro', action='store_true')
   parser.add_option('--sha1',
                     help='tree sha1 that can be used to mirror an internal '
-                         'copy (used if --bot-mode)')
-  parser.add_option('--bot-mode',
+                         'copy (used if --use-gs)')
+  parser.add_option('--use-gs',
                     help='Use internal servers to pull isos',
                     default=bool(int(os.environ.get('CHROME_HEADLESS', 0))),
                     action='store_true')
@@ -464,7 +464,7 @@ def main():
     # codec dll very well, so this is the simplest way to make sure it runs
     # correctly, as we don't otherwise care about working directory.
     os.chdir(os.path.join(BASEDIR, '7z'))
-    if options.bot_mode and options.sha1:
+    if options.use_gs and options.sha1:
       options.express = False
       DoTreeMirror(target_dir, options.sha1)
     else: