• Edward Lesmes's avatar
    Revert "gclient: Add commands to edit dependencies and variables in DEPS" · 0b89935a
    Edward Lesmes authored
    This reverts commit 7f4c905f.
    
    Reason for revert:
    When running "gclient sync" on a V8 checkout, it says:
    
      File "/work/chrome/depot_tools/gclient.py", line 995, in run
       self.ParseDepsFile()
     File "/work/chrome/depot_tools/gclient.py", line 874, in ParseDepsFile
       self._postprocess_deps(deps, rel_prefix), use_relative_paths)
     File "/work/chrome/depot_tools/gclient.py", line 660, in _postprocess_deps
       dval['condition'], self.condition)
    TypeError: '_NodeDict' object does not support item assignment
    
    on the recursive descent into third_party/android_tools/DEPS. Any chance that's related to https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/950405 ?
    
    Original change's description:
    > gclient: Add commands to edit dependencies and variables in DEPS
    > 
    > Adds 'gclient setvar' and 'gclient setdep' commands to edit variables
    > and dependencies in a DEPS file.
    > 
    > Bug: 760633
    > Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b
    > Reviewed-on: https://chromium-review.googlesource.com/950405
    > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    > Reviewed-by: Aaron Gable <agable@chromium.org>
    
    TBR=agable@chromium.org,ehmaldonado@chromium.org
    
    Change-Id: If58f6b15d31b19fc53294f1e41d26b4e684a2cf9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 760633
    Reviewed-on: https://chromium-review.googlesource.com/969165Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
    Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    0b89935a
gclient_eval.py 12.4 KB