- 20 Mar, 2018 2 commits
-
-
Lei Zhang authored
To help figure out why it decided to do so. BUG=823586 Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6 Reviewed-on: https://chromium-review.googlesource.com/970082 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Lei Zhang authored
This helps make it slightly easier to understand. Change-Id: Iaf68409374be67e03d5708b409c1ad9229c68b1d Reviewed-on: https://chromium-review.googlesource.com/970161Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
-
- 19 Mar, 2018 2 commits
-
-
Edward Lesmes authored
This reverts commit 7f4c905f. Reason for revert: When running "gclient sync" on a V8 checkout, it says: File "/work/chrome/depot_tools/gclient.py", line 995, in run self.ParseDepsFile() File "/work/chrome/depot_tools/gclient.py", line 874, in ParseDepsFile self._postprocess_deps(deps, rel_prefix), use_relative_paths) File "/work/chrome/depot_tools/gclient.py", line 660, in _postprocess_deps dval['condition'], self.condition) TypeError: '_NodeDict' object does not support item assignment on the recursive descent into third_party/android_tools/DEPS. Any chance that's related to https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/950405 ? Original change's description: > gclient: Add commands to edit dependencies and variables in DEPS > > Adds 'gclient setvar' and 'gclient setdep' commands to edit variables > and dependencies in a DEPS file. > > Bug: 760633 > Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b > Reviewed-on: https://chromium-review.googlesource.com/950405 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> TBR=agable@chromium.org,ehmaldonado@chromium.org Change-Id: If58f6b15d31b19fc53294f1e41d26b4e684a2cf9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760633 Reviewed-on: https://chromium-review.googlesource.com/969165Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Adds 'gclient setvar' and 'gclient setdep' commands to edit variables and dependencies in a DEPS file. Bug: 760633 Change-Id: I6c0712cc079dbbbaee6541b7eda71f4b4813b77b Reviewed-on: https://chromium-review.googlesource.com/950405 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 16 Mar, 2018 1 commit
-
-
Sergiy Byelozyorov authored
This also adds support for V8 project on issue tracker. R=tandrii@chromium.org Change-Id: Ie90ae664573d36030267b639e8a55bc349cad872 Reviewed-on: https://chromium-review.googlesource.com/966623 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 14 Mar, 2018 4 commits
-
-
Corentin Wallez authored
TBR=maruel@chromium.org BUG=chromium:815092 Change-Id: I2d9e63000cbe48fea636a3d0f6fd69f040495697 Reviewed-on: https://chromium-review.googlesource.com/962994Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
Robert Iannucci authored
TBR=tandrii@chromium.org Bug: 811974 Change-Id: I1ace75471dfbe2798c7c848f76d6607b34ff1033 Reviewed-on: https://chromium-review.googlesource.com/962082 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Change-Id: I2bfed54a9a1bde3335340e5949eac313c3fdda32 Reviewed-on: https://chromium-review.googlesource.com/961970 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Change-Id: I518335e7b8fdce316b5566caccd3c4c7c2ae741a Reviewed-on: https://chromium-review.googlesource.com/960161 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 13 Mar, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d17fa9994d031c525a5a732218667d41b827c8ec Use more common term in recipe-api docu (machenbach@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idef0e59985a9500e49b5a313be021f1bb88a1be4 Reviewed-on: https://chromium-review.googlesource.com/961082 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5c6e39ec6dee4d110839f61767a361979ae13dda [bundle] Copy file data instead of symlinks. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I92193f0989929c7d75c4bbb09c2ed1706d008a46 Reviewed-on: https://chromium-review.googlesource.com/959695 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 12 Mar, 2018 2 commits
-
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Change-Id: Ic4c2dc7a50d389f18f3e0c1de332cb1a0ab376a9 Reviewed-on: https://chromium-review.googlesource.com/957834 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Robert Iannucci authored
This method hasn't been supported for a long time now (and besides, its only for Rietveld). R=agable@chromium.org, tandrii@chromium.org Recipe-Manual-Change: infra Change-Id: Ie6e63834dca67962db29f2cb407950ed85db55a7 Reviewed-on: https://chromium-review.googlesource.com/957832Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 08 Mar, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ee2763eca5218a9257efb06bef385622f0fc8561 Add builder_id property to BuildBucketApi (kjharland@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I969a55f5f633d343690ea4255af82ce77df76f73 Reviewed-on: https://chromium-review.googlesource.com/956423 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 07 Mar, 2018 2 commits
-
-
Edward Lesmes authored
e.g. when specifying both '--revision src@<something>' and '--revision <src_gerrit_repo>@<some_gerrit_ref>', gclient will sync to '<some_gerrit_ref>' instead of '<something>'. This is useful when specifying which gerrit change to patch, which should take priority over other revision specifications. Bug: chromium:643346 Change-Id: Ibc21ede355b56e4da966f38f144ce6f6f1743403 Reviewed-on: https://chromium-review.googlesource.com/949981 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
Edward Lesmes authored
Add a --output-json flag to gclient revinfo so is easier for other programs to process its output. Bug: None Change-Id: Ic120e7a279f3ed537ead624ab9bfd1f141485487 Reviewed-on: https://chromium-review.googlesource.com/952206 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 06 Mar, 2018 4 commits
-
-
Aaron Gable authored
This allows people to configure their gitcookies file to be whereever they want. As long as it actually exists and has credentials in it, we'll accept it, just like git itself. Change-Id: I4aa4806ddca0e61b28b003b0d3bc486407c13ab4 Reviewed-on: https://chromium-review.googlesource.com/951917Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
Change-Id: I9e45c55d1a57a7c275d0524af60c8f644717eb25 Reviewed-on: https://chromium-review.googlesource.com/952076 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5906d3e7a321c743d49f29a995040c41cc08ec24 [recipe_modules][time] Add ms_since_epoch method (kjharland@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifabc93da366e23f18f8ab1d12ff0bbfcecb2bbbb Reviewed-on: https://chromium-review.googlesource.com/952302Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Edward Lesmes authored
Add --path and --url options to show only the dependencies that match one of the given paths or URLs. Bug: None Change-Id: I12c205545b7ce54b56abcd62f9bf1db229b4fd77 Reviewed-on: https://chromium-review.googlesource.com/951963Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 03 Mar, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b10224f3b916ec7aac1e6edbfc0fefa9635d15df Reserve pipe in step names. (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7f12d43fa7660186e78eb2cd1c9c9d3b05438171 Reviewed-on: https://chromium-review.googlesource.com/947622Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 28 Feb, 2018 1 commit
-
-
Robert Iannucci authored
This allows the cipd client to process refs with slashes in them. Also it is compiled with cgo on OSX, which should help with DNS resolution errors that happen on some machines. R=vadimsh@chromium.org Bug: 811974, 803673 Change-Id: If298db5cfe0e10e3734deb4215bf82b95ff5e09e Reviewed-on: https://chromium-review.googlesource.com/940521 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
- 27 Feb, 2018 3 commits
-
-
Jao-ke Chin-Lee authored
Bug: 811681 Change-Id: I2ef7238baececcf87643cba78d72622922ad881c Reviewed-on: https://chromium-review.googlesource.com/939991Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
-
Aaron Gable authored
Bug: 811681 Change-Id: Id7b276274ba6e2e52fba9a19e6c15d5fd972c178 Reviewed-on: https://chromium-review.googlesource.com/919530 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Michael Achenbach authored
Bug: v8:7419 Change-Id: I49ad9358b9487b76503c3c1f4d6838aa0dd42736 Reviewed-on: https://chromium-review.googlesource.com/938969Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
- 26 Feb, 2018 1 commit
-
-
Shenghua Zhang authored
When hooks multiple cipd packages under same directory, gclient would pop up error that same directory name appears multiple times in deps section. This CL overrides verify_validity for CipdDependency to support multiple packages hooked in same directory. Bug:812386 Change-Id: Ia4f1fe0e3c8481c9b06c1d22b6e98d98e1e4c309 Reviewed-on: https://chromium-review.googlesource.com/920686 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
- 23 Feb, 2018 1 commit
-
-
Shenghua Zhang authored
For now 'version' of packages only support string like 'version:27.0.5'. It is helpful to support version to match vars value, e.g. Var('tool_version'), especially useful when version numbers could be modified via api. This change won't affect versions with string format. Change-Id: I40b389b528f04712798b08f1455869cab2ec54c9 Reviewed-on: https://chromium-review.googlesource.com/935666Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
-
- 22 Feb, 2018 3 commits
-
-
Andrii Shyshkalov authored
Over last two weeks of running tryjobs on CLs of others, I found this very useful. This CL also simplifies code. R=agable@chromium.org Change-Id: I5c7ce0d311b1ca024b92227dbec54e5197205c62 Reviewed-on: https://chromium-review.googlesource.com/930742Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Daniel Bratell authored
Change-Id: I04261053a37db078e2aff579ab4521056cce673c Reviewed-on: https://chromium-review.googlesource.com/931555Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c12134ce50260d37d0b39aee92d1fc53c6565a0c Print Windows crash codes in hex (brucedawson@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I679f1740ee8a7bfb94bf5f5d752d52192bddc39c Reviewed-on: https://chromium-review.googlesource.com/930262 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 21 Feb, 2018 3 commits
-
-
Henrique Ferreiro authored
Bug: 721585 Change-Id: Ic6d47201e93cd89a1b58871ef0e3a1b5b708eb47 Reviewed-on: https://chromium-review.googlesource.com/924151Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Robert Iannucci authored
This will allow users on unsupported platforms to successfully bypass vpython via the recognized environment variable. R=tandrii@chromium.org, vadimsh@chromium.org Change-Id: Id63019443321d9f63550fc11e7a4ae3f684b17e7 Reviewed-on: https://chromium-review.googlesource.com/927695 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Nodir Turakulov authored
Remove code path. Update new code path to expect one bucket, instead of a list. Related: https://chromium-review.googlesource.com/c/infra/infra/+/927792 TBR=tandrii@chromium.org Bug: 800355 Change-Id: I60fbcf92dc242fc9b448760aaa5399320e257323 Reviewed-on: https://chromium-review.googlesource.com/928053 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
- 20 Feb, 2018 2 commits
-
-
John Budorick authored
Bug: 813460 Change-Id: Ie52a20dcdf5cb60ab47b787dcfa05aa8a712a727 Reviewed-on: https://chromium-review.googlesource.com/926709Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4ddd3e9ccb10ff116af86a674570a9dce0e781b8 [recipe_api] Fix bug when debug_dir is present and non-null (dbort@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iad11b3f61710b30573cb9cf9b213954674d2a579 Reviewed-on: https://chromium-review.googlesource.com/926867 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
- 16 Feb, 2018 1 commit
-
-
Alexander Alekseev authored
Python multiprocessing is using sockets to communicate. UNIX socket names are bound by PATH_MAX which includes temporary directory name. gsutil uses multiprocessing, which creates file sockets in the tmpdir. On some testing configurations, the tmpdir is set to a very long path, which causes gsutil to fail with AF_UNIX path too long errors. To prevent multiprocess failures, this CL overrides temporary directory dictated by the environment to /tmp. Bug: 812581 Change-Id: Idcd99d13b2e20b3095111fa26ec4e242848c8848 Reviewed-on: https://chromium-review.googlesource.com/923170Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
-
- 13 Feb, 2018 3 commits
-
-
Bruce Dawson authored
A handy usage pattern for autoninja.bat that I was not aware of is to go autoninja -C out\Default chrome && chrome This will build chrome and then run it, but only run it if the build succeeds. The addition of post_build_ninja_summary.py broke this by losing the error code. This change fixes it by using black magic to set an error code in the failure case. Bug: chromium:787983 Change-Id: Ib87fd1799816e19d56de76e08e0f9688be903d80 Reviewed-on: https://chromium-review.googlesource.com/916705Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
post_build_ninja_summary.py gives a summary of a ninja build. It can be run standalone or it can be run automatically by autoninja. This CL updates the Python script and the autoninja bash script to make this work on Linux. This includes removing a zero-value assert, and ensuring that .so files get categorized as such. Change-Id: I2d59ab129f5ce70117beeb119719f8432bfbab7c Reviewed-on: https://chromium-review.googlesource.com/915053Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Aaron Gable authored
When someone runs "gclient diff", they expect to be diffing their local state against the state of a clean gclient checkout. Up until now, "gclient diff" has been doing... not that. It's been assuming that the sha1 in DEPS is approximately the head of the remote's master branch, finding the merge-base between the local content and that remote master, and diffing against that merge-base. This makes basically no sense in the context of gclient. With gclient, we already know exactly what should be checked out: it's whatever is in DEPS. This CL updates the behavior of "gclient diff" to do the right thing. Bug: 731701 Change-Id: I23a43cbc0d6bc7772495097ff615d4d070f5ad19 Reviewed-on: https://chromium-review.googlesource.com/914717Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 12 Feb, 2018 1 commit
-
-
Matt Giuca authored
Previously, it counted the number of UTF-8 bytes when spacing out the table, not the number of code points. Bug: 808905 Change-Id: Ice5504089e0f7097e108c6dfbbb810620b9dfc94 Reviewed-on: https://chromium-review.googlesource.com/901142 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-