• Camillo Bruni's avatar
    [counters] Fix reentrant timers for V8.Execute · fffcbaea
    Camillo Bruni authored
    This CL fixes a long standing issue where reentering TimedHistograms
    scopes would cause spurious measurements. Only the non-nested scopes
    yielded correct results.
    
    Due to the changed numbers, the V8.Execute histogram is renamed to
    V8.ExecuteMicroSeconds. Note that this histogram is also guarded
    behind the --slow-histograms flag due to the additional overhead.
    
    Unlike before, it does no longer include time for external callbacks
    and only measures self time. The following example illustrates the
    new behaviour:
    
    1. Enter V8:           |--+.......+--| self-time: 4 units (reported)
    2. Exit V8 (callback):    |-+...+-|    self-time: 2 units (ignored)
    3. Re-enter V8:             |---|      self-time: 3 units (reported)
    
    This would result in 2 histogram entries with 4 time units for the first
    V8 slice and 3 units for the nested part. Note that the callback time
    itself is ignored.
    
    This CL attempts to clean up how TimedHistograms work:
    - Histogram: the base class
    - TimedHistograms: used for time-related histograms that are not nested
    - NestedTimeHistograms: Extends TimedHistograms and is used for nested
      histograms
    
    This CL changes Histograms to not measure time themselves. Measurements
    happen in the *HistogramScopes:
    - BaseTimedHistogramScope: Base functionality
    - TimedHistogramScope: For non-nested measurements
    - NestedTimedHistogramScope: For nested measurements
    - PauseNestedTimedHistogramScope: Ignore time during a given scope.
      This is used to pause timers during callbacks.
    
    Additional changes:
    - ExternalCallbackScope now contains a PauseNestedTimedHistogramScope
      and always sets VMState<EXTERNAL>
    
    Bug: v8:11946
    Change-Id: I45e4b7ff77b5948b605dd50539044cb26222fa21
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001345Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76111}
    fffcbaea
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
shared-mutex-guard-if-off-thread.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...