• Frank Tang's avatar
    [Temporal] Fix ZDT hoursInDay for non-integer hours · fe1245ed
    Frank Tang authored
    The hoursInDay could be fractional number on the date of changng
    daylight saving time for time zone in half hours or some historical time
    zone.
    Ex: Australia/Lord_Howe on Sunday, April 3, 2022, 2:00:00 am clocks were
    turned backward 0:30 hours to Sunday, April 3, 2022, 1:30:00 am local
    standard time instead. so that day will have 24.5 hours.
    On Sunday, October 2, 2022, 2:00:00 am clocks are turned forward 0:30
    hours to Sunday, October 2, 2022, 2:30:00 am local daylight time
    instead. So the hoursInDay for that day is only 23.5 hours.
    
    Historically, Singapore from 1933 to 1941 moved clocks forward 20 minutes for daylight savings, resulting the day in 24.33333 and
    23.66667 hours.
    
    Test covered in https://github.com/tc39/test262/blob/main/test/staging/Temporal/ZonedDateTime/old/dst-properties.js
    
    Change the return type from MaybeHandle<Smi> to MaybeHandle<Object> so
    we can return non integer value. Also change the method of division by
    first convert the value to second in BigInt, then divid 3600 (number of
    seconds in a hour) in double.
    
    Bug: v8:11544
    Change-Id: Ia69d2606cd832e51f415a00440fb9cbc236883e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3901619Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83311}
    fe1245ed
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...