• Leszek Swirski's avatar
    Revert "[ic] Load name/context lazily in LdaNamedProperty" · 5377e72c
    Leszek Swirski authored
    This reverts commit 347092ac.
    
    Not a clean revert, since other changes got baked on top, but rather
    a manual removal of LoadLazyICParameters.
    
    Reason for revert: Seems to actually regress bindings perf tests (see
    bugs and https://chromeperf.appspot.com/group_report?rev=62539), doesn't
    seem to improve performance elsewhere, and increases complexity.
    
    Original change's description:
    > [ic] Load name/context lazily in LdaNamedProperty
    >
    > Introduces LazyLoadICParameters which allow a LazyNode for context and
    > name. These aren't used on the fast path, so we want to avoid reading
    > them for both performance and register pressure reasons.
    >
    > Change-Id: Ifb637cf4782ce984feee9af503998e7539beb823
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1686665
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62539}
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:981797
    Bug: chromium:982630
    Change-Id: I88af764d17afb76d6e64b95a3d1e4aaa1c6c8978
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934327
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65205}
    5377e72c
Name
Last commit
Last update
..
OWNERS Loading commit data...
accessor-assembler.cc Loading commit data...
accessor-assembler.h Loading commit data...
binary-op-assembler.cc Loading commit data...
binary-op-assembler.h Loading commit data...
call-optimization.cc Loading commit data...
call-optimization.h Loading commit data...
handler-configuration-inl.h Loading commit data...
handler-configuration.cc Loading commit data...
handler-configuration.h Loading commit data...
handler-configuration.tq Loading commit data...
ic-inl.h Loading commit data...
ic-stats.cc Loading commit data...
ic-stats.h Loading commit data...
ic.cc Loading commit data...
ic.h Loading commit data...
keyed-store-generic.cc Loading commit data...
keyed-store-generic.h Loading commit data...
stub-cache.cc Loading commit data...
stub-cache.h Loading commit data...