• Clemens Hammacher's avatar
    [wasm] Refactor and fix ErrorThrower · e3207836
    Clemens Hammacher authored
    The error thrower did allocate the exception at the moment the error was
    detected. For async compilation, this meant in another step than when
    it was actually thrown. Since the HandleScope of the exception already
    died at that point, this would have lead to memory errors.
    
    With this refactoring, we only store the information needed to generate
    the exception in the ErrorThrower, and only generate the exception
    object once it is actually needed.
    
    With regression test.
    
    R=ahaas@chromium.org, mtrofin@chromium.org
    Also-by: ahaas@chromium.org
    
    Change-Id: Iffcab1f8d1cf5925e3643fcf0729ba9a84c7d277
    Reviewed-on: https://chromium-review.googlesource.com/490085
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45000}
    e3207836
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...