• Clemens Backes's avatar
    Revert "[wasm] Pass the script ID to code logging" · 8d013ea1
    Clemens Backes authored
    This reverts commit ab4d9717.
    
    Reason for revert: UBSan issues: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/14184/overview
    
    Original change's description:
    > [wasm] Pass the script ID to code logging
    >
    > We didn't pass a script ID with the code creation events for profiling.
    > This made DevTools lose the connection to the wasm script, hence
    > jumping from the profiler entry to the source did not work.
    >
    > This CL changes the timing of code logging a bit such that the script is
    > always allocated before logging. In the queue of code to be logged we
    > then also store the script ID, and finally set it on the {CodeEntry}
    > object.
    >
    > R=​thibaudm@chromium.org
    >
    > Bug: chromium:1125986
    > Change-Id: I2248c1d520bc819436bbe732373f7a3446b64f48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575057
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#71654}
    
    TBR=petermarshall@chromium.org,clemensb@chromium.org,thibaudm@chromium.org
    
    Change-Id: I03c90c77b55e770797a6d66b1d778992a047e07a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1125986
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575070Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71660}
    8d013ea1
Name
Last commit
Last update
..
console Loading commit data...
counters Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...