• Benedikt Meurer's avatar
    Reland "[inspector] Consistently format all native accessors as own properties." · fb86158a
    Benedikt Meurer authored
    This is a reland of ce8cef36
    
    Original change's description:
    > [inspector] Consistently format all native accessors as own properties.
    >
    > Previously the V8 inspector would only turn embedder accessors on the
    > prototype chain into data properties, but would not do the same for
    > ECMAScript builtins, which is kind of inconsistent and weird behavior.
    >
    > This leaves in the hack that the inspector reports native accessor
    > properties as (own) data properties, but now at least the very least
    > does so consistently. In the absence of a better solution, we'll go
    > with this for now.
    >
    > Bug: chromium:1076820, chromium:1199247
    > Change-Id: I593f909a46cb714dbec629a2944eeb892881ba6f
    > Before: https://imgur.com/kPuSldj.png
    > After: https://imgur.com/eFau45m.png
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067319
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76059}
    
    Bug: chromium:1076820, chromium:1199247
    Change-Id: I11987194b0d0b8b250eda4f8ce0ae5fc743eb27c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070701
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76084}
    fb86158a
Name
Last commit
Last update
..
console Loading commit data...
counters Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...