• Clemens Backes's avatar
    [wasm] Avoid repeated checking for stack growing · fa955653
    Clemens Backes authored
    The vast majority of operations increases the stack size by at most one.
    Many opcode (e.g. all unary and binary operations) never grow the stack
    at all. Still, for every "push" operation, they check whether the
    storage for the vector that holds the stack values needs to grow.
    
    This CL avoids those redundant checks by ensuring that there is space
    for at least one more stack element before decoding each instruction.
    
    By centralizing this check, we not only improve performance, but also
    reduce code size significantly (~49 kB on x64 release).
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1096565, v8:10933
    Change-Id: I986dcac734b986d1ce953b7ec3bde8ad31b4f2b7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431525
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70177}
    fa955653
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...