• Nico Weber's avatar
    Make bitfields only as wide as necessary for enums · d15d49b0
    Nico Weber authored
    clang now complains when a BitField for an enum is too wide.
    We could suppress this, but it seems kind of useful from an
    uninformed distance, so I made a few bitfields smaller instead.
    
    (For AddressingMode, since its size is target-dependent, I added
    an explicit underlying type to the enum instead, which suppresses
    the diag on a per-enum basis.)
    
    This is without any understanding of the code I'm touching.
    Especially the change in v8-internal.h feels a bit risky to me.
    
    Bug: chromium:1348574
    Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Auto-Submit: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82109}
    d15d49b0
Name
Last commit
Last update
..
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
global-handles-inl.h Loading commit data...
global-handles.cc Loading commit data...
global-handles.h Loading commit data...
handles-inl.h Loading commit data...
handles.cc Loading commit data...
handles.h Loading commit data...
local-handles-inl.h Loading commit data...
local-handles.cc Loading commit data...
local-handles.h Loading commit data...
maybe-handles-inl.h Loading commit data...
maybe-handles.h Loading commit data...
persistent-handles.cc Loading commit data...
persistent-handles.h Loading commit data...